[INFO] updating cached repository Jkillelea/colorize [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jkillelea/colorize [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jkillelea/colorize" "work/ex/clippy-test-run/sources/stable/gh/Jkillelea/colorize"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jkillelea/colorize'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jkillelea/colorize" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jkillelea/colorize"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jkillelea/colorize'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5e2d8cdc7954e80996778b8f14d86cd86111d667 [INFO] sha for GitHub repo Jkillelea/colorize: 5e2d8cdc7954e80996778b8f14d86cd86111d667 [INFO] validating manifest of Jkillelea/colorize on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jkillelea/colorize on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jkillelea/colorize [INFO] finished frobbing Jkillelea/colorize [INFO] frobbed toml for Jkillelea/colorize written to work/ex/clippy-test-run/sources/stable/gh/Jkillelea/colorize/Cargo.toml [INFO] started frobbing Jkillelea/colorize [INFO] finished frobbing Jkillelea/colorize [INFO] frobbed toml for Jkillelea/colorize written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jkillelea/colorize/Cargo.toml [INFO] crate Jkillelea/colorize has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jkillelea/colorize against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jkillelea/colorize:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3887ba756ceb5a4d2312eeeb28404984d5b6441199ca1fce7ddfe3ea12391233 [INFO] running `"docker" "start" "-a" "3887ba756ceb5a4d2312eeeb28404984d5b6441199ca1fce7ddfe3ea12391233"` [INFO] [stderr] Checking colorize v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:51:37 [INFO] [stderr] | [INFO] [stderr] 51 | fn foreground(&self, colorcode: &ForegroundCode) -> String; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `ForegroundCode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:52:37 [INFO] [stderr] | [INFO] [stderr] 52 | fn background(&self, colorcode: &BackgroundCode) -> String; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `BackgroundCode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | fn style(&self, colorcode: &StyleCode) -> String; [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `StyleCode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:51:37 [INFO] [stderr] | [INFO] [stderr] 51 | fn foreground(&self, colorcode: &ForegroundCode) -> String; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `ForegroundCode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:52:37 [INFO] [stderr] | [INFO] [stderr] 52 | fn background(&self, colorcode: &BackgroundCode) -> String; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `BackgroundCode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | fn style(&self, colorcode: &StyleCode) -> String; [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `StyleCode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.70s [INFO] running `"docker" "inspect" "3887ba756ceb5a4d2312eeeb28404984d5b6441199ca1fce7ddfe3ea12391233"` [INFO] running `"docker" "rm" "-f" "3887ba756ceb5a4d2312eeeb28404984d5b6441199ca1fce7ddfe3ea12391233"` [INFO] [stdout] 3887ba756ceb5a4d2312eeeb28404984d5b6441199ca1fce7ddfe3ea12391233