[INFO] updating cached repository Jellonator/Emailang [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jellonator/Emailang [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jellonator/Emailang" "work/ex/clippy-test-run/sources/stable/gh/Jellonator/Emailang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jellonator/Emailang'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jellonator/Emailang" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jellonator/Emailang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jellonator/Emailang'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 374f1f91e1fdf4cd13a8ef4dd243e52709a7650a [INFO] sha for GitHub repo Jellonator/Emailang: 374f1f91e1fdf4cd13a8ef4dd243e52709a7650a [INFO] validating manifest of Jellonator/Emailang on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jellonator/Emailang on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jellonator/Emailang [INFO] finished frobbing Jellonator/Emailang [INFO] frobbed toml for Jellonator/Emailang written to work/ex/clippy-test-run/sources/stable/gh/Jellonator/Emailang/Cargo.toml [INFO] started frobbing Jellonator/Emailang [INFO] finished frobbing Jellonator/Emailang [INFO] frobbed toml for Jellonator/Emailang written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jellonator/Emailang/Cargo.toml [INFO] crate Jellonator/Emailang has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jellonator/Emailang against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jellonator/Emailang:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba8120a0dabcd3e23c0af6fcd96e21255f12dd86a6db2eb7eeeb276cab04ae9f [INFO] running `"docker" "start" "-a" "ba8120a0dabcd3e23c0af6fcd96e21255f12dd86a6db2eb7eeeb276cab04ae9f"` [INFO] [stderr] Checking regex-syntax v0.3.5 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.77 [INFO] [stderr] Checking emailang v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/interpreter/std/stdio.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/textparser.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/textparser.rs:110:4 [INFO] [stderr] | [INFO] [stderr] 110 | column: column [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | attachments: attachments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attachments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | errortype: errortype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `errortype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | errortype: errortype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `errortype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | errortype: errortype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `errortype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:60:2 [INFO] [stderr] | [INFO] [stderr] 60 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/interpreter/std/stdio.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/textparser.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/textparser.rs:110:4 [INFO] [stderr] | [INFO] [stderr] 110 | column: column [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mail.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | attachments: attachments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attachments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | errortype: errortype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `errortype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | errortype: errortype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `errortype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | errortype: errortype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `errortype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:60:2 [INFO] [stderr] | [INFO] [stderr] 60 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symbols.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/symbols.rs:155:12 [INFO] [stderr] | [INFO] [stderr] 155 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 156 | | if symbolparser::is_expression(&val.0) { [INFO] [stderr] 157 | | Ok(Type::Expression(Box::new(try!(symbolparser::parse_expression(&val.0, [INFO] [stderr] 158 | | SyntaxErrorFactory::from_symbols(&val.0)))))) [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | } else if symbolparser::is_expression(&val.0) { [INFO] [stderr] 156 | Ok(Type::Expression(Box::new(try!(symbolparser::parse_expression(&val.0, [INFO] [stderr] 157 | SyntaxErrorFactory::from_symbols(&val.0)))))) [INFO] [stderr] 158 | } else { [INFO] [stderr] 159 | assert!(val.0.len() == 1); [INFO] [stderr] 160 | Ok(try!(try!(val.0.get(0) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/mod.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser/textparser.rs:60:6 [INFO] [stderr] | [INFO] [stderr] 60 | if other.val == m { [INFO] [stderr] | _____________________^ [INFO] [stderr] 61 | | if !is_esc { [INFO] [stderr] 62 | | break [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if other.val == m && !is_esc { [INFO] [stderr] 61 | break [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symbols.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/symbols.rs:155:12 [INFO] [stderr] | [INFO] [stderr] 155 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 156 | | if symbolparser::is_expression(&val.0) { [INFO] [stderr] 157 | | Ok(Type::Expression(Box::new(try!(symbolparser::parse_expression(&val.0, [INFO] [stderr] 158 | | SyntaxErrorFactory::from_symbols(&val.0)))))) [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | } else if symbolparser::is_expression(&val.0) { [INFO] [stderr] 156 | Ok(Type::Expression(Box::new(try!(symbolparser::parse_expression(&val.0, [INFO] [stderr] 157 | SyntaxErrorFactory::from_symbols(&val.0)))))) [INFO] [stderr] 158 | } else { [INFO] [stderr] 159 | assert!(val.0.len() == 1); [INFO] [stderr] 160 | Ok(try!(try!(val.0.get(0) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/mod.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser/textparser.rs:60:6 [INFO] [stderr] | [INFO] [stderr] 60 | if other.val == m { [INFO] [stderr] | _____________________^ [INFO] [stderr] 61 | | if !is_esc { [INFO] [stderr] 62 | | break [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if other.val == m && !is_esc { [INFO] [stderr] 61 | break [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/interpreter/mod.rs:58:7 [INFO] [stderr] | [INFO] [stderr] 58 | let mut serv = match self.get_server(&tserver) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/interpreter/mod.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | let mut user = match serv.get_user_mut(&tuser) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | Type::Tuple(ref t) => t.len() > 0, [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!t.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:198:8 [INFO] [stderr] | [INFO] [stderr] 198 | ).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:197:41 [INFO] [stderr] | [INFO] [stderr] 197 | |v|v.get_string(inter, from, env).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:201:8 [INFO] [stderr] | [INFO] [stderr] 201 | ).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:200:41 [INFO] [stderr] | [INFO] [stderr] 200 | |v|v.get_string(inter, from, env).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:203:44 [INFO] [stderr] | [INFO] [stderr] 203 | |v|t[v].get_string(inter, from, env).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/symbols.rs:13:4 [INFO] [stderr] | [INFO] [stderr] 13 | match val.symbol { [INFO] [stderr] | _____________^ [INFO] [stderr] 14 | | Symbol::Comma => return true, [INFO] [stderr] 15 | | _ => {} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Symbol::Comma = val.symbol { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/symbols.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | .ok_or(self.errfactory.gen_error(SyntaxErrorType::BadExpression))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| self.errfactory.gen_error(SyntaxErrorType::BadExpression))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/interpreter/std/stdcmp.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | match mail.attachments.get(0) == mail.attachments.get(1) { [INFO] [stderr] | _________________^ [INFO] [stderr] 10 | | true => "true", [INFO] [stderr] 11 | | false => "false" [INFO] [stderr] 12 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if mail.attachments.get(0) == mail.attachments.get(1) { "true" } else { "false" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/interpreter/std/stdcmp.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | match mail.attachments.get(0) != mail.attachments.get(1) { [INFO] [stderr] | _________________^ [INFO] [stderr] 18 | | true => "true", [INFO] [stderr] 19 | | false => "false" [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if mail.attachments.get(0) != mail.attachments.get(1) { "true" } else { "false" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/interpreter/std/stdmath.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | }) [INFO] [stderr] | ___________________^ [INFO] [stderr] 21 | | .fold(0, |acc, x| acc + x); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/interpreter/std/stdmath.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | }) [INFO] [stderr] | ___________________^ [INFO] [stderr] 41 | | .fold(1, |acc, x| acc * x); [INFO] [stderr] | |__________________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::Interpreter` [INFO] [stderr] --> src/interpreter/mod.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new() -> Interpreter { [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | let mut inter = Interpreter { [INFO] [stderr] 22 | | servers: HashMap::new(), [INFO] [stderr] 23 | | pending: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 31 | | inter [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/mod.rs:73:6 [INFO] [stderr] | [INFO] [stderr] 73 | if self.servers_to_add.len() == 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.servers_to_add.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/mod.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | self.users_to_add.len() == 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.users_to_add.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/mod.rs:75:6 [INFO] [stderr] | [INFO] [stderr] 75 | self.pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/mod.rs:98:38 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn run(&mut self, instructions: &Vec, from: &UserPath, env: &mut Environment) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/mod.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn execute(&mut self, instructions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/symbolparser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | if symbols.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `symbols` [INFO] [stderr] --> src/parser/symbolparser.rs:39:11 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..pos { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for (i, ) in symbols.iter().enumerate().take(pos) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/parser/symbolparser.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | pos = i; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/symbolparser.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | if chunk.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chunk.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser/symbolparser.rs:140:3 [INFO] [stderr] | [INFO] [stderr] 140 | .ok_or(symbols[0].errfactory.gen_error(SyntaxErrorType::MalformedIfStatement)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| symbols[0].errfactory.gen_error(SyntaxErrorType::MalformedIfStatement))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/symbolparser.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | ifblk.map(|val|Instruction::IfBlock(val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::IfBlock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/symbolparser.rs:190:6 [INFO] [stderr] | [INFO] [stderr] 190 | if chunk.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chunk.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser/symbolparser.rs:196:8 [INFO] [stderr] | [INFO] [stderr] 196 | let ref symbol = chunk[1].symbol; [INFO] [stderr] | ----^^^^^^^^^^------------------- help: try: `let symbol = &chunk[1].symbol;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/textparser.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | if text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser/textparser.rs:135:2 [INFO] [stderr] | [INFO] [stderr] 135 | loop { [INFO] [stderr] | _____^ [INFO] [stderr] 136 | | let c = match chars.next() { [INFO] [stderr] 137 | | Some(val) => val, [INFO] [stderr] 138 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 214 | | }); [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(val) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/textparser.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | lastchar = Some(c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser/textparser.rs:152:47 [INFO] [stderr] | [INFO] [stderr] 152 | let pos = try!(codechars_find(&path, '@').ok_or(SyntaxError::new( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 153 | | c.line, c.column, SyntaxErrorType::MalformedUserpath))); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | let pos = try!(codechars_find(&path, '@').ok_or_else(|| SyntaxError::new( [INFO] [stderr] 153 | c.line, c.column, SyntaxErrorType::MalformedUserpath))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/instruction.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | if let None = self.elseblock { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 18 | | self.elseblock = Some(Box::new(condblock)); [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | self.elseblock.as_mut().unwrap().append_block(condblock); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________- help: try this: `if self.elseblock.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | match self.elseblock { [INFO] [stderr] | _____________^ [INFO] [stderr] 33 | | Some(ref eb) => eb.call(inter, from, env), [INFO] [stderr] 34 | | None => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(ref eb) = self.elseblock { eb.call(inter, from, env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/error.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | if symbols.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `environment::Environment` [INFO] [stderr] --> src/environment.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new() -> Environment { [INFO] [stderr] | _____^ [INFO] [stderr] 11 | | Environment { [INFO] [stderr] 12 | | data: HashMap::new() [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modifier.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if args.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modifier.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if args.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modifier.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | .map(|v|Type::Text(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Type::Text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:30:2 [INFO] [stderr] | [INFO] [stderr] 30 | match file.read_to_string(&mut contents) { [INFO] [stderr] | _____^ [INFO] [stderr] 31 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 32 | | Ok(_) => {} [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut contents) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/interpreter/mod.rs:58:7 [INFO] [stderr] | [INFO] [stderr] 58 | let mut serv = match self.get_server(&tserver) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/interpreter/mod.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | let mut user = match serv.get_user_mut(&tuser) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | Type::Tuple(ref t) => t.len() > 0, [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!t.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:198:8 [INFO] [stderr] | [INFO] [stderr] 198 | ).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:197:41 [INFO] [stderr] | [INFO] [stderr] 197 | |v|v.get_string(inter, from, env).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:201:8 [INFO] [stderr] | [INFO] [stderr] 201 | ).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:200:41 [INFO] [stderr] | [INFO] [stderr] 200 | |v|v.get_string(inter, from, env).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/types.rs:203:44 [INFO] [stderr] | [INFO] [stderr] 203 | |v|t[v].get_string(inter, from, env).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/symbols.rs:13:4 [INFO] [stderr] | [INFO] [stderr] 13 | match val.symbol { [INFO] [stderr] | _____________^ [INFO] [stderr] 14 | | Symbol::Comma => return true, [INFO] [stderr] 15 | | _ => {} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Symbol::Comma = val.symbol { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/symbols.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | .ok_or(self.errfactory.gen_error(SyntaxErrorType::BadExpression))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| self.errfactory.gen_error(SyntaxErrorType::BadExpression))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/interpreter/std/stdcmp.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | match mail.attachments.get(0) == mail.attachments.get(1) { [INFO] [stderr] | _________________^ [INFO] [stderr] 10 | | true => "true", [INFO] [stderr] 11 | | false => "false" [INFO] [stderr] 12 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if mail.attachments.get(0) == mail.attachments.get(1) { "true" } else { "false" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/interpreter/std/stdcmp.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | match mail.attachments.get(0) != mail.attachments.get(1) { [INFO] [stderr] | _________________^ [INFO] [stderr] 18 | | true => "true", [INFO] [stderr] 19 | | false => "false" [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if mail.attachments.get(0) != mail.attachments.get(1) { "true" } else { "false" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/interpreter/std/stdmath.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | }) [INFO] [stderr] | ___________________^ [INFO] [stderr] 21 | | .fold(0, |acc, x| acc + x); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/interpreter/std/stdmath.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | }) [INFO] [stderr] | ___________________^ [INFO] [stderr] 41 | | .fold(1, |acc, x| acc * x); [INFO] [stderr] | |__________________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::Interpreter` [INFO] [stderr] --> src/interpreter/mod.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new() -> Interpreter { [INFO] [stderr] | _____^ [INFO] [stderr] 21 | | let mut inter = Interpreter { [INFO] [stderr] 22 | | servers: HashMap::new(), [INFO] [stderr] 23 | | pending: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 31 | | inter [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/mod.rs:73:6 [INFO] [stderr] | [INFO] [stderr] 73 | if self.servers_to_add.len() == 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.servers_to_add.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/mod.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | self.users_to_add.len() == 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.users_to_add.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/interpreter/mod.rs:75:6 [INFO] [stderr] | [INFO] [stderr] 75 | self.pending.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/mod.rs:98:38 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn run(&mut self, instructions: &Vec, from: &UserPath, env: &mut Environment) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interpreter/mod.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/mod.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn execute(&mut self, instructions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/symbolparser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | if symbols.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `symbols` [INFO] [stderr] --> src/parser/symbolparser.rs:39:11 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..pos { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for (i, ) in symbols.iter().enumerate().take(pos) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/parser/symbolparser.rs:42:4 [INFO] [stderr] | [INFO] [stderr] 42 | pos = i; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/symbolparser.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | if chunk.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chunk.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser/symbolparser.rs:140:3 [INFO] [stderr] | [INFO] [stderr] 140 | .ok_or(symbols[0].errfactory.gen_error(SyntaxErrorType::MalformedIfStatement)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| symbols[0].errfactory.gen_error(SyntaxErrorType::MalformedIfStatement))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/symbolparser.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | ifblk.map(|val|Instruction::IfBlock(val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::IfBlock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/symbolparser.rs:190:6 [INFO] [stderr] | [INFO] [stderr] 190 | if chunk.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chunk.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser/symbolparser.rs:196:8 [INFO] [stderr] | [INFO] [stderr] 196 | let ref symbol = chunk[1].symbol; [INFO] [stderr] | ----^^^^^^^^^^------------------- help: try: `let symbol = &chunk[1].symbol;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/textparser.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | if text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser/textparser.rs:135:2 [INFO] [stderr] | [INFO] [stderr] 135 | loop { [INFO] [stderr] | _____^ [INFO] [stderr] 136 | | let c = match chars.next() { [INFO] [stderr] 137 | | Some(val) => val, [INFO] [stderr] 138 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 214 | | }); [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(val) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/textparser.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | lastchar = Some(c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser/textparser.rs:152:47 [INFO] [stderr] | [INFO] [stderr] 152 | let pos = try!(codechars_find(&path, '@').ok_or(SyntaxError::new( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 153 | | c.line, c.column, SyntaxErrorType::MalformedUserpath))); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | let pos = try!(codechars_find(&path, '@').ok_or_else(|| SyntaxError::new( [INFO] [stderr] 153 | c.line, c.column, SyntaxErrorType::MalformedUserpath))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/instruction.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | if let None = self.elseblock { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 18 | | self.elseblock = Some(Box::new(condblock)); [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | self.elseblock.as_mut().unwrap().append_block(condblock); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________- help: try this: `if self.elseblock.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | match self.elseblock { [INFO] [stderr] | _____________^ [INFO] [stderr] 33 | | Some(ref eb) => eb.call(inter, from, env), [INFO] [stderr] 34 | | None => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(ref eb) = self.elseblock { eb.call(inter, from, env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/error.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | if symbols.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `environment::Environment` [INFO] [stderr] --> src/environment.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new() -> Environment { [INFO] [stderr] | _____^ [INFO] [stderr] 11 | | Environment { [INFO] [stderr] 12 | | data: HashMap::new() [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modifier.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if args.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/modifier.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if args.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modifier.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | .map(|v|Type::Text(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Type::Text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:30:2 [INFO] [stderr] | [INFO] [stderr] 30 | match file.read_to_string(&mut contents) { [INFO] [stderr] | _____^ [INFO] [stderr] 31 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 32 | | Ok(_) => {} [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut contents) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.70s [INFO] running `"docker" "inspect" "ba8120a0dabcd3e23c0af6fcd96e21255f12dd86a6db2eb7eeeb276cab04ae9f"` [INFO] running `"docker" "rm" "-f" "ba8120a0dabcd3e23c0af6fcd96e21255f12dd86a6db2eb7eeeb276cab04ae9f"` [INFO] [stdout] ba8120a0dabcd3e23c0af6fcd96e21255f12dd86a6db2eb7eeeb276cab04ae9f