[INFO] updating cached repository Jeffail/jc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jeffail/jc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jeffail/jc" "work/ex/clippy-test-run/sources/stable/gh/Jeffail/jc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jeffail/jc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jeffail/jc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jeffail/jc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jeffail/jc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 710379e1b25f908b980af5f2143ef07aacb3f2c6 [INFO] sha for GitHub repo Jeffail/jc: 710379e1b25f908b980af5f2143ef07aacb3f2c6 [INFO] validating manifest of Jeffail/jc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jeffail/jc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jeffail/jc [INFO] finished frobbing Jeffail/jc [INFO] frobbed toml for Jeffail/jc written to work/ex/clippy-test-run/sources/stable/gh/Jeffail/jc/Cargo.toml [INFO] started frobbing Jeffail/jc [INFO] finished frobbing Jeffail/jc [INFO] frobbed toml for Jeffail/jc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jeffail/jc/Cargo.toml [INFO] crate Jeffail/jc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jeffail/jc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jeffail/jc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0ddee0d2f265761bc8b3a25c36604902a015484196e6ab49a11414abc1f2e6e [INFO] running `"docker" "start" "-a" "b0ddee0d2f265761bc8b3a25c36604902a015484196e6ab49a11414abc1f2e6e"` [INFO] [stderr] Checking siphasher v0.1.3 [INFO] [stderr] Checking chan v0.1.20 [INFO] [stderr] Checking hyperloglog v0.0.11 [INFO] [stderr] Checking chan-signal v0.3.1 [INFO] [stderr] Checking jc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/main.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / impl Hash for JValue { [INFO] [stderr] 69 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 70 | | match self { [INFO] [stderr] 71 | | &JValue::Null => state.write_u8(0), [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/main.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | #[derive(PartialEq, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match self { [INFO] [stderr] 71 | | &JValue::Null => state.write_u8(0), [INFO] [stderr] 72 | | &JValue::Bool(ref b) => state.write_u8(if *b { 1u8 } else { 0u8 }), [INFO] [stderr] 73 | | &JValue::Float(ref n) => state.write(format!("{}", n).as_bytes()), [INFO] [stderr] ... | [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *self { [INFO] [stderr] 71 | JValue::Null => state.write_u8(0), [INFO] [stderr] 72 | JValue::Bool(ref b) => state.write_u8(if *b { 1u8 } else { 0u8 }), [INFO] [stderr] 73 | JValue::Float(ref n) => state.write(format!("{}", n).as_bytes()), [INFO] [stderr] 74 | JValue::String(ref s) => state.write(s.as_bytes()), [INFO] [stderr] 75 | JValue::Array(ref a) => a.hash(state), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | if new_path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `new_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:194:16 [INFO] [stderr] | [INFO] [stderr] 194 | if new_path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `new_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `jc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/main.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / impl Hash for JValue { [INFO] [stderr] 69 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 70 | | match self { [INFO] [stderr] 71 | | &JValue::Null => state.write_u8(0), [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/main.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | #[derive(PartialEq, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match self { [INFO] [stderr] 71 | | &JValue::Null => state.write_u8(0), [INFO] [stderr] 72 | | &JValue::Bool(ref b) => state.write_u8(if *b { 1u8 } else { 0u8 }), [INFO] [stderr] 73 | | &JValue::Float(ref n) => state.write(format!("{}", n).as_bytes()), [INFO] [stderr] ... | [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *self { [INFO] [stderr] 71 | JValue::Null => state.write_u8(0), [INFO] [stderr] 72 | JValue::Bool(ref b) => state.write_u8(if *b { 1u8 } else { 0u8 }), [INFO] [stderr] 73 | JValue::Float(ref n) => state.write(format!("{}", n).as_bytes()), [INFO] [stderr] 74 | JValue::String(ref s) => state.write(s.as_bytes()), [INFO] [stderr] 75 | JValue::Array(ref a) => a.hash(state), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | if new_path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `new_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:194:16 [INFO] [stderr] | [INFO] [stderr] 194 | if new_path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `new_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `jc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b0ddee0d2f265761bc8b3a25c36604902a015484196e6ab49a11414abc1f2e6e"` [INFO] running `"docker" "rm" "-f" "b0ddee0d2f265761bc8b3a25c36604902a015484196e6ab49a11414abc1f2e6e"` [INFO] [stdout] b0ddee0d2f265761bc8b3a25c36604902a015484196e6ab49a11414abc1f2e6e