[INFO] updating cached repository Jayshua/rust-whitespace [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jayshua/rust-whitespace [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jayshua/rust-whitespace" "work/ex/clippy-test-run/sources/stable/gh/Jayshua/rust-whitespace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jayshua/rust-whitespace'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jayshua/rust-whitespace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jayshua/rust-whitespace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jayshua/rust-whitespace'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e40aee9311b11bcf363e0c7396d538193838b3a6 [INFO] sha for GitHub repo Jayshua/rust-whitespace: e40aee9311b11bcf363e0c7396d538193838b3a6 [INFO] validating manifest of Jayshua/rust-whitespace on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jayshua/rust-whitespace on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jayshua/rust-whitespace [INFO] finished frobbing Jayshua/rust-whitespace [INFO] frobbed toml for Jayshua/rust-whitespace written to work/ex/clippy-test-run/sources/stable/gh/Jayshua/rust-whitespace/Cargo.toml [INFO] started frobbing Jayshua/rust-whitespace [INFO] finished frobbing Jayshua/rust-whitespace [INFO] frobbed toml for Jayshua/rust-whitespace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jayshua/rust-whitespace/Cargo.toml [INFO] crate Jayshua/rust-whitespace has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jayshua/rust-whitespace against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jayshua/rust-whitespace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 478dde872c0210f7443900eefb5ddd5e0cae0e2ff1200baddf8b94850caf7b47 [INFO] running `"docker" "start" "-a" "478dde872c0210f7443900eefb5ddd5e0cae0e2ff1200baddf8b94850caf7b47"` [INFO] [stderr] Checking whitespace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:87:10 [INFO] [stderr] | [INFO] [stderr] 87 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/virtual_machine.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:87:10 [INFO] [stderr] | [INFO] [stderr] 87 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/virtual_machine.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | parsed_program [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | let parsed_program = _parse(&mut tokenizer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:111:7 [INFO] [stderr] | [INFO] [stderr] 111 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | parsed_program [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | let parsed_program = _parse(&mut tokenizer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:111:7 [INFO] [stderr] | [INFO] [stderr] 111 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &Label(label) = action { [INFO] [stderr] 47 | | labels.insert(label, program_pointer); [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | program_pointer += 1; [INFO] [stderr] 50 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | if let Label(label) = *action { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:60:77 [INFO] [stderr] | [INFO] [stderr] 60 | Call (ref label) => reduced_program.push(Call (*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:61:77 [INFO] [stderr] | [INFO] [stderr] 61 | Jump (ref label) => reduced_program.push(Jump (*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:62:77 [INFO] [stderr] | [INFO] [stderr] 62 | JumpIfZero (ref label) => reduced_program.push(JumpIfZero (*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:63:77 [INFO] [stderr] | [INFO] [stderr] 63 | JumpIfNegative(ref label) => reduced_program.push(JumpIfNegative(*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/virtual_machine.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn execute(&mut self) { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | // Loop processing actions until a Halt is encountered [INFO] [stderr] 59 | | loop { [INFO] [stderr] 60 | | // Get the index of the highest element on the stack [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/virtual_machine.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | let stack_end = if self.stack.len() > 0 {self.stack.len() - 1} else {0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.stack` manually [INFO] [stderr] --> src/virtual_machine.rs:79:6 [INFO] [stderr] | [INFO] [stderr] 79 | let temporary_value = self.stack[stack_end]; [INFO] [stderr] | _____________________^ [INFO] [stderr] 80 | | self.stack[stack_end] = self.stack[stack_end - 1]; [INFO] [stderr] 81 | | self.stack[stack_end - 1] = temporary_value; [INFO] [stderr] | |_______________________________________________________________^ help: try: `self.stack.swap(stack_end, stack_end - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/virtual_machine.rs:216:36 [INFO] [stderr] | [INFO] [stderr] 216 | self.heap.insert(destination, buffer[0] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:46:7 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &Label(label) = action { [INFO] [stderr] 47 | | labels.insert(label, program_pointer); [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | program_pointer += 1; [INFO] [stderr] 50 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | if let Label(label) = *action { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:60:77 [INFO] [stderr] | [INFO] [stderr] 60 | Call (ref label) => reduced_program.push(Call (*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:61:77 [INFO] [stderr] | [INFO] [stderr] 61 | Jump (ref label) => reduced_program.push(Jump (*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:62:77 [INFO] [stderr] | [INFO] [stderr] 62 | JumpIfZero (ref label) => reduced_program.push(JumpIfZero (*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:63:77 [INFO] [stderr] | [INFO] [stderr] 63 | JumpIfNegative(ref label) => reduced_program.push(JumpIfNegative(*labels.get(label).unwrap())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[label]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/virtual_machine.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn execute(&mut self) { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | // Loop processing actions until a Halt is encountered [INFO] [stderr] 59 | | loop { [INFO] [stderr] 60 | | // Get the index of the highest element on the stack [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/virtual_machine.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | let stack_end = if self.stack.len() > 0 {self.stack.len() - 1} else {0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.stack` manually [INFO] [stderr] --> src/virtual_machine.rs:79:6 [INFO] [stderr] | [INFO] [stderr] 79 | let temporary_value = self.stack[stack_end]; [INFO] [stderr] | _____________________^ [INFO] [stderr] 80 | | self.stack[stack_end] = self.stack[stack_end - 1]; [INFO] [stderr] 81 | | self.stack[stack_end - 1] = temporary_value; [INFO] [stderr] | |_______________________________________________________________^ help: try: `self.stack.swap(stack_end, stack_end - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/virtual_machine.rs:216:36 [INFO] [stderr] | [INFO] [stderr] 216 | self.heap.insert(destination, buffer[0] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "478dde872c0210f7443900eefb5ddd5e0cae0e2ff1200baddf8b94850caf7b47"` [INFO] running `"docker" "rm" "-f" "478dde872c0210f7443900eefb5ddd5e0cae0e2ff1200baddf8b94850caf7b47"` [INFO] [stdout] 478dde872c0210f7443900eefb5ddd5e0cae0e2ff1200baddf8b94850caf7b47