[INFO] updating cached repository JayDalton/hello-world [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JayDalton/hello-world [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JayDalton/hello-world" "work/ex/clippy-test-run/sources/stable/gh/JayDalton/hello-world"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JayDalton/hello-world'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JayDalton/hello-world" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JayDalton/hello-world"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JayDalton/hello-world'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d97f82ddc352d463ec4ce0eb3d119878bd82b84 [INFO] sha for GitHub repo JayDalton/hello-world: 2d97f82ddc352d463ec4ce0eb3d119878bd82b84 [INFO] validating manifest of JayDalton/hello-world on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JayDalton/hello-world on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JayDalton/hello-world [INFO] finished frobbing JayDalton/hello-world [INFO] frobbed toml for JayDalton/hello-world written to work/ex/clippy-test-run/sources/stable/gh/JayDalton/hello-world/Cargo.toml [INFO] started frobbing JayDalton/hello-world [INFO] finished frobbing JayDalton/hello-world [INFO] frobbed toml for JayDalton/hello-world written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JayDalton/hello-world/Cargo.toml [INFO] crate JayDalton/hello-world has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JayDalton/hello-world against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JayDalton/hello-world:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39d684cfa313fb709aa38427905ea00af7bedc13645b70e2df2c3dfcc36b5ec1 [INFO] running `"docker" "start" "-a" "39d684cfa313fb709aa38427905ea00af7bedc13645b70e2df2c3dfcc36b5ec1"` [INFO] [stderr] Checking rustfft v2.0.0 [INFO] [stderr] Checking hello-world v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> source/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> source/primes.rs:178:35 [INFO] [stderr] | [INFO] [stderr] 178 | if i < 0 { Some(2) } else { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 179 | | if cmpsts[i as usize >> 5] & (1u32 << (i & 31)) == 0 { [INFO] [stderr] 180 | | Some((i + i + 3) as usize) } else { None } } [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | if i < 0 { Some(2) } else if cmpsts[i as usize >> 5] & (1u32 << (i & 31)) == 0 { [INFO] [stderr] 179 | Some((i + i + 3) as usize) } else { None } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> source/primes.rs:187:42 [INFO] [stderr] | [INFO] [stderr] 187 | let millis = (elpsd.subsec_nanos() / 1000000) as u64; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `max_num` [INFO] [stderr] --> source/primes.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn athkin_sieve(max_num: usize) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: consider using `_max_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `zeigen` [INFO] [stderr] --> source/primes.rs:220:33 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn primesums(grenze: usize, zeigen: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: consider using `_zeigen` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> source/primes.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | let mut anzahl: usize = 0; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_factors` [INFO] [stderr] --> source/primes.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn get_factors(x:u64) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_prime` [INFO] [stderr] --> source/primes.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | fn is_prime(x:u64) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_prime_factors` [INFO] [stderr] --> source/primes.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | fn get_prime_factors(x:u64) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_largest_prime` [INFO] [stderr] --> source/primes.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_largest_prime(x:u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `athkin_sieve` [INFO] [stderr] --> source/primes.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn athkin_sieve(max_num: usize) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `simple_sieve` [INFO] [stderr] --> source/primes.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn simple_sieve(limit: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `basic_sieve` [INFO] [stderr] --> source/primes.rs:127:1 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn basic_sieve(limit: usize) -> Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_duration` [INFO] [stderr] --> source/primes.rs:184:1 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn get_duration(strt: Instant) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `compare_primealgos` [INFO] [stderr] --> source/primes.rs:192:1 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn compare_primealgos(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_double` [INFO] [stderr] --> source/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn get_double(msg: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> source/primes.rs:178:35 [INFO] [stderr] | [INFO] [stderr] 178 | if i < 0 { Some(2) } else { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 179 | | if cmpsts[i as usize >> 5] & (1u32 << (i & 31)) == 0 { [INFO] [stderr] 180 | | Some((i + i + 3) as usize) } else { None } } [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | if i < 0 { Some(2) } else if cmpsts[i as usize >> 5] & (1u32 << (i & 31)) == 0 { [INFO] [stderr] 179 | Some((i + i + 3) as usize) } else { None } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> source/primes.rs:187:42 [INFO] [stderr] | [INFO] [stderr] 187 | let millis = (elpsd.subsec_nanos() / 1000000) as u64; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> source/primes.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 11 | | (n as f64).sqrt() as usize [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> source/primes.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | if n < (1 << 52) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 9 | | (n as f64).sqrt() as usize [INFO] [stderr] 10 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for x in 1..int_sqrt(max_num)+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=int_sqrt(max_num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for y in 1..int_sqrt(max_num)+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=int_sqrt(max_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> source/primes.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | vec[n] = if vec[n] {false} else {true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!vec[n]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> source/primes.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | vec[n] = if vec[n] {false} else {true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!vec[n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> source/primes.rs:87:34 [INFO] [stderr] | [INFO] [stderr] 87 | vec[n] = if vec[n] {false} else {true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!vec[n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | for n in 5..int_sqrt(max_num)+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `5..=int_sqrt(max_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | for num in 2..limit+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> source/primes.rs:176:14 [INFO] [stderr] | [INFO] [stderr] 176 | Box::new((-1 .. ndxlmt as isize).into_iter().filter_map(move |i| [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(-1 .. ndxlmt as isize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> source/primes.rs:187:18 [INFO] [stderr] | [INFO] [stderr] 187 | let millis = (elpsd.subsec_nanos() / 1000000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elpsd.subsec_nanos() / 1000000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> source/primes.rs:187:18 [INFO] [stderr] | [INFO] [stderr] 187 | let millis = (elpsd.subsec_nanos() / 1000000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elpsd.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> source/primes.rs:196:54 [INFO] [stderr] | [INFO] [stderr] 196 | println!("stupid {:?}", vrslt.iter().filter(|&n| *n == true).collect::>()); [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> source/primes.rs:199:79 [INFO] [stderr] | [INFO] [stderr] 199 | println!("stupid_sieve {} took {} milliseconds.", rslt.iter().filter(|&n| *n == true).count(), get_duration(strt)); [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hello-world`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `max_num` [INFO] [stderr] --> source/primes.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn athkin_sieve(max_num: usize) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: consider using `_max_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `zeigen` [INFO] [stderr] --> source/primes.rs:220:33 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn primesums(grenze: usize, zeigen: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: consider using `_zeigen` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> source/primes.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | let mut anzahl: usize = 0; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_factors` [INFO] [stderr] --> source/primes.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | fn get_factors(x:u64) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_prime` [INFO] [stderr] --> source/primes.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | fn is_prime(x:u64) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_prime_factors` [INFO] [stderr] --> source/primes.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | fn get_prime_factors(x:u64) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_largest_prime` [INFO] [stderr] --> source/primes.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_largest_prime(x:u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `athkin_sieve` [INFO] [stderr] --> source/primes.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn athkin_sieve(max_num: usize) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `simple_sieve` [INFO] [stderr] --> source/primes.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn simple_sieve(limit: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `basic_sieve` [INFO] [stderr] --> source/primes.rs:127:1 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn basic_sieve(limit: usize) -> Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_duration` [INFO] [stderr] --> source/primes.rs:184:1 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn get_duration(strt: Instant) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `compare_primealgos` [INFO] [stderr] --> source/primes.rs:192:1 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn compare_primealgos(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_double` [INFO] [stderr] --> source/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn get_double(msg: &str) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> source/primes.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 11 | | (n as f64).sqrt() as usize [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> source/primes.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | if n < (1 << 52) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 9 | | (n as f64).sqrt() as usize [INFO] [stderr] 10 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for x in 1..int_sqrt(max_num)+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=int_sqrt(max_num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for y in 1..int_sqrt(max_num)+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=int_sqrt(max_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> source/primes.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | vec[n] = if vec[n] {false} else {true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!vec[n]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> source/primes.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | vec[n] = if vec[n] {false} else {true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!vec[n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> source/primes.rs:87:34 [INFO] [stderr] | [INFO] [stderr] 87 | vec[n] = if vec[n] {false} else {true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!vec[n]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | for n in 5..int_sqrt(max_num)+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `5..=int_sqrt(max_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> source/primes.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | for num in 2..limit+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `2..=limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> source/primes.rs:176:14 [INFO] [stderr] | [INFO] [stderr] 176 | Box::new((-1 .. ndxlmt as isize).into_iter().filter_map(move |i| [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(-1 .. ndxlmt as isize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> source/primes.rs:187:18 [INFO] [stderr] | [INFO] [stderr] 187 | let millis = (elpsd.subsec_nanos() / 1000000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elpsd.subsec_nanos() / 1000000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> source/primes.rs:187:18 [INFO] [stderr] | [INFO] [stderr] 187 | let millis = (elpsd.subsec_nanos() / 1000000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elpsd.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> source/primes.rs:196:54 [INFO] [stderr] | [INFO] [stderr] 196 | println!("stupid {:?}", vrslt.iter().filter(|&n| *n == true).collect::>()); [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> source/primes.rs:199:79 [INFO] [stderr] | [INFO] [stderr] 199 | println!("stupid_sieve {} took {} milliseconds.", rslt.iter().filter(|&n| *n == true).count(), get_duration(strt)); [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hello-world`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "39d684cfa313fb709aa38427905ea00af7bedc13645b70e2df2c3dfcc36b5ec1"` [INFO] running `"docker" "rm" "-f" "39d684cfa313fb709aa38427905ea00af7bedc13645b70e2df2c3dfcc36b5ec1"` [INFO] [stdout] 39d684cfa313fb709aa38427905ea00af7bedc13645b70e2df2c3dfcc36b5ec1