[INFO] updating cached repository Jay9596/scribble [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jay9596/scribble [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jay9596/scribble" "work/ex/clippy-test-run/sources/stable/gh/Jay9596/scribble"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jay9596/scribble'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jay9596/scribble" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jay9596/scribble"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jay9596/scribble'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b822d305e9d47621cf278a84233514ebaef3859a [INFO] sha for GitHub repo Jay9596/scribble: b822d305e9d47621cf278a84233514ebaef3859a [INFO] validating manifest of Jay9596/scribble on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jay9596/scribble on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jay9596/scribble [INFO] finished frobbing Jay9596/scribble [INFO] frobbed toml for Jay9596/scribble written to work/ex/clippy-test-run/sources/stable/gh/Jay9596/scribble/Cargo.toml [INFO] started frobbing Jay9596/scribble [INFO] finished frobbing Jay9596/scribble [INFO] frobbed toml for Jay9596/scribble written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jay9596/scribble/Cargo.toml [INFO] crate Jay9596/scribble has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jay9596/scribble against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jay9596/scribble:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bdbd6b1d5ae65743b5d7cc56fe80d7dc017e48b7a52178a22a598ffbee175f04 [INFO] running `"docker" "start" "-a" "bdbd6b1d5ae65743b5d7cc56fe80d7dc017e48b7a52178a22a598ffbee175f04"` [INFO] [stderr] Checking scribble v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | / if name.len() == 2 { [INFO] [stderr] 162 | | if name[1] == "txt" { [INFO] [stderr] 163 | | list.push(String::from(name[0])); [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if name.len() == 2 && name[1] == "txt" { [INFO] [stderr] 162 | list.push(String::from(name[0])); [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | let _ = file.write_all(text.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | / if name.len() == 2 { [INFO] [stderr] 162 | | if name[1] == "txt" { [INFO] [stderr] 163 | | list.push(String::from(name[0])); [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if name.len() == 2 && name[1] == "txt" { [INFO] [stderr] 162 | list.push(String::from(name[0])); [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | let _ = file.write_all(text.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "bdbd6b1d5ae65743b5d7cc56fe80d7dc017e48b7a52178a22a598ffbee175f04"` [INFO] running `"docker" "rm" "-f" "bdbd6b1d5ae65743b5d7cc56fe80d7dc017e48b7a52178a22a598ffbee175f04"` [INFO] [stdout] bdbd6b1d5ae65743b5d7cc56fe80d7dc017e48b7a52178a22a598ffbee175f04