[INFO] updating cached repository JasperBRiedel/Advent-of-Code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JasperBRiedel/Advent-of-Code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JasperBRiedel/Advent-of-Code-2018" "work/ex/clippy-test-run/sources/stable/gh/JasperBRiedel/Advent-of-Code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JasperBRiedel/Advent-of-Code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JasperBRiedel/Advent-of-Code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasperBRiedel/Advent-of-Code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasperBRiedel/Advent-of-Code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6be7699bbf39091747066ed59ec4452751f594aa [INFO] sha for GitHub repo JasperBRiedel/Advent-of-Code-2018: 6be7699bbf39091747066ed59ec4452751f594aa [INFO] validating manifest of JasperBRiedel/Advent-of-Code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JasperBRiedel/Advent-of-Code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JasperBRiedel/Advent-of-Code-2018 [INFO] finished frobbing JasperBRiedel/Advent-of-Code-2018 [INFO] frobbed toml for JasperBRiedel/Advent-of-Code-2018 written to work/ex/clippy-test-run/sources/stable/gh/JasperBRiedel/Advent-of-Code-2018/Cargo.toml [INFO] started frobbing JasperBRiedel/Advent-of-Code-2018 [INFO] finished frobbing JasperBRiedel/Advent-of-Code-2018 [INFO] frobbed toml for JasperBRiedel/Advent-of-Code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasperBRiedel/Advent-of-Code-2018/Cargo.toml [INFO] crate JasperBRiedel/Advent-of-Code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JasperBRiedel/Advent-of-Code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JasperBRiedel/Advent-of-Code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bdf3ca6d6ed244d193aceb13b8421d56974ab4fa895806d9f91e5e4ba9d2732a [INFO] running `"docker" "start" "-a" "bdf3ca6d6ed244d193aceb13b8421d56974ab4fa895806d9f91e5e4ba9d2732a"` [INFO] [stderr] Checking adventofcode18 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/day2/main.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/day3/main.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/day1/main.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> examples/day1/main.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | / if frequency_history.contains(&output) { [INFO] [stderr] 25 | | if !duplicate_found { [INFO] [stderr] 26 | | println!( [INFO] [stderr] 27 | | "Iteration {} has first duplicate: {}", [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | if frequency_history.contains(&output) && !duplicate_found { [INFO] [stderr] 25 | println!( [INFO] [stderr] 26 | "Iteration {} has first duplicate: {}", [INFO] [stderr] 27 | iteration_count, output [INFO] [stderr] 28 | ); [INFO] [stderr] 29 | duplicate_found = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.33s [INFO] running `"docker" "inspect" "bdf3ca6d6ed244d193aceb13b8421d56974ab4fa895806d9f91e5e4ba9d2732a"` [INFO] running `"docker" "rm" "-f" "bdf3ca6d6ed244d193aceb13b8421d56974ab4fa895806d9f91e5e4ba9d2732a"` [INFO] [stdout] bdf3ca6d6ed244d193aceb13b8421d56974ab4fa895806d9f91e5e4ba9d2732a