[INFO] updating cached repository JasonXJ/rust-snake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JasonXJ/rust-snake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JasonXJ/rust-snake" "work/ex/clippy-test-run/sources/stable/gh/JasonXJ/rust-snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JasonXJ/rust-snake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JasonXJ/rust-snake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonXJ/rust-snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonXJ/rust-snake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d0ef42794d95ac842d892d0ccbd1602bf88f6a31 [INFO] sha for GitHub repo JasonXJ/rust-snake: d0ef42794d95ac842d892d0ccbd1602bf88f6a31 [INFO] validating manifest of JasonXJ/rust-snake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JasonXJ/rust-snake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JasonXJ/rust-snake [INFO] finished frobbing JasonXJ/rust-snake [INFO] frobbed toml for JasonXJ/rust-snake written to work/ex/clippy-test-run/sources/stable/gh/JasonXJ/rust-snake/Cargo.toml [INFO] started frobbing JasonXJ/rust-snake [INFO] finished frobbing JasonXJ/rust-snake [INFO] frobbed toml for JasonXJ/rust-snake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonXJ/rust-snake/Cargo.toml [INFO] crate JasonXJ/rust-snake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JasonXJ/rust-snake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JasonXJ/rust-snake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6636f8dcfc54336be59c82fa879d333001ada04afca0adc5e8f2b4ba1b17bbff [INFO] running `"docker" "start" "-a" "6636f8dcfc54336be59c82fa879d333001ada04afca0adc5e8f2b4ba1b17bbff"` [INFO] [stderr] Compiling serde v0.9.13 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.42.1 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Checking pistoncore-event_loop v0.31.4 [INFO] [stderr] Checking piston v0.31.4 [INFO] [stderr] Compiling serde_json v0.9.9 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking snake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | gl: gl, [INFO] [stderr] | ^^^^^^ help: replace it with: `gl` [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | gl: gl, [INFO] [stderr] | ^^^^^^ help: replace it with: `gl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:48 [INFO] [stderr] | [INFO] [stderr] 191 | snake.body.push_front(Coordinate { x: x, y: head.y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:48 [INFO] [stderr] | [INFO] [stderr] 191 | snake.body.push_front(Coordinate { x: x, y: head.y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | fn update(&mut self, _: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / if let &Button::Keyboard(key) = button { [INFO] [stderr] 101 | | if let Some(d) = Direction::from_key(key) { [INFO] [stderr] 102 | | self.snake.try_redirect(d); [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | if let Button::Keyboard(key) = *button { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | for x in (head.x-(len as isize)+1)..(head.x+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((head.x-(len as isize)+1)..=head.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / let mut old_tail = None; [INFO] [stderr] 205 | | if !growed { [INFO] [stderr] 206 | | old_tail = self.body.pop_back(); [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let old_tail = if !growed { self.body.pop_back() } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | / match full { [INFO] [stderr] 278 | | true => { [INFO] [stderr] 279 | | // TODO: This seems not very efficient because there will be bound check every time [INFO] [stderr] 280 | | // in the "render_block" [INFO] [stderr] ... | [INFO] [stderr] 292 | | }, [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 277 | if full { [INFO] [stderr] 278 | // TODO: This seems not very efficient because there will be bound check every time [INFO] [stderr] 279 | // in the "render_block" [INFO] [stderr] 280 | for y in 0..self.color_grid.len() { [INFO] [stderr] 281 | for x in 0..self.color_grid[0].len() { [INFO] [stderr] 282 | self.render_block(gl, render_args, (x as isize, y as isize)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | fn update(&mut self, _: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / if let &Button::Keyboard(key) = button { [INFO] [stderr] 101 | | if let Some(d) = Direction::from_key(key) { [INFO] [stderr] 102 | | self.snake.try_redirect(d); [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | if let Button::Keyboard(key) = *button { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | for x in (head.x-(len as isize)+1)..(head.x+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((head.x-(len as isize)+1)..=head.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / let mut old_tail = None; [INFO] [stderr] 205 | | if !growed { [INFO] [stderr] 206 | | old_tail = self.body.pop_back(); [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let old_tail = if !growed { self.body.pop_back() } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | / match full { [INFO] [stderr] 278 | | true => { [INFO] [stderr] 279 | | // TODO: This seems not very efficient because there will be bound check every time [INFO] [stderr] 280 | | // in the "render_block" [INFO] [stderr] ... | [INFO] [stderr] 292 | | }, [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 277 | if full { [INFO] [stderr] 278 | // TODO: This seems not very efficient because there will be bound check every time [INFO] [stderr] 279 | // in the "render_block" [INFO] [stderr] 280 | for y in 0..self.color_grid.len() { [INFO] [stderr] 281 | for x in 0..self.color_grid[0].len() { [INFO] [stderr] 282 | self.render_block(gl, render_args, (x as isize, y as isize)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.66s [INFO] running `"docker" "inspect" "6636f8dcfc54336be59c82fa879d333001ada04afca0adc5e8f2b4ba1b17bbff"` [INFO] running `"docker" "rm" "-f" "6636f8dcfc54336be59c82fa879d333001ada04afca0adc5e8f2b4ba1b17bbff"` [INFO] [stdout] 6636f8dcfc54336be59c82fa879d333001ada04afca0adc5e8f2b4ba1b17bbff