[INFO] updating cached repository JasonKleban/RustyEuler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JasonKleban/RustyEuler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JasonKleban/RustyEuler" "work/ex/clippy-test-run/sources/stable/gh/JasonKleban/RustyEuler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JasonKleban/RustyEuler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JasonKleban/RustyEuler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonKleban/RustyEuler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonKleban/RustyEuler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bf23e7a08037b522427d9d17be80fc5dfe8820ef [INFO] sha for GitHub repo JasonKleban/RustyEuler: bf23e7a08037b522427d9d17be80fc5dfe8820ef [INFO] validating manifest of JasonKleban/RustyEuler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JasonKleban/RustyEuler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JasonKleban/RustyEuler [INFO] finished frobbing JasonKleban/RustyEuler [INFO] frobbed toml for JasonKleban/RustyEuler written to work/ex/clippy-test-run/sources/stable/gh/JasonKleban/RustyEuler/Cargo.toml [INFO] started frobbing JasonKleban/RustyEuler [INFO] finished frobbing JasonKleban/RustyEuler [INFO] frobbed toml for JasonKleban/RustyEuler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonKleban/RustyEuler/Cargo.toml [INFO] crate JasonKleban/RustyEuler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JasonKleban/RustyEuler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JasonKleban/RustyEuler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 261e900f898928d9be33cbc6c64ec8c803e3988bdb99d081d667afd2b01e4204 [INFO] running `"docker" "start" "-a" "261e900f898928d9be33cbc6c64ec8c803e3988bdb99d081d667afd2b01e4204"` [INFO] [stderr] Checking either v1.0.3 [INFO] [stderr] Checking itertools v0.5.9 [INFO] [stderr] Checking rusty_euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | fn run(name: &str, func: fn() -> T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | fn run(name: &str, func: fn() -> T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/euler1_3.rs:8:51 [INFO] [stderr] | [INFO] [stderr] 8 | (1..1000).filter(|x| x % 3 == 0 || x % 5 == 0).fold(0, |a, i| a + i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/euler1_3.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | .find(|cand_fact| if cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 46 | | true [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | false [INFO] [stderr] 49 | | }) [INFO] [stderr] | |_____________^ help: you can reduce it to: `cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/euler7_9.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | .find(|cand_fact| if cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 24 | | true [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | false [INFO] [stderr] 27 | | }) [INFO] [stderr] | |_____________^ help: you can reduce it to: `cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/euler1_3.rs:8:51 [INFO] [stderr] | [INFO] [stderr] 8 | (1..1000).filter(|x| x % 3 == 0 || x % 5 == 0).fold(0, |a, i| a + i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/euler1_3.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | .find(|cand_fact| if cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 46 | | true [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | false [INFO] [stderr] 49 | | }) [INFO] [stderr] | |_____________^ help: you can reduce it to: `cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/euler7_9.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | .find(|cand_fact| if cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 24 | | true [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | false [INFO] [stderr] 27 | | }) [INFO] [stderr] | |_____________^ help: you can reduce it to: `cand_composite % cand_fact == 0 && gpf(*cand_fact) == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.61s [INFO] running `"docker" "inspect" "261e900f898928d9be33cbc6c64ec8c803e3988bdb99d081d667afd2b01e4204"` [INFO] running `"docker" "rm" "-f" "261e900f898928d9be33cbc6c64ec8c803e3988bdb99d081d667afd2b01e4204"` [INFO] [stdout] 261e900f898928d9be33cbc6c64ec8c803e3988bdb99d081d667afd2b01e4204