[INFO] updating cached repository Jarusk/pass-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Jarusk/pass-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Jarusk/pass-rs" "work/ex/clippy-test-run/sources/stable/gh/Jarusk/pass-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jarusk/pass-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Jarusk/pass-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jarusk/pass-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jarusk/pass-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cf0da74d4a8faab67de548db45fff74fd7843fc6
[INFO] sha for GitHub repo Jarusk/pass-rs: cf0da74d4a8faab67de548db45fff74fd7843fc6
[INFO] validating manifest of Jarusk/pass-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Jarusk/pass-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Jarusk/pass-rs
[INFO] finished frobbing Jarusk/pass-rs
[INFO] frobbed toml for Jarusk/pass-rs written to work/ex/clippy-test-run/sources/stable/gh/Jarusk/pass-rs/Cargo.toml
[INFO] started frobbing Jarusk/pass-rs
[INFO] finished frobbing Jarusk/pass-rs
[INFO] frobbed toml for Jarusk/pass-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jarusk/pass-rs/Cargo.toml
[INFO] crate Jarusk/pass-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Jarusk/pass-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jarusk/pass-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 54d3e62674af391ada4426a85e1f1d562359ae7dd8d232d6bed5f765b75b5767
[INFO] running `"docker" "start" "-a" "54d3e62674af391ada4426a85e1f1d562359ae7dd8d232d6bed5f765b75b5767"`
[INFO] [stderr]     Checking pass-rs v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/genpass.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             chars: chars,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `chars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/genpass.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             chars: chars,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `chars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/genpass.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |             for i in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'A' as u8..='Z' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |             for i in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr]   --> src/genpass.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |             for i in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'A' as u8..='Z' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |             for i in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:22:33
[INFO] [stderr]    |
[INFO] [stderr] 22 |             for i in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]   --> src/genpass.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |             for i in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'a' as u8..='z' as u8`
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr]   --> src/genpass.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |             for i in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:22:33
[INFO] [stderr]    |
[INFO] [stderr] 22 |             for i in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                                 ^^^^^^^^^
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:28:33
[INFO] [stderr]    |
[INFO] [stderr] 28 |             for i in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/genpass.rs:34:22
[INFO] [stderr]    |
[INFO] [stderr] 34 |             for i in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'0' as u8..='9' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:34:22
[INFO] [stderr]    |
[INFO] [stderr] 34 |             for i in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'0'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:34:33
[INFO] [stderr]    |
[INFO] [stderr] 34 |             for i in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'9'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `seed`.
[INFO] [stderr]   --> src/genpass.rs:44:18
[INFO] [stderr]    |
[INFO] [stderr] 44 |         for i in 0..256 {
[INFO] [stderr]    |                  ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr] 44 |         for <item> in &mut seed {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/genpass.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |             for i in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'a' as u8..='z' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |             for i in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:28:33
[INFO] [stderr]    |
[INFO] [stderr] 28 |             for i in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/genpass.rs:34:22
[INFO] [stderr]    |
[INFO] [stderr] 34 |             for i in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'0' as u8..='9' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:34:22
[INFO] [stderr]    |
[INFO] [stderr] 34 |             for i in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'0'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/genpass.rs:34:33
[INFO] [stderr]    |
[INFO] [stderr] 34 |             for i in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'9'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `seed`.
[INFO] [stderr]   --> src/genpass.rs:44:18
[INFO] [stderr]    |
[INFO] [stderr] 44 |         for i in 0..256 {
[INFO] [stderr]    |                  ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 44 |         for <item> in &mut seed {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.89s
[INFO] running `"docker" "inspect" "54d3e62674af391ada4426a85e1f1d562359ae7dd8d232d6bed5f765b75b5767"`
[INFO] running `"docker" "rm" "-f" "54d3e62674af391ada4426a85e1f1d562359ae7dd8d232d6bed5f765b75b5767"`
[INFO] [stdout] 54d3e62674af391ada4426a85e1f1d562359ae7dd8d232d6bed5f765b75b5767