[INFO] updating cached repository JanLikar/cargo-clone [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JanLikar/cargo-clone [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JanLikar/cargo-clone" "work/ex/clippy-test-run/sources/stable/gh/JanLikar/cargo-clone"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JanLikar/cargo-clone'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JanLikar/cargo-clone" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JanLikar/cargo-clone"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JanLikar/cargo-clone'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2ccc3509870937f62df40212ffb80a5b3f9e2f8a [INFO] sha for GitHub repo JanLikar/cargo-clone: 2ccc3509870937f62df40212ffb80a5b3f9e2f8a [INFO] validating manifest of JanLikar/cargo-clone on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JanLikar/cargo-clone on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JanLikar/cargo-clone [INFO] finished frobbing JanLikar/cargo-clone [INFO] frobbed toml for JanLikar/cargo-clone written to work/ex/clippy-test-run/sources/stable/gh/JanLikar/cargo-clone/Cargo.toml [INFO] started frobbing JanLikar/cargo-clone [INFO] finished frobbing JanLikar/cargo-clone [INFO] frobbed toml for JanLikar/cargo-clone written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JanLikar/cargo-clone/Cargo.toml [INFO] crate JanLikar/cargo-clone has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JanLikar/cargo-clone against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JanLikar/cargo-clone:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 875e7e4c032521b3e7705b88d14a7c8ad9f9cd30cab613e391efbeef4784f541 [INFO] running `"docker" "start" "-a" "875e7e4c032521b3e7705b88d14a7c8ad9f9cd30cab613e391efbeef4784f541"` [INFO] [stderr] Checking tar v0.4.17 [INFO] [stderr] Checking lock_api v0.1.4 [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Checking toml v0.4.7 [INFO] [stderr] Checking serde_json v1.0.31 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking curl v0.4.17 [INFO] [stderr] Checking crypto-hash v0.3.1 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking git2-curl v0.8.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking rustfix v0.4.2 [INFO] [stderr] Checking crates-io v0.18.0 [INFO] [stderr] Checking docopt v1.0.1 [INFO] [stderr] Checking cargo v0.30.0 [INFO] [stderr] Checking cargo-clone v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let path = srcid.url().to_file_path().ok().expect("path must be valid"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let path = srcid.url().to_file_path().ok().expect("path must be valid"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 50.43s [INFO] running `"docker" "inspect" "875e7e4c032521b3e7705b88d14a7c8ad9f9cd30cab613e391efbeef4784f541"` [INFO] running `"docker" "rm" "-f" "875e7e4c032521b3e7705b88d14a7c8ad9f9cd30cab613e391efbeef4784f541"` [INFO] [stdout] 875e7e4c032521b3e7705b88d14a7c8ad9f9cd30cab613e391efbeef4784f541