[INFO] updating cached repository JamieSK/tic-tac-toe
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JamieSK/tic-tac-toe
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JamieSK/tic-tac-toe" "work/ex/clippy-test-run/sources/stable/gh/JamieSK/tic-tac-toe"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JamieSK/tic-tac-toe'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JamieSK/tic-tac-toe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/tic-tac-toe"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/tic-tac-toe'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 850f7463da4b7d7db65bc596502594cb31a39d30
[INFO] sha for GitHub repo JamieSK/tic-tac-toe: 850f7463da4b7d7db65bc596502594cb31a39d30
[INFO] validating manifest of JamieSK/tic-tac-toe on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JamieSK/tic-tac-toe on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JamieSK/tic-tac-toe
[INFO] finished frobbing JamieSK/tic-tac-toe
[INFO] frobbed toml for JamieSK/tic-tac-toe written to work/ex/clippy-test-run/sources/stable/gh/JamieSK/tic-tac-toe/Cargo.toml
[INFO] started frobbing JamieSK/tic-tac-toe
[INFO] finished frobbing JamieSK/tic-tac-toe
[INFO] frobbed toml for JamieSK/tic-tac-toe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/tic-tac-toe/Cargo.toml
[INFO] crate JamieSK/tic-tac-toe has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JamieSK/tic-tac-toe against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JamieSK/tic-tac-toe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 07eb789ca83b4de7dda3fde3b81ebbc0cba0601275d320a160b7bd511b404354
[INFO] running `"docker" "start" "-a" "07eb789ca83b4de7dda3fde3b81ebbc0cba0601275d320a160b7bd511b404354"`
[INFO] [stderr]     Checking noughts_and_crosses v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:143:9
[INFO] [stderr]     |
[INFO] [stderr] 143 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:143:9
[INFO] [stderr]     |
[INFO] [stderr] 143 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game`
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Game {
[INFO] [stderr] 41 | |         Game {
[INFO] [stderr] 42 | |             player: Player::X,
[INFO] [stderr] 43 | |             board: [Player::None; 9],
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 | impl Default for Game {
[INFO] [stderr] 40 |     fn default() -> Self {
[INFO] [stderr] 41 |         Self::new()
[INFO] [stderr] 42 |     }
[INFO] [stderr] 43 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 | /         match self.play(n) {
[INFO] [stderr] 77 | |             Err(_) => self.play_random(),
[INFO] [stderr] 78 | |             Ok(_) => {},
[INFO] [stderr] 79 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(_) = self.play(n) { self.play_random() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Game`
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Game {
[INFO] [stderr] 41 | |         Game {
[INFO] [stderr] 42 | |             player: Player::X,
[INFO] [stderr] 43 | |             board: [Player::None; 9],
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 | impl Default for Game {
[INFO] [stderr] 40 |     fn default() -> Self {
[INFO] [stderr] 41 |         Self::new()
[INFO] [stderr] 42 |     }
[INFO] [stderr] 43 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 | /         match self.play(n) {
[INFO] [stderr] 77 | |             Err(_) => self.play_random(),
[INFO] [stderr] 78 | |             Ok(_) => {},
[INFO] [stderr] 79 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(_) = self.play(n) { self.play_random() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:34:21
[INFO] [stderr]    |
[INFO] [stderr] 34 | /                     match game.play(input) {
[INFO] [stderr] 35 | |                         Err(e) => println!("{}", e),
[INFO] [stderr] 36 | |                         _ => {},
[INFO] [stderr] 37 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let Err(e) = game.play(input) { println!("{}", e) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:34:21
[INFO] [stderr]    |
[INFO] [stderr] 34 | /                     match game.play(input) {
[INFO] [stderr] 35 | |                         Err(e) => println!("{}", e),
[INFO] [stderr] 36 | |                         _ => {},
[INFO] [stderr] 37 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let Err(e) = game.play(input) { println!("{}", e) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.68s
[INFO] running `"docker" "inspect" "07eb789ca83b4de7dda3fde3b81ebbc0cba0601275d320a160b7bd511b404354"`
[INFO] running `"docker" "rm" "-f" "07eb789ca83b4de7dda3fde3b81ebbc0cba0601275d320a160b7bd511b404354"`
[INFO] [stdout] 07eb789ca83b4de7dda3fde3b81ebbc0cba0601275d320a160b7bd511b404354