[INFO] updating cached repository JamieSK/connect-4 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JamieSK/connect-4 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JamieSK/connect-4" "work/ex/clippy-test-run/sources/stable/gh/JamieSK/connect-4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JamieSK/connect-4'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JamieSK/connect-4" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/connect-4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/connect-4'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5e008d41db9417055886184a4334e7d15b706e85 [INFO] sha for GitHub repo JamieSK/connect-4: 5e008d41db9417055886184a4334e7d15b706e85 [INFO] validating manifest of JamieSK/connect-4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JamieSK/connect-4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JamieSK/connect-4 [INFO] finished frobbing JamieSK/connect-4 [INFO] frobbed toml for JamieSK/connect-4 written to work/ex/clippy-test-run/sources/stable/gh/JamieSK/connect-4/Cargo.toml [INFO] started frobbing JamieSK/connect-4 [INFO] finished frobbing JamieSK/connect-4 [INFO] frobbed toml for JamieSK/connect-4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/connect-4/Cargo.toml [INFO] crate JamieSK/connect-4 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JamieSK/connect-4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JamieSK/connect-4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5c6720c946349403ab3d6c98245d65eee2708c4bfac357a988e254de3765682 [INFO] running `"docker" "start" "-a" "b5c6720c946349403ab3d6c98245d65eee2708c4bfac357a988e254de3765682"` [INFO] [stderr] Checking connect_4 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return won; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `won` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return State::Stalemate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `State::Stalemate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return won; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `won` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return State::Stalemate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `State::Stalemate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Connect4` [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Connect4 { [INFO] [stderr] 31 | | Connect4 { [INFO] [stderr] 32 | | board: vec![vec![None; 6]; 7], [INFO] [stderr] 33 | | last_player: None, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | Some(player) => format!("{}", player.fmt_win()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `player.fmt_win().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | fn fmt_win(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn pretty_print(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Connect4` [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Connect4 { [INFO] [stderr] 31 | | Connect4 { [INFO] [stderr] 32 | | board: vec![vec![None; 6]; 7], [INFO] [stderr] 33 | | last_player: None, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | Some(player) => format!("{}", player.fmt_win()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `player.fmt_win().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | fn fmt_win(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn pretty_print(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | / match game.play(player, column) { [INFO] [stderr] 15 | | Err(e) => { [INFO] [stderr] 16 | | println!("{}", e); [INFO] [stderr] 17 | | continue; [INFO] [stderr] 18 | | }, [INFO] [stderr] 19 | | _ => {}, [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Err(e) = game.play(player, column) { [INFO] [stderr] 15 | println!("{}", e); [INFO] [stderr] 16 | continue; [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | / match game.play(player, column) { [INFO] [stderr] 15 | | Err(e) => { [INFO] [stderr] 16 | | println!("{}", e); [INFO] [stderr] 17 | | continue; [INFO] [stderr] 18 | | }, [INFO] [stderr] 19 | | _ => {}, [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Err(e) = game.play(player, column) { [INFO] [stderr] 15 | println!("{}", e); [INFO] [stderr] 16 | continue; [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.14s [INFO] running `"docker" "inspect" "b5c6720c946349403ab3d6c98245d65eee2708c4bfac357a988e254de3765682"` [INFO] running `"docker" "rm" "-f" "b5c6720c946349403ab3d6c98245d65eee2708c4bfac357a988e254de3765682"` [INFO] [stdout] b5c6720c946349403ab3d6c98245d65eee2708c4bfac357a988e254de3765682