[INFO] updating cached repository JamesLaverack/ticket
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JamesLaverack/ticket
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JamesLaverack/ticket" "work/ex/clippy-test-run/sources/stable/gh/JamesLaverack/ticket"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JamesLaverack/ticket'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JamesLaverack/ticket" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamesLaverack/ticket"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamesLaverack/ticket'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3a7ae12892b4b464984b724d6e722bc998480f6a
[INFO] sha for GitHub repo JamesLaverack/ticket: 3a7ae12892b4b464984b724d6e722bc998480f6a
[INFO] validating manifest of JamesLaverack/ticket on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JamesLaverack/ticket on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JamesLaverack/ticket
[INFO] finished frobbing JamesLaverack/ticket
[INFO] frobbed toml for JamesLaverack/ticket written to work/ex/clippy-test-run/sources/stable/gh/JamesLaverack/ticket/Cargo.toml
[INFO] started frobbing JamesLaverack/ticket
[INFO] finished frobbing JamesLaverack/ticket
[INFO] frobbed toml for JamesLaverack/ticket written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamesLaverack/ticket/Cargo.toml
[INFO] crate JamesLaverack/ticket has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JamesLaverack/ticket against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JamesLaverack/ticket:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 63d04f292f5a9823ac12d78aa3b6b7142a5c57ec0f8fac72c0c7742aa3a58bdc
[INFO] running `"docker" "start" "-a" "63d04f292f5a9823ac12d78aa3b6b7142a5c57ec0f8fac72c0c7742aa3a58bdc"`
[INFO] [stderr]    Compiling cmake v0.1.29
[INFO] [stderr]    Compiling libz-sys v1.0.18
[INFO] [stderr]    Compiling curl-sys v0.4.1
[INFO] [stderr]     Checking backtrace v0.3.7
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]    Compiling libssh2-sys v0.2.6
[INFO] [stderr]    Compiling libgit2-sys v0.6.19
[INFO] [stderr]     Checking assert_cli v0.6.0
[INFO] [stderr]     Checking git2 v0.6.11
[INFO] [stderr]     Checking ticket v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:17:24
[INFO] [stderr]    |
[INFO] [stderr] 17 | const TICKETFILE_NAME:&'static str = ".ticket";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 | const GIT_HOOK:&'static str = "#!/bin/sh
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 | /     return if !ticketfile.exists() {
[INFO] [stderr] 65 | |         Err(Error::new(ErrorKind::Other, "No ticket reference for this repository, use `ticket set` to set one."))
[INFO] [stderr] 66 | |     } else {
[INFO] [stderr] 67 | |         BufReader::new(File::open(ticketfile)?).read_line(&mut contents)?;
[INFO] [stderr] 68 | |         Ok(contents)
[INFO] [stderr] 69 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if !ticketfile.exists() {
[INFO] [stderr] 65 |         Err(Error::new(ErrorKind::Other, "No ticket reference for this repository, use `ticket set` to set one."))
[INFO] [stderr] 66 |     } else {
[INFO] [stderr] 67 |         BufReader::new(File::open(ticketfile)?).read_line(&mut contents)?;
[INFO] [stderr] 68 |         Ok(contents)
[INFO] [stderr] 69 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 | /     if !force {
[INFO] [stderr] 126 | |         if !confirm("Do you want to remove ticket? This will only remove the git hook, not your `.ticket` file.") {
[INFO] [stderr] 127 | |             println!("Abort. Ticket not uninstalled.");
[INFO] [stderr] 128 | |             return Ok(());
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 125 |     if !force && !confirm("Do you want to remove ticket? This will only remove the git hook, not your `.ticket` file.") {
[INFO] [stderr] 126 |     println!("Abort. Ticket not uninstalled.");
[INFO] [stderr] 127 |     return Ok(());
[INFO] [stderr] 128 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:17:24
[INFO] [stderr]    |
[INFO] [stderr] 17 | const TICKETFILE_NAME:&'static str = ".ticket";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 | const GIT_HOOK:&'static str = "#!/bin/sh
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 | /     return if !ticketfile.exists() {
[INFO] [stderr] 65 | |         Err(Error::new(ErrorKind::Other, "No ticket reference for this repository, use `ticket set` to set one."))
[INFO] [stderr] 66 | |     } else {
[INFO] [stderr] 67 | |         BufReader::new(File::open(ticketfile)?).read_line(&mut contents)?;
[INFO] [stderr] 68 | |         Ok(contents)
[INFO] [stderr] 69 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if !ticketfile.exists() {
[INFO] [stderr] 65 |         Err(Error::new(ErrorKind::Other, "No ticket reference for this repository, use `ticket set` to set one."))
[INFO] [stderr] 66 |     } else {
[INFO] [stderr] 67 |         BufReader::new(File::open(ticketfile)?).read_line(&mut contents)?;
[INFO] [stderr] 68 |         Ok(contents)
[INFO] [stderr] 69 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 | /     if !force {
[INFO] [stderr] 126 | |         if !confirm("Do you want to remove ticket? This will only remove the git hook, not your `.ticket` file.") {
[INFO] [stderr] 127 | |             println!("Abort. Ticket not uninstalled.");
[INFO] [stderr] 128 | |             return Ok(());
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 125 |     if !force && !confirm("Do you want to remove ticket? This will only remove the git hook, not your `.ticket` file.") {
[INFO] [stderr] 126 |     println!("Abort. Ticket not uninstalled.");
[INFO] [stderr] 127 |     return Ok(());
[INFO] [stderr] 128 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2m 27s
[INFO] running `"docker" "inspect" "63d04f292f5a9823ac12d78aa3b6b7142a5c57ec0f8fac72c0c7742aa3a58bdc"`
[INFO] running `"docker" "rm" "-f" "63d04f292f5a9823ac12d78aa3b6b7142a5c57ec0f8fac72c0c7742aa3a58bdc"`
[INFO] [stdout] 63d04f292f5a9823ac12d78aa3b6b7142a5c57ec0f8fac72c0c7742aa3a58bdc