[INFO] updating cached repository JacobEberhardt/AdventOfCode
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JacobEberhardt/AdventOfCode
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JacobEberhardt/AdventOfCode" "work/ex/clippy-test-run/sources/stable/gh/JacobEberhardt/AdventOfCode"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JacobEberhardt/AdventOfCode'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JacobEberhardt/AdventOfCode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JacobEberhardt/AdventOfCode"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JacobEberhardt/AdventOfCode'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0154113192c98c2b5cfc03595d7761d381df9fc2
[INFO] sha for GitHub repo JacobEberhardt/AdventOfCode: 0154113192c98c2b5cfc03595d7761d381df9fc2
[INFO] validating manifest of JacobEberhardt/AdventOfCode on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JacobEberhardt/AdventOfCode on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JacobEberhardt/AdventOfCode
[INFO] finished frobbing JacobEberhardt/AdventOfCode
[INFO] frobbed toml for JacobEberhardt/AdventOfCode written to work/ex/clippy-test-run/sources/stable/gh/JacobEberhardt/AdventOfCode/Cargo.toml
[INFO] started frobbing JacobEberhardt/AdventOfCode
[INFO] finished frobbing JacobEberhardt/AdventOfCode
[INFO] frobbed toml for JacobEberhardt/AdventOfCode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JacobEberhardt/AdventOfCode/Cargo.toml
[INFO] crate JacobEberhardt/AdventOfCode has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JacobEberhardt/AdventOfCode against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JacobEberhardt/AdventOfCode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e1b5ced99c4a27688427de60684d6e5c8049884685e7fc4086fd65db9a2cd5c0
[INFO] running `"docker" "start" "-a" "e1b5ced99c4a27688427de60684d6e5c8049884685e7fc4086fd65db9a2cd5c0"`
[INFO] [stderr]     Checking advent_of_code v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/day2.rs:13:76
[INFO] [stderr]    |
[INFO] [stderr] 13 |         let min = row.clone().into_iter().fold(0,|acc,x|if acc==0 {x} else {if x<acc {x} else {acc}});
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if x<acc {x} else {acc}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/day3.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 |     manhattan_distance
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/day3.rs:139:30
[INFO] [stderr]     |
[INFO] [stderr] 139 |     let manhattan_distance = (grid_walker.position.x as isize - access_port_index as isize).abs() + (grid_walker.position.y as isize - access_port_index as isize).abs();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:50:22
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let input: u32 = 265149;
[INFO] [stderr]    |                      ^^^^^^ help: consider: `265_149`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/day2.rs:13:76
[INFO] [stderr]    |
[INFO] [stderr] 13 |         let min = row.clone().into_iter().fold(0,|acc,x|if acc==0 {x} else {if x<acc {x} else {acc}});
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if x<acc {x} else {acc}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/day3.rs:141:5
[INFO] [stderr]     |
[INFO] [stderr] 141 |     manhattan_distance
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/day3.rs:139:30
[INFO] [stderr]     |
[INFO] [stderr] 139 |     let manhattan_distance = (grid_walker.position.x as isize - access_port_index as isize).abs() + (grid_walker.position.y as isize - access_port_index as isize).abs();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:50:22
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let input: u32 = 265149;
[INFO] [stderr]    |                      ^^^^^^ help: consider: `265_149`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn has_left(&self, grid: &Vec<Vec<u32>>) -> bool {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: change this to: `&[Vec<u32>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3.rs:52:36
[INFO] [stderr]    |
[INFO] [stderr] 52 |     fn get_field_value(&self, grid:&Vec<Vec<u32>>) -> u32{
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: change this to: `&[Vec<u32>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:85:39
[INFO] [stderr]    |
[INFO] [stderr] 85 | pub fn grid_manhattan_distance(input: &u32) -> isize {
[INFO] [stderr]    |                                       ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/day3.rs:90:24
[INFO] [stderr]    |
[INFO] [stderr] 90 |     let mut gridsize = (*input as f64).sqrt() as usize + 1;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^ help: try: `f64::from(*input)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day3.rs:145:33
[INFO] [stderr]     |
[INFO] [stderr] 145 | pub fn grid_adjacent_sum(input: &u32) -> u32 {
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/day3.rs:150:24
[INFO] [stderr]     |
[INFO] [stderr] 150 |     let mut gridsize = (*input as f64).sqrt() as usize + 1;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^ help: try: `f64::from(*input)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn has_left(&self, grid: &Vec<Vec<u32>>) -> bool {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: change this to: `&[Vec<u32>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3.rs:52:36
[INFO] [stderr]    |
[INFO] [stderr] 52 |     fn get_field_value(&self, grid:&Vec<Vec<u32>>) -> u32{
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: change this to: `&[Vec<u32>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:85:39
[INFO] [stderr]    |
[INFO] [stderr] 85 | pub fn grid_manhattan_distance(input: &u32) -> isize {
[INFO] [stderr]    |                                       ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/day3.rs:90:24
[INFO] [stderr]    |
[INFO] [stderr] 90 |     let mut gridsize = (*input as f64).sqrt() as usize + 1;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^ help: try: `f64::from(*input)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day3.rs:145:33
[INFO] [stderr]     |
[INFO] [stderr] 145 | pub fn grid_adjacent_sum(input: &u32) -> u32 {
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `u32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/day3.rs:150:24
[INFO] [stderr]     |
[INFO] [stderr] 150 |     let mut gridsize = (*input as f64).sqrt() as usize + 1;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^ help: try: `f64::from(*input)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.00s
[INFO] running `"docker" "inspect" "e1b5ced99c4a27688427de60684d6e5c8049884685e7fc4086fd65db9a2cd5c0"`
[INFO] running `"docker" "rm" "-f" "e1b5ced99c4a27688427de60684d6e5c8049884685e7fc4086fd65db9a2cd5c0"`
[INFO] [stdout] e1b5ced99c4a27688427de60684d6e5c8049884685e7fc4086fd65db9a2cd5c0