[INFO] updating cached repository JacksonGariety/nocfgwm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JacksonGariety/nocfgwm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JacksonGariety/nocfgwm" "work/ex/clippy-test-run/sources/stable/gh/JacksonGariety/nocfgwm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JacksonGariety/nocfgwm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JacksonGariety/nocfgwm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JacksonGariety/nocfgwm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JacksonGariety/nocfgwm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] efabaf30c255fdf72e92461f0a2788bcfc6756c5 [INFO] sha for GitHub repo JacksonGariety/nocfgwm: efabaf30c255fdf72e92461f0a2788bcfc6756c5 [INFO] validating manifest of JacksonGariety/nocfgwm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JacksonGariety/nocfgwm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JacksonGariety/nocfgwm [INFO] finished frobbing JacksonGariety/nocfgwm [INFO] frobbed toml for JacksonGariety/nocfgwm written to work/ex/clippy-test-run/sources/stable/gh/JacksonGariety/nocfgwm/Cargo.toml [INFO] started frobbing JacksonGariety/nocfgwm [INFO] finished frobbing JacksonGariety/nocfgwm [INFO] frobbed toml for JacksonGariety/nocfgwm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JacksonGariety/nocfgwm/Cargo.toml [INFO] crate JacksonGariety/nocfgwm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JacksonGariety/nocfgwm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JacksonGariety/nocfgwm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ed9fe85699cab26520faba89d8ddd7cdb6cd787ad1557035ede13cbf1d64593 [INFO] running `"docker" "start" "-a" "3ed9fe85699cab26520faba89d8ddd7cdb6cd787ad1557035ede13cbf1d64593"` [INFO] [stderr] Compiling x11 v2.12.0 [INFO] [stderr] Checking wm v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return xconfigurerequest.window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xconfigurerequest.window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | return xmaprequest.window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xmaprequest.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | return xany.window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xany.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return xconfigurerequest.window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xconfigurerequest.window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | return xmaprequest.window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xmaprequest.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | return xany.window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xany.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wmhints` [INFO] [stderr] --> src/window.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let wmhints: xlib::XWMHints; [INFO] [stderr] | ^^^^^^^ help: consider using `_wmhints` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/window.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | let state: i64; [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `gc` [INFO] [stderr] --> src/window.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let gc: xlib::GC = win.title.gc; [INFO] [stderr] | ^^ help: consider using `_gc` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wmstart` [INFO] [stderr] --> src/window.rs:70:77 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn manage(display: *mut xlib::Display, root: u64, client: xlib::Window, wmstart: i32, windows: &mut Vec) { [INFO] [stderr] | ^^^^^^^ help: consider using `_wmstart` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `revert` [INFO] [stderr] --> src/main.rs:142:25 [INFO] [stderr] | [INFO] [stderr] 142 | let mut revert: c_int = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ help: consider using `_revert` instead [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 106 | let mut gcval: xlib::XGCValues = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 108 | let mut tp: Title = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:109:58 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 109 | let mut title_attr: xlib::XSetWindowAttributes = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:124:36 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 124 | let mut bg: xlib::XColor = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/parent.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn create_parent(display: *mut xlib::Display, window: &mut window::Window, [INFO] [stderr] 14 | | xparent: xlib::Window, class: i32, x: i32, [INFO] [stderr] 15 | | y: i32, width: i32, height: i32) { [INFO] [stderr] 16 | | [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:121:62 [INFO] [stderr] | [INFO] [stderr] 121 | tp.gc = xlib::XCreateGC(display, win.parent.xwindow, xlib::GCGraphicsExposures as u64, &mut gcval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(xlib::GCGraphicsExposures)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:33 [INFO] [stderr] | [INFO] [stderr] 33 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:65 [INFO] [stderr] | [INFO] [stderr] 33 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_Tab)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:65 [INFO] [stderr] | [INFO] [stderr] 35 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_Tab)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_space as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_space as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:65 [INFO] [stderr] | [INFO] [stderr] 37 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_space as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_space)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Escape as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_Escape as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:65 [INFO] [stderr] | [INFO] [stderr] 39 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Escape as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_Escape)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:65 [INFO] [stderr] | [INFO] [stderr] 41 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_BackSpace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:65 [INFO] [stderr] | [INFO] [stderr] 43 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_BackSpace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wmhints` [INFO] [stderr] --> src/window.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let wmhints: xlib::XWMHints; [INFO] [stderr] | ^^^^^^^ help: consider using `_wmhints` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/window.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | let state: i64; [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `gc` [INFO] [stderr] --> src/window.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let gc: xlib::GC = win.title.gc; [INFO] [stderr] | ^^ help: consider using `_gc` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wmstart` [INFO] [stderr] --> src/window.rs:70:77 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn manage(display: *mut xlib::Display, root: u64, client: xlib::Window, wmstart: i32, windows: &mut Vec) { [INFO] [stderr] | ^^^^^^^ help: consider using `_wmstart` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | / match windows.iter_mut().find(|ref win| win.active) { [INFO] [stderr] 130 | | Some(mut win) => { [INFO] [stderr] 131 | | window::maximize(display, win); [INFO] [stderr] 132 | | }, [INFO] [stderr] 133 | | None => () [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] warning: unused variable: `revert` [INFO] [stderr] --> src/main.rs:142:25 [INFO] [stderr] | [INFO] [stderr] 142 | let mut revert: c_int = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ help: consider using `_revert` instead [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | if let Some(mut win) = windows.iter_mut().find(|ref win| win.active) { [INFO] [stderr] 130 | window::maximize(display, win); [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | / match windows.iter().find(|&win| win.active) { [INFO] [stderr] 145 | | Some(win) => { [INFO] [stderr] 146 | | xlib::XGrabServer(display); [INFO] [stderr] 147 | | xlib::XSetErrorHandler(Some(xerr_ignore)); [INFO] [stderr] ... | [INFO] [stderr] 152 | | None => () [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(win) = windows.iter().find(|&win| win.active) { [INFO] [stderr] 145 | xlib::XGrabServer(display); [INFO] [stderr] 146 | xlib::XSetErrorHandler(Some(xerr_ignore)); [INFO] [stderr] 147 | xlib::XDestroyWindow(display, win.parent.xwindow); [INFO] [stderr] 148 | xlib::XSync(display, false as c_int); [INFO] [stderr] 149 | xlib::XUngrabServer(display); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:168:42 [INFO] [stderr] | [INFO] [stderr] 168 | let e: xlib::XErrorEvent = unsafe { *event }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 106 | let mut gcval: xlib::XGCValues = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 108 | let mut tp: Title = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:109:58 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 109 | let mut title_attr: xlib::XSetWindowAttributes = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:124:36 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe { [INFO] [stderr] | ------ because it's nested under this `unsafe` block [INFO] [stderr] ... [INFO] [stderr] 124 | let mut bg: xlib::XColor = unsafe{zeroed()}; [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/window.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] error: Could not compile `wm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/parent.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn create_parent(display: *mut xlib::Display, window: &mut window::Window, [INFO] [stderr] 14 | | xparent: xlib::Window, class: i32, x: i32, [INFO] [stderr] 15 | | y: i32, width: i32, height: i32) { [INFO] [stderr] 16 | | [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:121:62 [INFO] [stderr] | [INFO] [stderr] 121 | tp.gc = xlib::XCreateGC(display, win.parent.xwindow, xlib::GCGraphicsExposures as u64, &mut gcval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(xlib::GCGraphicsExposures)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:33 [INFO] [stderr] | [INFO] [stderr] 33 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:65 [INFO] [stderr] | [INFO] [stderr] 33 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_Tab)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:65 [INFO] [stderr] | [INFO] [stderr] 35 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Tab as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_Tab)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_space as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_space as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:65 [INFO] [stderr] | [INFO] [stderr] 37 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_space as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_space)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Escape as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_Escape as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:65 [INFO] [stderr] | [INFO] [stderr] 39 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_Escape as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_Escape)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:65 [INFO] [stderr] | [INFO] [stderr] 41 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_BackSpace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:43:65 [INFO] [stderr] | [INFO] [stderr] 43 | xlib::XGrabKey(display, xlib::XKeysymToKeycode(display, keysym::XK_BackSpace as u64) as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(keysym::XK_BackSpace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | / match windows.iter_mut().find(|ref win| win.active) { [INFO] [stderr] 130 | | Some(mut win) => { [INFO] [stderr] 131 | | window::maximize(display, win); [INFO] [stderr] 132 | | }, [INFO] [stderr] 133 | | None => () [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | if let Some(mut win) = windows.iter_mut().find(|ref win| win.active) { [INFO] [stderr] 130 | window::maximize(display, win); [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | / match windows.iter().find(|&win| win.active) { [INFO] [stderr] 145 | | Some(win) => { [INFO] [stderr] 146 | | xlib::XGrabServer(display); [INFO] [stderr] 147 | | xlib::XSetErrorHandler(Some(xerr_ignore)); [INFO] [stderr] ... | [INFO] [stderr] 152 | | None => () [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(win) = windows.iter().find(|&win| win.active) { [INFO] [stderr] 145 | xlib::XGrabServer(display); [INFO] [stderr] 146 | xlib::XSetErrorHandler(Some(xerr_ignore)); [INFO] [stderr] 147 | xlib::XDestroyWindow(display, win.parent.xwindow); [INFO] [stderr] 148 | xlib::XSync(display, false as c_int); [INFO] [stderr] 149 | xlib::XUngrabServer(display); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:168:42 [INFO] [stderr] | [INFO] [stderr] 168 | let e: xlib::XErrorEvent = unsafe { *event }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3ed9fe85699cab26520faba89d8ddd7cdb6cd787ad1557035ede13cbf1d64593"` [INFO] running `"docker" "rm" "-f" "3ed9fe85699cab26520faba89d8ddd7cdb6cd787ad1557035ede13cbf1d64593"` [INFO] [stdout] 3ed9fe85699cab26520faba89d8ddd7cdb6cd787ad1557035ede13cbf1d64593