[INFO] updating cached repository ItsMeijers/dirmando [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ItsMeijers/dirmando [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ItsMeijers/dirmando" "work/ex/clippy-test-run/sources/stable/gh/ItsMeijers/dirmando"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ItsMeijers/dirmando'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ItsMeijers/dirmando" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ItsMeijers/dirmando"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ItsMeijers/dirmando'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d857c316b9c9e31552190e10571d1f6c53c82a99 [INFO] sha for GitHub repo ItsMeijers/dirmando: d857c316b9c9e31552190e10571d1f6c53c82a99 [INFO] validating manifest of ItsMeijers/dirmando on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ItsMeijers/dirmando on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ItsMeijers/dirmando [INFO] finished frobbing ItsMeijers/dirmando [INFO] frobbed toml for ItsMeijers/dirmando written to work/ex/clippy-test-run/sources/stable/gh/ItsMeijers/dirmando/Cargo.toml [INFO] started frobbing ItsMeijers/dirmando [INFO] finished frobbing ItsMeijers/dirmando [INFO] frobbed toml for ItsMeijers/dirmando written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ItsMeijers/dirmando/Cargo.toml [INFO] crate ItsMeijers/dirmando has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ItsMeijers/dirmando against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ItsMeijers/dirmando:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18eff3e9ad3ea01b6e31663a2992b59e7a0be3a5155471f962ef7fb33953d851 [INFO] running `"docker" "start" "-a" "18eff3e9ad3ea01b6e31663a2992b59e7a0be3a5155471f962ef7fb33953d851"` [INFO] [stderr] Checking dirmando v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/dirmando.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/dirmando.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `currentDirectory` [INFO] [stderr] --> src/dirmando.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_currentDirectory` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/dirmando.rs:24:51 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] [INFO] [stderr] warning: function `fromFile` should have a snake case name such as `from_file` [INFO] [stderr] --> src/dirmando.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn fromFile(filePath: &str) -> Dirmando { [INFO] [stderr] 15 | | let mut f = File::open(filePath).expect("file not found"); [INFO] [stderr] 16 | | let mut contents = String::new(); [INFO] [stderr] 17 | | f.read_to_string(&mut contents).expect("something went wrong reading the file"); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | serde_json::from_str(&contents).unwrap() [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `filePath` should have a snake case name such as `file_path` [INFO] [stderr] --> src/dirmando.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn fromFile(filePath: &str) -> Dirmando { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dirmando.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dirmando.rs:24:60 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `currentDirectory` should have a snake case name such as `current_directory` [INFO] [stderr] --> src/dirmando.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dirmando.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn load(&self, currentDirectory: &String) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `currentDirectory` should have a snake case name such as `current_directory` [INFO] [stderr] --> src/dirmando.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn load(&self, currentDirectory: &String) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dirmando.rs:32:37 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn choose(&self, commandos: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | .conflicts_with_all(&vec!["save", "export", "import"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["save", "export", "import"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | .conflicts_with_all(&vec!["choose", "export", "import"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["choose", "export", "import"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | .conflicts_with_all(&vec!["save", "choose", "import"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["save", "choose", "import"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | .conflicts_with_all(&vec!["save", "export", "choose"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["save", "export", "choose"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: variable `currentDir` should have a snake case name such as `current_dir` [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let currentDir = String::from(current_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `commandosOpt` should have a snake case name such as `commandos_opt` [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let commandosOpt = dm.load(¤tDir); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `currentDirectory` [INFO] [stderr] --> src/dirmando.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_currentDirectory` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/dirmando.rs:24:51 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] [INFO] [stderr] warning: function `fromFile` should have a snake case name such as `from_file` [INFO] [stderr] --> src/dirmando.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn fromFile(filePath: &str) -> Dirmando { [INFO] [stderr] 15 | | let mut f = File::open(filePath).expect("file not found"); [INFO] [stderr] 16 | | let mut contents = String::new(); [INFO] [stderr] 17 | | f.read_to_string(&mut contents).expect("something went wrong reading the file"); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | serde_json::from_str(&contents).unwrap() [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `filePath` should have a snake case name such as `file_path` [INFO] [stderr] --> src/dirmando.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn fromFile(filePath: &str) -> Dirmando { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dirmando.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dirmando.rs:24:60 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `currentDirectory` should have a snake case name such as `current_directory` [INFO] [stderr] --> src/dirmando.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn save(&self, currentDirectory: &String, command: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dirmando.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn load(&self, currentDirectory: &String) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `currentDirectory` should have a snake case name such as `current_directory` [INFO] [stderr] --> src/dirmando.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn load(&self, currentDirectory: &String) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dirmando.rs:32:37 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn choose(&self, commandos: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | .conflicts_with_all(&vec!["save", "export", "import"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["save", "export", "import"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | .conflicts_with_all(&vec!["choose", "export", "import"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["choose", "export", "import"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | .conflicts_with_all(&vec!["save", "choose", "import"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["save", "choose", "import"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | .conflicts_with_all(&vec!["save", "export", "choose"])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["save", "export", "choose"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: variable `currentDir` should have a snake case name such as `current_dir` [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let currentDir = String::from(current_dir().unwrap().to_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `commandosOpt` should have a snake case name such as `commandos_opt` [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let commandosOpt = dm.load(¤tDir); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.03s [INFO] running `"docker" "inspect" "18eff3e9ad3ea01b6e31663a2992b59e7a0be3a5155471f962ef7fb33953d851"` [INFO] running `"docker" "rm" "-f" "18eff3e9ad3ea01b6e31663a2992b59e7a0be3a5155471f962ef7fb33953d851"` [INFO] [stdout] 18eff3e9ad3ea01b6e31663a2992b59e7a0be3a5155471f962ef7fb33953d851