[INFO] updating cached repository ItayGarin/emacs-launcher
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ItayGarin/emacs-launcher
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ItayGarin/emacs-launcher" "work/ex/clippy-test-run/sources/stable/gh/ItayGarin/emacs-launcher"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ItayGarin/emacs-launcher'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ItayGarin/emacs-launcher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ItayGarin/emacs-launcher"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ItayGarin/emacs-launcher'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3ed852f3685e94eee0f2c4a7e718f11529c3cd57
[INFO] sha for GitHub repo ItayGarin/emacs-launcher: 3ed852f3685e94eee0f2c4a7e718f11529c3cd57
[INFO] validating manifest of ItayGarin/emacs-launcher on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ItayGarin/emacs-launcher on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ItayGarin/emacs-launcher
[INFO] finished frobbing ItayGarin/emacs-launcher
[INFO] frobbed toml for ItayGarin/emacs-launcher written to work/ex/clippy-test-run/sources/stable/gh/ItayGarin/emacs-launcher/Cargo.toml
[INFO] started frobbing ItayGarin/emacs-launcher
[INFO] finished frobbing ItayGarin/emacs-launcher
[INFO] frobbed toml for ItayGarin/emacs-launcher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ItayGarin/emacs-launcher/Cargo.toml
[INFO] crate ItayGarin/emacs-launcher has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ItayGarin/emacs-launcher against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ItayGarin/emacs-launcher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f40519499f1e0adfb4e66126a0c9a0929be47c42870b4c139c02c8b37f6f0a5e
[INFO] running `"docker" "start" "-a" "f40519499f1e0adfb4e66126a0c9a0929be47c42870b4c139c02c8b37f6f0a5e"`
[INFO] [stderr]     Checking emacs-launcher v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return Ok(true);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         return Ok(false);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 | /     match is_running {
[INFO] [stderr] 80 | |         true => launch_emacs_client().expect("Failed to launch an Emacs client"),
[INFO] [stderr] 81 | |         false => launch_emacs_server().expect("Failed to launch an Emacs server"),
[INFO] [stderr] 82 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if is_running { launch_emacs_client().expect("Failed to launch an Emacs client") } else { launch_emacs_server().expect("Failed to launch an Emacs server") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return Ok(true);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         return Ok(false);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 | /     match is_running {
[INFO] [stderr] 80 | |         true => launch_emacs_client().expect("Failed to launch an Emacs client"),
[INFO] [stderr] 81 | |         false => launch_emacs_server().expect("Failed to launch an Emacs server"),
[INFO] [stderr] 82 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if is_running { launch_emacs_client().expect("Failed to launch an Emacs client") } else { launch_emacs_server().expect("Failed to launch an Emacs server") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.00s
[INFO] running `"docker" "inspect" "f40519499f1e0adfb4e66126a0c9a0929be47c42870b4c139c02c8b37f6f0a5e"`
[INFO] running `"docker" "rm" "-f" "f40519499f1e0adfb4e66126a0c9a0929be47c42870b4c139c02c8b37f6f0a5e"`
[INFO] [stdout] f40519499f1e0adfb4e66126a0c9a0929be47c42870b4c139c02c8b37f6f0a5e