[INFO] updating cached repository Isan-Rivkin/snake-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Isan-Rivkin/snake-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Isan-Rivkin/snake-rs" "work/ex/clippy-test-run/sources/stable/gh/Isan-Rivkin/snake-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Isan-Rivkin/snake-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Isan-Rivkin/snake-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isan-Rivkin/snake-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isan-Rivkin/snake-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77bc725ef19bd62869c82c954445d0250d1f7852 [INFO] sha for GitHub repo Isan-Rivkin/snake-rs: 77bc725ef19bd62869c82c954445d0250d1f7852 [INFO] validating manifest of Isan-Rivkin/snake-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Isan-Rivkin/snake-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Isan-Rivkin/snake-rs [INFO] finished frobbing Isan-Rivkin/snake-rs [INFO] frobbed toml for Isan-Rivkin/snake-rs written to work/ex/clippy-test-run/sources/stable/gh/Isan-Rivkin/snake-rs/Cargo.toml [INFO] started frobbing Isan-Rivkin/snake-rs [INFO] finished frobbing Isan-Rivkin/snake-rs [INFO] frobbed toml for Isan-Rivkin/snake-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isan-Rivkin/snake-rs/Cargo.toml [INFO] crate Isan-Rivkin/snake-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Isan-Rivkin/snake-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Isan-Rivkin/snake-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30bd91aca8e72572eef95054210da382549dcc4eb48866781df25204072c86b7 [INFO] running `"docker" "start" "-a" "30bd91aca8e72572eef95054210da382549dcc4eb48866781df25204072c86b7"` [INFO] [stderr] Compiling syn v0.15.3 [INFO] [stderr] Checking ordered-float v0.5.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.78 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking snake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `game::Game` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use game::Game; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `window` [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut window : PistonWindow = WindowSettings::new( [INFO] [stderr] | ^^^^^^ help: consider using `_window` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `game::Game` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use game::Game; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut window : PistonWindow = WindowSettings::new( [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_block` [INFO] [stderr] --> src/draw.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn draw_block(color : Color, x : i32, y: i32, con : &Context, g: &mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_rectangle` [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn draw_rectangle(color : Color,x : i32, y:i32,width:i32, height : i32,con : &Context,g:&mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SNAKE_COLOR` [INFO] [stderr] --> src/snake.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const SNAKE_COLOR : Color = [0.00,0.80,0.00,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Up` [INFO] [stderr] --> src/snake.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Up, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/snake.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/snake.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/snake.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `opposite` [INFO] [stderr] --> src/snake.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self)-> Direction{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Snake` [INFO] [stderr] --> src/snake.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | pub struct Snake{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/snake.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn new(x: i32, y: i32)->Snake{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw` [INFO] [stderr] --> src/snake.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn draw(&self, con: &Context, g: &mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `head_position` [INFO] [stderr] --> src/snake.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn head_position(&self)->(i32,i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_forward` [INFO] [stderr] --> src/snake.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn move_forward(&mut self, dir: Option){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `head_direction` [INFO] [stderr] --> src/snake.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn head_direction(&self)->Direction{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next_head` [INFO] [stderr] --> src/snake.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn next_head(&self, dir: Option) -> (i32,i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `restore_tail` [INFO] [stderr] --> src/snake.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn restore_tail(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overlap_tail` [INFO] [stderr] --> src/snake.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn overlap_tail(&self, x: i32, y:i32)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FOOD_COLOR` [INFO] [stderr] --> src/game.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const FOOD_COLOR : Color = [0.80,0.00,0.00,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BORDER_COLOR` [INFO] [stderr] --> src/game.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const BORDER_COLOR : Color = [0.00,0.00,0.00,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GAMEOVER_COLOR` [INFO] [stderr] --> src/game.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const GAMEOVER_COLOR : Color = [0.90,0.00,0.00,0.5]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MOVING_PERIOD` [INFO] [stderr] --> src/game.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const MOVING_PERIOD : f64 = 0.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RESTART_TIME` [INFO] [stderr] --> src/game.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const RESTART_TIME : f64 = 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Game` [INFO] [stderr] --> src/game.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub struct Game{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(width : i32, height : i32)->Game{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `key_pressed` [INFO] [stderr] --> src/game.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn key_pressed(&mut self, key : Key){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw` [INFO] [stderr] --> src/game.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn draw(&self, con: &Context, g : &mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/game.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn update(&mut self, delta_time: f64){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_eating` [INFO] [stderr] --> src/game.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | fn check_eating(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_if_snake_alive` [INFO] [stderr] --> src/game.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | fn check_if_snake_alive(&self, dir: Option)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_food` [INFO] [stderr] --> src/game.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn add_food(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_snake` [INFO] [stderr] --> src/game.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | fn update_snake(&mut self, dir: Option){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `restart` [INFO] [stderr] --> src/game.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | fn restart(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BACKGROUND_COLOR` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const BACKGROUND_COLOR : Color = [0.5,0.5,0.5,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | [x,y,BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:32:56 [INFO] [stderr] | [INFO] [stderr] 32 | [x,y,BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self)-> Direction{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match dir{ [INFO] [stderr] 73 | | Some(d)=>self.direction=d, [INFO] [stderr] 74 | | None=>(), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction=d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match dir { [INFO] [stderr] 116 | | Some(d) => moving_dir = d, [INFO] [stderr] 117 | | None => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | for block in &self.body{ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused variable: `window` [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut window : PistonWindow = WindowSettings::new( [INFO] [stderr] | ^^^^^^ help: consider using `_window` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut window : PistonWindow = WindowSettings::new( [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_block` [INFO] [stderr] --> src/draw.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn draw_block(color : Color, x : i32, y: i32, con : &Context, g: &mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_rectangle` [INFO] [stderr] --> src/draw.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn draw_rectangle(color : Color,x : i32, y:i32,width:i32, height : i32,con : &Context,g:&mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SNAKE_COLOR` [INFO] [stderr] --> src/snake.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const SNAKE_COLOR : Color = [0.00,0.80,0.00,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Up` [INFO] [stderr] --> src/snake.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Up, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/snake.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/snake.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/snake.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `opposite` [INFO] [stderr] --> src/snake.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self)-> Direction{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Snake` [INFO] [stderr] --> src/snake.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | pub struct Snake{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/snake.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn new(x: i32, y: i32)->Snake{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw` [INFO] [stderr] --> src/snake.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn draw(&self, con: &Context, g: &mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `head_position` [INFO] [stderr] --> src/snake.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn head_position(&self)->(i32,i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_forward` [INFO] [stderr] --> src/snake.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn move_forward(&mut self, dir: Option){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `head_direction` [INFO] [stderr] --> src/snake.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn head_direction(&self)->Direction{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next_head` [INFO] [stderr] --> src/snake.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn next_head(&self, dir: Option) -> (i32,i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `restore_tail` [INFO] [stderr] --> src/snake.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn restore_tail(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overlap_tail` [INFO] [stderr] --> src/snake.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn overlap_tail(&self, x: i32, y:i32)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FOOD_COLOR` [INFO] [stderr] --> src/game.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const FOOD_COLOR : Color = [0.80,0.00,0.00,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BORDER_COLOR` [INFO] [stderr] --> src/game.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const BORDER_COLOR : Color = [0.00,0.00,0.00,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GAMEOVER_COLOR` [INFO] [stderr] --> src/game.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const GAMEOVER_COLOR : Color = [0.90,0.00,0.00,0.5]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MOVING_PERIOD` [INFO] [stderr] --> src/game.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const MOVING_PERIOD : f64 = 0.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RESTART_TIME` [INFO] [stderr] --> src/game.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const RESTART_TIME : f64 = 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Game` [INFO] [stderr] --> src/game.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub struct Game{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new(width : i32, height : i32)->Game{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `key_pressed` [INFO] [stderr] --> src/game.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn key_pressed(&mut self, key : Key){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw` [INFO] [stderr] --> src/game.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn draw(&self, con: &Context, g : &mut G2d){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/game.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn update(&mut self, delta_time: f64){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_eating` [INFO] [stderr] --> src/game.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | fn check_eating(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_if_snake_alive` [INFO] [stderr] --> src/game.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | fn check_if_snake_alive(&self, dir: Option)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_food` [INFO] [stderr] --> src/game.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn add_food(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_snake` [INFO] [stderr] --> src/game.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | fn update_snake(&mut self, dir: Option){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `restart` [INFO] [stderr] --> src/game.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | fn restart(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BACKGROUND_COLOR` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const BACKGROUND_COLOR : Color = [0.5,0.5,0.5,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | [x,y,BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:32:56 [INFO] [stderr] | [INFO] [stderr] 32 | [x,y,BLOCK_SIZE * (width as f64), BLOCK_SIZE * (height as f64)], [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self)-> Direction{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match dir{ [INFO] [stderr] 73 | | Some(d)=>self.direction=d, [INFO] [stderr] 74 | | None=>(), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction=d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match dir { [INFO] [stderr] 116 | | Some(d) => moving_dir = d, [INFO] [stderr] 117 | | None => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | for block in &self.body{ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.03s [INFO] running `"docker" "inspect" "30bd91aca8e72572eef95054210da382549dcc4eb48866781df25204072c86b7"` [INFO] running `"docker" "rm" "-f" "30bd91aca8e72572eef95054210da382549dcc4eb48866781df25204072c86b7"` [INFO] [stdout] 30bd91aca8e72572eef95054210da382549dcc4eb48866781df25204072c86b7