[INFO] updating cached repository Isaac-Lozano/um-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Isaac-Lozano/um-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Isaac-Lozano/um-rust" "work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/um-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/um-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Isaac-Lozano/um-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isaac-Lozano/um-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isaac-Lozano/um-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 54183eeb66bf05b8a9c305425716d2c4c824a369 [INFO] sha for GitHub repo Isaac-Lozano/um-rust: 54183eeb66bf05b8a9c305425716d2c4c824a369 [INFO] validating manifest of Isaac-Lozano/um-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Isaac-Lozano/um-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Isaac-Lozano/um-rust [INFO] finished frobbing Isaac-Lozano/um-rust [INFO] frobbed toml for Isaac-Lozano/um-rust written to work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/um-rust/Cargo.toml [INFO] started frobbing Isaac-Lozano/um-rust [INFO] finished frobbing Isaac-Lozano/um-rust [INFO] frobbed toml for Isaac-Lozano/um-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isaac-Lozano/um-rust/Cargo.toml [INFO] crate Isaac-Lozano/um-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Isaac-Lozano/um-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/um-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d1033729474a784d618dc594a483b2161819d61922915bc229517cbecac6ddd [INFO] running `"docker" "start" "-a" "7d1033729474a784d618dc594a483b2161819d61922915bc229517cbecac6ddd"` [INFO] [stderr] Checking um v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/um.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | const OP_FUNCTION_TABLE: [&'static Fn(&mut Um, usize, usize, usize, u32) -> UmResult; 14] = [INFO] [stderr] | -^^^^^^^-------------------------------------------------------- help: consider removing `'static`: `&Fn(&mut Um, usize, usize, usize, u32) -> UmResult` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/um.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | const OP_STRING_TABLE: [&'static str; 14] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:156:35 [INFO] [stderr] | [INFO] [stderr] 156 | let opcode = ((operator & 0xF0000000) >> 28) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:191:43 [INFO] [stderr] | [INFO] [stderr] 191 | let opcode = ((operator & 0xF0000000) >> 28) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:298:56 [INFO] [stderr] | [INFO] [stderr] 298 | self.regs[a] = (self.regs[b] & self.regs[c]) ^ 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:375:29 [INFO] [stderr] | [INFO] [stderr] 375 | self.regs[((instr & 0x0E000000) >> 25) as usize] = instr & 0x01FFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0E00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:375:68 [INFO] [stderr] | [INFO] [stderr] 375 | self.regs[((instr & 0x0E000000) >> 25) as usize] = instr & 0x01FFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/um.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | const OP_FUNCTION_TABLE: [&'static Fn(&mut Um, usize, usize, usize, u32) -> UmResult; 14] = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/um.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | let operator = try!(self.zero [INFO] [stderr] | ________________________^ [INFO] [stderr] 153 | | .get(self.execution_finger) [INFO] [stderr] 154 | | .ok_or(UmError::ExecutionFingerOutOfBounds)) [INFO] [stderr] 155 | | .clone(); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 152 | let operator = *(match $ expr { [INFO] [stderr] 153 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 154 | :: Err ( err ) => { [INFO] [stderr] 155 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 156 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/um.rs:235:28 [INFO] [stderr] | [INFO] [stderr] 235 | self.regs[a] = try!(self.zero.get(self.regs[c] as usize).ok_or(UmError::InvalidArrayAccess)).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 235 | self.regs[a] = *(match $ expr { [INFO] [stderr] 236 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 237 | :: Err ( err ) => { [INFO] [stderr] 238 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 239 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/um.rs:239:28 [INFO] [stderr] | [INFO] [stderr] 239 | self.regs[a] = try!(self.arrays [INFO] [stderr] | ____________________________^ [INFO] [stderr] 240 | | .get(&self.regs[b]) [INFO] [stderr] 241 | | .and_then(|x| x.get(self.regs[c] as usize)) [INFO] [stderr] 242 | | .ok_or(UmError::InvalidArrayAccess)).clone(); [INFO] [stderr] | |________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 239 | self.regs[a] = *(match $ expr { [INFO] [stderr] 240 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 241 | :: Err ( err ) => { [INFO] [stderr] 242 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 243 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/um.rs:351:16 [INFO] [stderr] | [INFO] [stderr] 351 | if let Ok(_) = io::stdin().read_exact(&mut buf) [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 352 | | { [INFO] [stderr] 353 | | self.regs[c] = buf[0] as u32; [INFO] [stderr] 354 | | } [INFO] [stderr] | |_________- help: try this: `if io::stdin().read_exact(&mut buf).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/um.rs:353:28 [INFO] [stderr] | [INFO] [stderr] 353 | self.regs[c] = buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | platter = buf[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | platter |= (buf[2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | platter |= (buf[1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | platter |= (buf[0] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | let progname = args.next().unwrap_or(String::from("um")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("um"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/um.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | const OP_FUNCTION_TABLE: [&'static Fn(&mut Um, usize, usize, usize, u32) -> UmResult; 14] = [INFO] [stderr] | -^^^^^^^-------------------------------------------------------- help: consider removing `'static`: `&Fn(&mut Um, usize, usize, usize, u32) -> UmResult` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/um.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | const OP_STRING_TABLE: [&'static str; 14] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:156:35 [INFO] [stderr] | [INFO] [stderr] 156 | let opcode = ((operator & 0xF0000000) >> 28) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:191:43 [INFO] [stderr] | [INFO] [stderr] 191 | let opcode = ((operator & 0xF0000000) >> 28) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:298:56 [INFO] [stderr] | [INFO] [stderr] 298 | self.regs[a] = (self.regs[b] & self.regs[c]) ^ 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:375:29 [INFO] [stderr] | [INFO] [stderr] 375 | self.regs[((instr & 0x0E000000) >> 25) as usize] = instr & 0x01FFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0E00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/um.rs:375:68 [INFO] [stderr] | [INFO] [stderr] 375 | self.regs[((instr & 0x0E000000) >> 25) as usize] = instr & 0x01FFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/um.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | const OP_FUNCTION_TABLE: [&'static Fn(&mut Um, usize, usize, usize, u32) -> UmResult; 14] = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/um.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | let operator = try!(self.zero [INFO] [stderr] | ________________________^ [INFO] [stderr] 153 | | .get(self.execution_finger) [INFO] [stderr] 154 | | .ok_or(UmError::ExecutionFingerOutOfBounds)) [INFO] [stderr] 155 | | .clone(); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 152 | let operator = *(match $ expr { [INFO] [stderr] 153 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 154 | :: Err ( err ) => { [INFO] [stderr] 155 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 156 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/um.rs:235:28 [INFO] [stderr] | [INFO] [stderr] 235 | self.regs[a] = try!(self.zero.get(self.regs[c] as usize).ok_or(UmError::InvalidArrayAccess)).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 235 | self.regs[a] = *(match $ expr { [INFO] [stderr] 236 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 237 | :: Err ( err ) => { [INFO] [stderr] 238 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 239 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/um.rs:239:28 [INFO] [stderr] | [INFO] [stderr] 239 | self.regs[a] = try!(self.arrays [INFO] [stderr] | ____________________________^ [INFO] [stderr] 240 | | .get(&self.regs[b]) [INFO] [stderr] 241 | | .and_then(|x| x.get(self.regs[c] as usize)) [INFO] [stderr] 242 | | .ok_or(UmError::InvalidArrayAccess)).clone(); [INFO] [stderr] | |________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 239 | self.regs[a] = *(match $ expr { [INFO] [stderr] 240 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 241 | :: Err ( err ) => { [INFO] [stderr] 242 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 243 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/um.rs:351:16 [INFO] [stderr] | [INFO] [stderr] 351 | if let Ok(_) = io::stdin().read_exact(&mut buf) [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 352 | | { [INFO] [stderr] 353 | | self.regs[c] = buf[0] as u32; [INFO] [stderr] 354 | | } [INFO] [stderr] | |_________- help: try this: `if io::stdin().read_exact(&mut buf).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/um.rs:353:28 [INFO] [stderr] | [INFO] [stderr] 353 | self.regs[c] = buf[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | platter = buf[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | platter |= (buf[2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | platter |= (buf[1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | platter |= (buf[0] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | let progname = args.next().unwrap_or(String::from("um")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("um"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "7d1033729474a784d618dc594a483b2161819d61922915bc229517cbecac6ddd"` [INFO] running `"docker" "rm" "-f" "7d1033729474a784d618dc594a483b2161819d61922915bc229517cbecac6ddd"` [INFO] [stdout] 7d1033729474a784d618dc594a483b2161819d61922915bc229517cbecac6ddd