[INFO] updating cached repository Isaac-Lozano/i3status-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Isaac-Lozano/i3status-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Isaac-Lozano/i3status-rs" "work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/i3status-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/i3status-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Isaac-Lozano/i3status-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isaac-Lozano/i3status-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isaac-Lozano/i3status-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f59eb3f9d04f09b3298cf26b7628e8362e8b418e [INFO] sha for GitHub repo Isaac-Lozano/i3status-rs: f59eb3f9d04f09b3298cf26b7628e8362e8b418e [INFO] validating manifest of Isaac-Lozano/i3status-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Isaac-Lozano/i3status-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Isaac-Lozano/i3status-rs [INFO] finished frobbing Isaac-Lozano/i3status-rs [INFO] frobbed toml for Isaac-Lozano/i3status-rs written to work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/i3status-rs/Cargo.toml [INFO] started frobbing Isaac-Lozano/i3status-rs [INFO] finished frobbing Isaac-Lozano/i3status-rs [INFO] frobbed toml for Isaac-Lozano/i3status-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Isaac-Lozano/i3status-rs/Cargo.toml [INFO] crate Isaac-Lozano/i3status-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Isaac-Lozano/i3status-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Isaac-Lozano/i3status-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e26089005243756f9e827849fd42dd7c7c1650ea7aa2fe1501589b3ce44e99fa [INFO] running `"docker" "start" "-a" "e26089005243756f9e827849fd42dd7c7c1650ea7aa2fe1501589b3ce44e99fa"` [INFO] [stderr] Checking libc v0.2.8 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking i3status v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/time.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Time { format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/net_usage.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/net_usage.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/net_usage.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | full_text: full_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `full_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/time.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Time { format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/net_usage.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/net_usage.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/net_usage.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | full_text: full_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `full_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/block/net_usage.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | stats = Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/block/net_usage.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | stats = Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | } else if bytes < 1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | } else if bytes < 1000000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:154:46 [INFO] [stderr] | [INFO] [stderr] 154 | format!("{:.1} MB/s", bytes as f64 / 1000000.0) [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | format!("{:.1} GB/s", bytes as f64 / 1000000000.0) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/block/net_usage.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | stats = Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/block/net_usage.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | stats = Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | } else if bytes < 1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | } else if bytes < 1000000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:154:46 [INFO] [stderr] | [INFO] [stderr] 154 | format!("{:.1} MB/s", bytes as f64 / 1000000.0) [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block/net_usage.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | format!("{:.1} GB/s", bytes as f64 / 1000000000.0) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i3status::I3Status` [INFO] [stderr] --> src/i3status.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> I3Status { [INFO] [stderr] 63 | | print!("{{ \"version\": 1 }}["); [INFO] [stderr] 64 | | I3Status { [INFO] [stderr] 65 | | schedule: BinaryHeap::new(), [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(_) => Some(char::from_u32(buf[0] as u32).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/block/net_usage.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / let stats; [INFO] [stderr] 47 | | [INFO] [stderr] 48 | | if (*addr).ifa_data.is_null() { [INFO] [stderr] 49 | | stats = None; [INFO] [stderr] 50 | | } else { [INFO] [stderr] 51 | | stats = Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()); [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let stats = if (*addr).ifa_data.is_null() { None } else { Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/block/net_usage.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | let flags: u32 = (*addr).ifa_flags.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*addr).ifa_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `block::net_usage::NetUsage` [INFO] [stderr] --> src/block/net_usage.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> NetUsage { [INFO] [stderr] 107 | | NetUsage { [INFO] [stderr] 108 | | last_up: 0, [INFO] [stderr] 109 | | last_down: 0, [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/block/net_usage.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match addr.stats { [INFO] [stderr] 125 | | Some(rtnl) => { [INFO] [stderr] 126 | | cur_down += rtnl.rx_bytes as u64; [INFO] [stderr] 127 | | cur_up += rtnl.tx_bytes as u64; [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | None => {} [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(rtnl) = addr.stats { [INFO] [stderr] 125 | cur_down += rtnl.rx_bytes as u64; [INFO] [stderr] 126 | cur_up += rtnl.tx_bytes as u64; [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/block/net_usage.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | cur_down += rtnl.rx_bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rtnl.rx_bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/block/net_usage.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | cur_up += rtnl.tx_bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rtnl.tx_bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `i3status::I3Status` [INFO] [stderr] --> src/i3status.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> I3Status { [INFO] [stderr] 63 | | print!("{{ \"version\": 1 }}["); [INFO] [stderr] 64 | | I3Status { [INFO] [stderr] 65 | | schedule: BinaryHeap::new(), [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(_) => Some(char::from_u32(buf[0] as u32).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/block/net_usage.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / let stats; [INFO] [stderr] 47 | | [INFO] [stderr] 48 | | if (*addr).ifa_data.is_null() { [INFO] [stderr] 49 | | stats = None; [INFO] [stderr] 50 | | } else { [INFO] [stderr] 51 | | stats = Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()); [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let stats = if (*addr).ifa_data.is_null() { None } else { Some(ptr::read(((*addr).ifa_data as *const rtnl_link_stats)).clone()) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/block/net_usage.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | let flags: u32 = (*addr).ifa_flags.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*addr).ifa_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `block::net_usage::NetUsage` [INFO] [stderr] --> src/block/net_usage.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> NetUsage { [INFO] [stderr] 107 | | NetUsage { [INFO] [stderr] 108 | | last_up: 0, [INFO] [stderr] 109 | | last_down: 0, [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/block/net_usage.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match addr.stats { [INFO] [stderr] 125 | | Some(rtnl) => { [INFO] [stderr] 126 | | cur_down += rtnl.rx_bytes as u64; [INFO] [stderr] 127 | | cur_up += rtnl.tx_bytes as u64; [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | None => {} [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let Some(rtnl) = addr.stats { [INFO] [stderr] 125 | cur_down += rtnl.rx_bytes as u64; [INFO] [stderr] 126 | cur_up += rtnl.tx_bytes as u64; [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/block/net_usage.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | cur_down += rtnl.rx_bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rtnl.rx_bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/block/net_usage.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | cur_up += rtnl.tx_bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rtnl.tx_bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.40s [INFO] running `"docker" "inspect" "e26089005243756f9e827849fd42dd7c7c1650ea7aa2fe1501589b3ce44e99fa"` [INFO] running `"docker" "rm" "-f" "e26089005243756f9e827849fd42dd7c7c1650ea7aa2fe1501589b3ce44e99fa"` [INFO] [stdout] e26089005243756f9e827849fd42dd7c7c1650ea7aa2fe1501589b3ce44e99fa