[INFO] updating cached repository IsSuEat/chip8-interpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/IsSuEat/chip8-interpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/IsSuEat/chip8-interpreter" "work/ex/clippy-test-run/sources/stable/gh/IsSuEat/chip8-interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/IsSuEat/chip8-interpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/IsSuEat/chip8-interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IsSuEat/chip8-interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IsSuEat/chip8-interpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd1602cf20cdfc941c4d0ed5ecff6afa73b55bbe [INFO] sha for GitHub repo IsSuEat/chip8-interpreter: fd1602cf20cdfc941c4d0ed5ecff6afa73b55bbe [INFO] validating manifest of IsSuEat/chip8-interpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of IsSuEat/chip8-interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing IsSuEat/chip8-interpreter [INFO] finished frobbing IsSuEat/chip8-interpreter [INFO] frobbed toml for IsSuEat/chip8-interpreter written to work/ex/clippy-test-run/sources/stable/gh/IsSuEat/chip8-interpreter/Cargo.toml [INFO] started frobbing IsSuEat/chip8-interpreter [INFO] finished frobbing IsSuEat/chip8-interpreter [INFO] frobbed toml for IsSuEat/chip8-interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IsSuEat/chip8-interpreter/Cargo.toml [INFO] crate IsSuEat/chip8-interpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting IsSuEat/chip8-interpreter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/IsSuEat/chip8-interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c92240776190811c4b125037432808803aa94cbff87db2f7675e6250f6e218f2 [INFO] running `"docker" "start" "-a" "c92240776190811c4b125037432808803aa94cbff87db2f7675e6250f6e218f2"` [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return a | b; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `a | b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return a | b; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `a | b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `chip8::Chip8` [INFO] [stderr] --> src/chip8.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Chip8 { [INFO] [stderr] 16 | | Chip8 { [INFO] [stderr] 17 | | cpu: Cpu::default().init(), [INFO] [stderr] 18 | | window: WindowSettings::new("Chip 8 Interpreter", [640, 320]) [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for chip8::Chip8 { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chip8.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn load_rom(&mut self, path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | (x * size) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(x * size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | (y * size) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(y * size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:51:37 [INFO] [stderr] | [INFO] [stderr] 51 | size as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:52:37 [INFO] [stderr] | [INFO] [stderr] 52 | size as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let a = (self.mem[self.pc as usize] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[self.pc as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | let b = self.mem[self.pc as usize + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[self.pc as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cpu.rs:451:9 [INFO] [stderr] | [INFO] [stderr] 451 | / let mut most_significant = 0; [INFO] [stderr] 452 | | if vx >= 128 { [INFO] [stderr] 453 | | most_significant = 1; [INFO] [stderr] 454 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let most_significant = if vx >= 128 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:499:23 [INFO] [stderr] | [INFO] [stderr] 499 | let start_x = self.read_register(x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_register(x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:501:23 [INFO] [stderr] | [INFO] [stderr] 501 | let start_y = self.read_register(y) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_register(y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `chip8::Chip8` [INFO] [stderr] --> src/chip8.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Chip8 { [INFO] [stderr] 16 | | Chip8 { [INFO] [stderr] 17 | | cpu: Cpu::default().init(), [INFO] [stderr] 18 | | window: WindowSettings::new("Chip 8 Interpreter", [640, 320]) [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for chip8::Chip8 { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:561:50 [INFO] [stderr] | [INFO] [stderr] 561 | let content = self.read_mem(self.i + idx as u16); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:565:37 [INFO] [stderr] | [INFO] [stderr] 565 | self.set_index_register(i + end_register as u16 + 1u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(end_register)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:575:42 [INFO] [stderr] | [INFO] [stderr] 575 | let store_address = self.i + idx as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:579:37 [INFO] [stderr] | [INFO] [stderr] 579 | self.set_index_register(i + registerx as u16 + 1u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(registerx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:587:31 [INFO] [stderr] | [INFO] [stderr] 587 | let result = self.i + register_content as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(register_content)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chip8.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn load_rom(&mut self, path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | (x * size) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(x * size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | (y * size) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(y * size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:51:37 [INFO] [stderr] | [INFO] [stderr] 51 | size as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chip8.rs:52:37 [INFO] [stderr] | [INFO] [stderr] 52 | size as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let a = (self.mem[self.pc as usize] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[self.pc as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | let b = self.mem[self.pc as usize + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[self.pc as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cpu.rs:451:9 [INFO] [stderr] | [INFO] [stderr] 451 | / let mut most_significant = 0; [INFO] [stderr] 452 | | if vx >= 128 { [INFO] [stderr] 453 | | most_significant = 1; [INFO] [stderr] 454 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let most_significant = if vx >= 128 { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:499:23 [INFO] [stderr] | [INFO] [stderr] 499 | let start_x = self.read_register(x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_register(x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:501:23 [INFO] [stderr] | [INFO] [stderr] 501 | let start_y = self.read_register(y) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_register(y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:561:50 [INFO] [stderr] | [INFO] [stderr] 561 | let content = self.read_mem(self.i + idx as u16); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:565:37 [INFO] [stderr] | [INFO] [stderr] 565 | self.set_index_register(i + end_register as u16 + 1u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(end_register)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:575:42 [INFO] [stderr] | [INFO] [stderr] 575 | let store_address = self.i + idx as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:579:37 [INFO] [stderr] | [INFO] [stderr] 579 | self.set_index_register(i + registerx as u16 + 1u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(registerx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:587:31 [INFO] [stderr] | [INFO] [stderr] 587 | let result = self.i + register_content as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(register_content)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / let mut rom_path = &String::from("roms/pong.ch8"); [INFO] [stderr] 13 | | if args.len() == 2 { [INFO] [stderr] 14 | | rom_path = &args[1]; [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let rom_path = if args.len() == 2 { &args[1] } else { &String::from("roms/pong.ch8") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / let mut rom_path = &String::from("roms/pong.ch8"); [INFO] [stderr] 13 | | if args.len() == 2 { [INFO] [stderr] 14 | | rom_path = &args[1]; [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let rom_path = if args.len() == 2 { &args[1] } else { &String::from("roms/pong.ch8") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "c92240776190811c4b125037432808803aa94cbff87db2f7675e6250f6e218f2"` [INFO] running `"docker" "rm" "-f" "c92240776190811c4b125037432808803aa94cbff87db2f7675e6250f6e218f2"` [INFO] [stdout] c92240776190811c4b125037432808803aa94cbff87db2f7675e6250f6e218f2