[INFO] updating cached repository Immortalin/NFS_Comptroller [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Immortalin/NFS_Comptroller [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Immortalin/NFS_Comptroller" "work/ex/clippy-test-run/sources/stable/gh/Immortalin/NFS_Comptroller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Immortalin/NFS_Comptroller'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Immortalin/NFS_Comptroller" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Immortalin/NFS_Comptroller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Immortalin/NFS_Comptroller'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b7393d6bfb317e3861fb97b1cc316f49d4a82b8 [INFO] sha for GitHub repo Immortalin/NFS_Comptroller: 9b7393d6bfb317e3861fb97b1cc316f49d4a82b8 [INFO] validating manifest of Immortalin/NFS_Comptroller on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Immortalin/NFS_Comptroller on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Immortalin/NFS_Comptroller [INFO] finished frobbing Immortalin/NFS_Comptroller [INFO] frobbed toml for Immortalin/NFS_Comptroller written to work/ex/clippy-test-run/sources/stable/gh/Immortalin/NFS_Comptroller/Cargo.toml [INFO] started frobbing Immortalin/NFS_Comptroller [INFO] finished frobbing Immortalin/NFS_Comptroller [INFO] frobbed toml for Immortalin/NFS_Comptroller written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Immortalin/NFS_Comptroller/Cargo.toml [INFO] crate Immortalin/NFS_Comptroller has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Immortalin/NFS_Comptroller against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Immortalin/NFS_Comptroller:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a386c390ceff9f7d59a61648c57d0b4d3645b2260d08ba688266bb163c663ab3 [INFO] running `"docker" "start" "-a" "a386c390ceff9f7d59a61648c57d0b4d3645b2260d08ba688266bb163c663ab3"` [INFO] [stderr] Checking tokio-signal v0.2.6 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking actix v0.7.6 [INFO] [stderr] Checking actix-net v0.2.3 [INFO] [stderr] Checking actix-web v0.7.14 [INFO] [stderr] Checking nfs_comptroller v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / return ( [INFO] [stderr] 51 | | s[..found.start()].to_string(), [INFO] [stderr] 52 | | // range removes opening & closing parens [INFO] [stderr] 53 | | Some(result[1..last_char].to_string()), [INFO] [stderr] 54 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | ( [INFO] [stderr] 51 | s[..found.start()].to_string(), [INFO] [stderr] 52 | // range removes opening & closing parens [INFO] [stderr] 53 | Some(result[1..last_char].to_string()), [INFO] [stderr] 54 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / return ( [INFO] [stderr] 51 | | s[..found.start()].to_string(), [INFO] [stderr] 52 | | // range removes opening & closing parens [INFO] [stderr] 53 | | Some(result[1..last_char].to_string()), [INFO] [stderr] 54 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | ( [INFO] [stderr] 51 | s[..found.start()].to_string(), [INFO] [stderr] 52 | // range removes opening & closing parens [INFO] [stderr] 53 | Some(result[1..last_char].to_string()), [INFO] [stderr] 54 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | .filter(|s| s.trim().chars().next().unwrap() != '#') // ignores comments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!s.trim().starts_with('#')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | if last.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | .filter(|s| s.trim().chars().next().unwrap() != '#') // ignores comments [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!s.trim().starts_with('#')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | if last.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.41s [INFO] running `"docker" "inspect" "a386c390ceff9f7d59a61648c57d0b4d3645b2260d08ba688266bb163c663ab3"` [INFO] running `"docker" "rm" "-f" "a386c390ceff9f7d59a61648c57d0b4d3645b2260d08ba688266bb163c663ab3"` [INFO] [stdout] a386c390ceff9f7d59a61648c57d0b4d3645b2260d08ba688266bb163c663ab3