[INFO] updating cached repository Illthiriel/ecosys [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Illthiriel/ecosys [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Illthiriel/ecosys" "work/ex/clippy-test-run/sources/stable/gh/Illthiriel/ecosys"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Illthiriel/ecosys'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Illthiriel/ecosys" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Illthiriel/ecosys"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Illthiriel/ecosys'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d89b799186306c5ac1cc21a241ff51fe46b9bab [INFO] sha for GitHub repo Illthiriel/ecosys: 1d89b799186306c5ac1cc21a241ff51fe46b9bab [INFO] validating manifest of Illthiriel/ecosys on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Illthiriel/ecosys on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Illthiriel/ecosys [INFO] finished frobbing Illthiriel/ecosys [INFO] frobbed toml for Illthiriel/ecosys written to work/ex/clippy-test-run/sources/stable/gh/Illthiriel/ecosys/Cargo.toml [INFO] started frobbing Illthiriel/ecosys [INFO] finished frobbing Illthiriel/ecosys [INFO] frobbed toml for Illthiriel/ecosys written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Illthiriel/ecosys/Cargo.toml [INFO] crate Illthiriel/ecosys has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Illthiriel/ecosys against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Illthiriel/ecosys:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1b72636f0945837f3985596a5ffa696bb2316bfab5bd1a1d7d0dc49d1f08f30 [INFO] running `"docker" "start" "-a" "f1b72636f0945837f3985596a5ffa696bb2316bfab5bd1a1d7d0dc49d1f08f30"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/bench.rs` was erroneously implicitly accepted for benchmark `bench`, [INFO] [stderr] please set bench.path in Cargo.toml [INFO] [stderr] Checking option-filter v1.0.1 [INFO] [stderr] Checking bencher v0.1.2 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking shared_library v0.1.6 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.8.1 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Checking gfx_core v0.7.1 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking gfx_device_gl v0.14.1 [INFO] [stderr] Checking gfx v0.16.0 [INFO] [stderr] Checking gfx_window_glutin v0.16.0 [INFO] [stderr] Checking ecosys v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/renderer/console.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | write!(f, "Iteration : {}\n", self.tick_count())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/renderer/console.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/renderer/console.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/renderer/console.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | write!(f, "Iteration : {}\n", self.tick_count())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/renderer/console.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/renderer/console.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/world.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | / if !self.is_being_at(position) { [INFO] [stderr] 64 | | if between.ind_sample(&mut self.rng) < self.space.spawn_probability_at(position) { [INFO] [stderr] 65 | | let new_being = Being::new(position); [INFO] [stderr] 66 | | self.beings.push(new_being); [INFO] [stderr] 67 | | self.positions_take_up.insert(position); [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | if !self.is_being_at(position) && between.ind_sample(&mut self.rng) < self.space.spawn_probability_at(position) { [INFO] [stderr] 64 | let new_being = Being::new(position); [INFO] [stderr] 65 | self.beings.push(new_being); [INFO] [stderr] 66 | self.positions_take_up.insert(position); [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `option_filter::OptionFilterExt` [INFO] [stderr] --> src/world.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use option_filter::OptionFilterExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tick_count` [INFO] [stderr] --> src/world.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn tick_count(&self) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `beings` [INFO] [stderr] --> src/world.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn beings(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `space` [INFO] [stderr] --> src/world.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn space(&self) -> &Space { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `energy` [INFO] [stderr] --> src/being/mod.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn energy(&self) -> u32 { self.energy } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/world.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | self.one_free_biome_around(position) [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 142 | || .map(|new_position| { [INFO] [stderr] 143 | || let new_being = (&mut self.beings[being_idx]).split(new_position); [INFO] [stderr] 144 | || self.beings.push(new_being.clone()); [INFO] [stderr] 145 | || self.positions_take_up.insert(new_position); [INFO] [stderr] 146 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(new_position) = self.one_free_biome_around(position) { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | .or(position.south_east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south_east(max))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:166:14 [INFO] [stderr] | [INFO] [stderr] 166 | .or(position.south(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | .or(position.south_west(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south_west(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | .or(position.east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.east(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:160:14 [INFO] [stderr] | [INFO] [stderr] 160 | .or(position.west()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.west())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | .or(position.north_east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.north_east(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:156:14 [INFO] [stderr] | [INFO] [stderr] 156 | .or(position.north()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.north())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/space/mod.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | self.current = self.current + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/being/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.energy = self.energy / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.energy /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/being/mod.rs:64:34 [INFO] [stderr] | [INFO] [stderr] 64 | let between = Range::new(0 as f64, 100 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/being/mod.rs:64:44 [INFO] [stderr] | [INFO] [stderr] 64 | let between = Range::new(0 as f64, 100 as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/being/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | self.energy <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.energy == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/being/mod.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | self.actions.get(self.action_counter).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.actions[self.action_counter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/being/mod.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | self.energy = self.energy - energy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.energy -= energy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/bench.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | benchmark_main!(benches); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ecosys`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/world.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | / if !self.is_being_at(position) { [INFO] [stderr] 64 | | if between.ind_sample(&mut self.rng) < self.space.spawn_probability_at(position) { [INFO] [stderr] 65 | | let new_being = Being::new(position); [INFO] [stderr] 66 | | self.beings.push(new_being); [INFO] [stderr] 67 | | self.positions_take_up.insert(position); [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | if !self.is_being_at(position) && between.ind_sample(&mut self.rng) < self.space.spawn_probability_at(position) { [INFO] [stderr] 64 | let new_being = Being::new(position); [INFO] [stderr] 65 | self.beings.push(new_being); [INFO] [stderr] 66 | self.positions_take_up.insert(position); [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_window_glutin` [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use gfx_window_glutin; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:108:65 [INFO] [stderr] | [INFO] [stderr] 108 | events_loop.poll_events(|glutin::Event::WindowEvent{window_id: _, event}| { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `WindowEvent { event, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/world.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | / if !self.is_being_at(position) { [INFO] [stderr] 64 | | if between.ind_sample(&mut self.rng) < self.space.spawn_probability_at(position) { [INFO] [stderr] 65 | | let new_being = Being::new(position); [INFO] [stderr] 66 | | self.beings.push(new_being); [INFO] [stderr] 67 | | self.positions_take_up.insert(position); [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | if !self.is_being_at(position) && between.ind_sample(&mut self.rng) < self.space.spawn_probability_at(position) { [INFO] [stderr] 64 | let new_being = Being::new(position); [INFO] [stderr] 65 | self.beings.push(new_being); [INFO] [stderr] 66 | self.positions_take_up.insert(position); [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx_window_glutin` [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use gfx_window_glutin; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:108:65 [INFO] [stderr] | [INFO] [stderr] 108 | events_loop.poll_events(|glutin::Event::WindowEvent{window_id: _, event}| { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `WindowEvent { event, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `option_filter::OptionFilterExt` [INFO] [stderr] --> src/world.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use option_filter::OptionFilterExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `receiver` [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | fn run(receiver: Receiver) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_receiver` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `option_filter::OptionFilterExt` [INFO] [stderr] --> src/world.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use option_filter::OptionFilterExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | let (window, mut device, mut factory, mut main_color, mut main_depth) = [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `receiver` [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | fn run(receiver: Receiver) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_receiver` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INDICES` [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | const INDICES: &[u16] = &[0, 1, 2, 2, 3, 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | let (window, mut device, mut factory, mut main_color, mut main_depth) = [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/world.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | self.one_free_biome_around(position) [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 142 | || .map(|new_position| { [INFO] [stderr] 143 | || let new_being = (&mut self.beings[being_idx]).split(new_position); [INFO] [stderr] 144 | || self.beings.push(new_being.clone()); [INFO] [stderr] 145 | || self.positions_take_up.insert(new_position); [INFO] [stderr] 146 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(new_position) = self.one_free_biome_around(position) { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | .or(position.south_east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south_east(max))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:166:14 [INFO] [stderr] | [INFO] [stderr] 166 | .or(position.south(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | .or(position.south_west(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south_west(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | .or(position.east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.east(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:160:14 [INFO] [stderr] | [INFO] [stderr] 160 | .or(position.west()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.west())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | .or(position.north_east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.north_east(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:156:14 [INFO] [stderr] | [INFO] [stderr] 156 | .or(position.north()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.north())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/space/mod.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | self.current = self.current + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/being/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.energy = self.energy / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.energy /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/being/mod.rs:64:34 [INFO] [stderr] | [INFO] [stderr] 64 | let between = Range::new(0 as f64, 100 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/being/mod.rs:64:44 [INFO] [stderr] | [INFO] [stderr] 64 | let between = Range::new(0 as f64, 100 as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/being/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | self.energy <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.energy == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/being/mod.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | self.actions.get(self.action_counter).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.actions[self.action_counter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/being/mod.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | self.energy = self.energy - energy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.energy -= energy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INDICES` [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | const INDICES: &[u16] = &[0, 1, 2, 2, 3, 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/world.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | self.one_free_biome_around(position) [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 142 | || .map(|new_position| { [INFO] [stderr] 143 | || let new_being = (&mut self.beings[being_idx]).split(new_position); [INFO] [stderr] 144 | || self.beings.push(new_being.clone()); [INFO] [stderr] 145 | || self.positions_take_up.insert(new_position); [INFO] [stderr] 146 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(new_position) = self.one_free_biome_around(position) { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | .or(position.south_east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south_east(max))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:166:14 [INFO] [stderr] | [INFO] [stderr] 166 | .or(position.south(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | .or(position.south_west(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.south_west(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | .or(position.east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.east(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:160:14 [INFO] [stderr] | [INFO] [stderr] 160 | .or(position.west()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.west())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | .or(position.north_east(max)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.north_east(max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/world.rs:156:14 [INFO] [stderr] | [INFO] [stderr] 156 | .or(position.north()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| position.north())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/space/mod.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | self.current = self.current + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/being/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.energy = self.energy / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.energy /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/being/mod.rs:64:34 [INFO] [stderr] | [INFO] [stderr] 64 | let between = Range::new(0 as f64, 100 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/being/mod.rs:64:44 [INFO] [stderr] | [INFO] [stderr] 64 | let between = Range::new(0 as f64, 100 as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/being/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | self.energy <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.energy == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/being/mod.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | self.actions.get(self.action_counter).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.actions[self.action_counter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/being/mod.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | self.energy = self.energy - energy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.energy -= energy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | self.sender.as_ref().map(|s| s.send(world.tick_count() as i32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.sender.as_ref() { s.send(world.tick_count() as i32).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ecosys`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/renderer/with_gfx/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | self.sender.as_ref().map(|s| s.send(world.tick_count() as i32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.sender.as_ref() { s.send(world.tick_count() as i32).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ecosys`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f1b72636f0945837f3985596a5ffa696bb2316bfab5bd1a1d7d0dc49d1f08f30"` [INFO] running `"docker" "rm" "-f" "f1b72636f0945837f3985596a5ffa696bb2316bfab5bd1a1d7d0dc49d1f08f30"` [INFO] [stdout] f1b72636f0945837f3985596a5ffa696bb2316bfab5bd1a1d7d0dc49d1f08f30