[INFO] updating cached repository Ikatyan/WavToFlacConverter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ikatyan/WavToFlacConverter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ikatyan/WavToFlacConverter" "work/ex/clippy-test-run/sources/stable/gh/Ikatyan/WavToFlacConverter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ikatyan/WavToFlacConverter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ikatyan/WavToFlacConverter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ikatyan/WavToFlacConverter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ikatyan/WavToFlacConverter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f46567e86753b8c11d60f72af554333003e4ffc [INFO] sha for GitHub repo Ikatyan/WavToFlacConverter: 0f46567e86753b8c11d60f72af554333003e4ffc [INFO] validating manifest of Ikatyan/WavToFlacConverter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ikatyan/WavToFlacConverter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ikatyan/WavToFlacConverter [INFO] finished frobbing Ikatyan/WavToFlacConverter [INFO] frobbed toml for Ikatyan/WavToFlacConverter written to work/ex/clippy-test-run/sources/stable/gh/Ikatyan/WavToFlacConverter/Cargo.toml [INFO] started frobbing Ikatyan/WavToFlacConverter [INFO] finished frobbing Ikatyan/WavToFlacConverter [INFO] frobbed toml for Ikatyan/WavToFlacConverter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ikatyan/WavToFlacConverter/Cargo.toml [INFO] crate Ikatyan/WavToFlacConverter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ikatyan/WavToFlacConverter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ikatyan/WavToFlacConverter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c06901a9c6b042b5e088c2086804e356069c08e3c7c4d67af4c6ebce4a406ad5 [INFO] running `"docker" "start" "-a" "c06901a9c6b042b5e088c2086804e356069c08e3c7c4d67af4c6ebce4a406ad5"` [INFO] [stderr] Checking Tools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `Tools` should have a snake case name such as `tools` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/wtof.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Some(wav_files) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(wav_files)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/wtof.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | fn convert_wav_to_flac(wav_files: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: crate `Tools` should have a snake case name such as `tools` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/wtof.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Some(wav_files) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(wav_files)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/wtof.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | fn convert_wav_to_flac(wav_files: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.81s [INFO] running `"docker" "inspect" "c06901a9c6b042b5e088c2086804e356069c08e3c7c4d67af4c6ebce4a406ad5"` [INFO] running `"docker" "rm" "-f" "c06901a9c6b042b5e088c2086804e356069c08e3c7c4d67af4c6ebce4a406ad5"` [INFO] [stdout] c06901a9c6b042b5e088c2086804e356069c08e3c7c4d67af4c6ebce4a406ad5