[INFO] updating cached repository Idolf/date-stuff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Idolf/date-stuff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Idolf/date-stuff" "work/ex/clippy-test-run/sources/stable/gh/Idolf/date-stuff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Idolf/date-stuff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Idolf/date-stuff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Idolf/date-stuff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Idolf/date-stuff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cda735fe5f472790516615231d000a4836ae692b [INFO] sha for GitHub repo Idolf/date-stuff: cda735fe5f472790516615231d000a4836ae692b [INFO] validating manifest of Idolf/date-stuff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Idolf/date-stuff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Idolf/date-stuff [INFO] finished frobbing Idolf/date-stuff [INFO] frobbed toml for Idolf/date-stuff written to work/ex/clippy-test-run/sources/stable/gh/Idolf/date-stuff/Cargo.toml [INFO] started frobbing Idolf/date-stuff [INFO] finished frobbing Idolf/date-stuff [INFO] frobbed toml for Idolf/date-stuff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Idolf/date-stuff/Cargo.toml [INFO] crate Idolf/date-stuff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Idolf/date-stuff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Idolf/date-stuff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e8a10bdb4d5081a6de2756a075d9133680858b74c7cee4359420c768bb6b945 [INFO] running `"docker" "start" "-a" "0e8a10bdb4d5081a6de2756a075d9133680858b74c7cee4359420c768bb6b945"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking date-stuff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:193:48 [INFO] [stderr] | [INFO] [stderr] 193 | match env::var(var).map(|s| s.parse()).unwrap_or(Ok(def)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Ok(def))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | / match c { [INFO] [stderr] 264 | | &[ref m0] => { [INFO] [stderr] 265 | | for l0 in m0.iter() { [INFO] [stderr] 266 | | if !l0.trim().is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 285 | | _ => unreachable!(), [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 263 | match *c { [INFO] [stderr] 264 | [ref m0] => { [INFO] [stderr] 265 | for l0 in m0.iter() { [INFO] [stderr] 266 | if !l0.trim().is_empty() { [INFO] [stderr] 267 | println!("{}", l0); [INFO] [stderr] 268 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:193:48 [INFO] [stderr] | [INFO] [stderr] 193 | match env::var(var).map(|s| s.parse()).unwrap_or(Ok(def)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Ok(def))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | / match c { [INFO] [stderr] 264 | | &[ref m0] => { [INFO] [stderr] 265 | | for l0 in m0.iter() { [INFO] [stderr] 266 | | if !l0.trim().is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 285 | | _ => unreachable!(), [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 263 | match *c { [INFO] [stderr] 264 | [ref m0] => { [INFO] [stderr] 265 | for l0 in m0.iter() { [INFO] [stderr] 266 | if !l0.trim().is_empty() { [INFO] [stderr] 267 | println!("{}", l0); [INFO] [stderr] 268 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.72s [INFO] running `"docker" "inspect" "0e8a10bdb4d5081a6de2756a075d9133680858b74c7cee4359420c768bb6b945"` [INFO] running `"docker" "rm" "-f" "0e8a10bdb4d5081a6de2756a075d9133680858b74c7cee4359420c768bb6b945"` [INFO] [stdout] 0e8a10bdb4d5081a6de2756a075d9133680858b74c7cee4359420c768bb6b945