[INFO] updating cached repository IEavan/Connect4-Monte-Carlo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/IEavan/Connect4-Monte-Carlo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/IEavan/Connect4-Monte-Carlo" "work/ex/clippy-test-run/sources/stable/gh/IEavan/Connect4-Monte-Carlo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/IEavan/Connect4-Monte-Carlo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/IEavan/Connect4-Monte-Carlo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IEavan/Connect4-Monte-Carlo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IEavan/Connect4-Monte-Carlo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1e120a2b3992e4f68973aa338398c220e7a0bde8 [INFO] sha for GitHub repo IEavan/Connect4-Monte-Carlo: 1e120a2b3992e4f68973aa338398c220e7a0bde8 [INFO] validating manifest of IEavan/Connect4-Monte-Carlo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of IEavan/Connect4-Monte-Carlo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing IEavan/Connect4-Monte-Carlo [INFO] finished frobbing IEavan/Connect4-Monte-Carlo [INFO] frobbed toml for IEavan/Connect4-Monte-Carlo written to work/ex/clippy-test-run/sources/stable/gh/IEavan/Connect4-Monte-Carlo/Cargo.toml [INFO] started frobbing IEavan/Connect4-Monte-Carlo [INFO] finished frobbing IEavan/Connect4-Monte-Carlo [INFO] frobbed toml for IEavan/Connect4-Monte-Carlo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IEavan/Connect4-Monte-Carlo/Cargo.toml [INFO] crate IEavan/Connect4-Monte-Carlo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting IEavan/Connect4-Monte-Carlo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/IEavan/Connect4-Monte-Carlo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2ada2df2bb9f48ba4c4662f44fafd4bcce97ab425f5c683e7b8eaeaec0f406e [INFO] running `"docker" "start" "-a" "d2ada2df2bb9f48ba4c4662f44fafd4bcce97ab425f5c683e7b8eaeaec0f406e"` [INFO] [stderr] Checking connect4 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | move_list.push(GameMove {previous: previous, next: next}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `previous` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:45:62 [INFO] [stderr] | [INFO] [stderr] 45 | move_list.push(GameMove {previous: previous, next: next}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | move_list.push(GameMove {previous: previous, next: next}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `previous` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:45:62 [INFO] [stderr] | [INFO] [stderr] 45 | move_list.push(GameMove {previous: previous, next: next}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return GridState {grid: empty_grid, turn: Player::Yellow, winner: None}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GridState {grid: empty_grid, turn: Player::Yellow, winner: None}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | if new_column - i - 1 >= 0 && new_column - i - 1 < 9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 94 | if new_column - i > 0 && new_column - i - 1 < 9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:115:16 [INFO] [stderr] | [INFO] [stderr] 115 | if new_row - i - 1 >= 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 115 | if new_row - i > 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | new_row - i - 1 >= 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 128 | new_row - i > 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | if new_column - i - 1 >= 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 137 | if new_column - i > 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | if new_column - i - 1 >= 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 160 | if new_column - i > 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | new_row - i - 1 >= 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 161 | new_row - i > 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return GridState {grid: empty_grid, turn: Player::Yellow, winner: None}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GridState {grid: empty_grid, turn: Player::Yellow, winner: None}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | if new_column - i - 1 >= 0 && new_column - i - 1 < 9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 94 | if new_column - i > 0 && new_column - i - 1 < 9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:115:16 [INFO] [stderr] | [INFO] [stderr] 115 | if new_row - i - 1 >= 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 115 | if new_row - i > 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | new_row - i - 1 >= 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 128 | new_row - i > 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | if new_column - i - 1 >= 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 137 | if new_column - i > 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | if new_column - i - 1 >= 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 160 | if new_column - i > 0 && new_column - i - 1 < 9 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/grid.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | new_row - i - 1 >= 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 161 | new_row - i > 0 && new_row - i - 1 < 6 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/grid.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | if let Ok(_) = next.insert(i) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 45 | | move_list.push(GameMove {previous: previous, next: next}); [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_____________- help: try this: `if next.insert(i).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/grid.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | if let Some(_) = self.grid[0][column] {return Err("Column is full");} [INFO] [stderr] | -------^^^^^^^------------------------------------------------------- help: try this: `if self.grid[0][column].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/grid.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(_) = self.winner {return Err("Game is over");} [INFO] [stderr] | -------^^^^^^^-------------------------------------------- help: try this: `if self.winner.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/grid.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | if let Some(_) = self.grid[j][column] {continue;} [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 58 | | else { [INFO] [stderr] 59 | | free_position = j; [INFO] [stderr] 60 | | break; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________- help: try this: `if self.grid[j][column].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/grid.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / fn check_winner(&self, new_row: i32, new_column: i32) -> bool { [INFO] [stderr] 79 | | //TODO: Candidate for macros [INFO] [stderr] 80 | | let last_player = self.turn; [INFO] [stderr] 81 | | [INFO] [stderr] ... | [INFO] [stderr] 171 | | row_count >= 3 || vert_count >= 3 || rising_count >= 3 || falling_count >= 3 [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/grid.rs:287:22 [INFO] [stderr] | [INFO] [stderr] 287 | for j in 0..9 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `new_grid.grid[i][..9].clone_from_slice(&self.grid[i][..9])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mcts.rs:14:8 [INFO] [stderr] | [INFO] [stderr] 14 | if move_list.len() == 0 {panic!("No moves to select best from");} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `move_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mcts.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if moves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `moves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/grid.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | if let Ok(_) = next.insert(i) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 45 | | move_list.push(GameMove {previous: previous, next: next}); [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_____________- help: try this: `if next.insert(i).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/grid.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | if let Some(_) = self.grid[0][column] {return Err("Column is full");} [INFO] [stderr] | -------^^^^^^^------------------------------------------------------- help: try this: `if self.grid[0][column].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/grid.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(_) = self.winner {return Err("Game is over");} [INFO] [stderr] | -------^^^^^^^-------------------------------------------- help: try this: `if self.winner.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/grid.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | if let Some(_) = self.grid[j][column] {continue;} [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 58 | | else { [INFO] [stderr] 59 | | free_position = j; [INFO] [stderr] 60 | | break; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________- help: try this: `if self.grid[j][column].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/grid.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / fn check_winner(&self, new_row: i32, new_column: i32) -> bool { [INFO] [stderr] 79 | | //TODO: Candidate for macros [INFO] [stderr] 80 | | let last_player = self.turn; [INFO] [stderr] 81 | | [INFO] [stderr] ... | [INFO] [stderr] 171 | | row_count >= 3 || vert_count >= 3 || rising_count >= 3 || falling_count >= 3 [INFO] [stderr] 172 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/grid.rs:287:22 [INFO] [stderr] | [INFO] [stderr] 287 | for j in 0..9 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `new_grid.grid[i][..9].clone_from_slice(&self.grid[i][..9])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mcts.rs:14:8 [INFO] [stderr] | [INFO] [stderr] 14 | if move_list.len() == 0 {panic!("No moves to select best from");} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `move_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mcts.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if moves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `moves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.08s [INFO] running `"docker" "inspect" "d2ada2df2bb9f48ba4c4662f44fafd4bcce97ab425f5c683e7b8eaeaec0f406e"` [INFO] running `"docker" "rm" "-f" "d2ada2df2bb9f48ba4c4662f44fafd4bcce97ab425f5c683e7b8eaeaec0f406e"` [INFO] [stdout] d2ada2df2bb9f48ba4c4662f44fafd4bcce97ab425f5c683e7b8eaeaec0f406e