[INFO] updating cached repository HustonMmmavr/async_server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HustonMmmavr/async_server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HustonMmmavr/async_server" "work/ex/clippy-test-run/sources/stable/gh/HustonMmmavr/async_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HustonMmmavr/async_server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HustonMmmavr/async_server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HustonMmmavr/async_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HustonMmmavr/async_server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d44e62684ea55360257bfbc4545735869d448d6 [INFO] sha for GitHub repo HustonMmmavr/async_server: 0d44e62684ea55360257bfbc4545735869d448d6 [INFO] validating manifest of HustonMmmavr/async_server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HustonMmmavr/async_server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HustonMmmavr/async_server [INFO] finished frobbing HustonMmmavr/async_server [INFO] frobbed toml for HustonMmmavr/async_server written to work/ex/clippy-test-run/sources/stable/gh/HustonMmmavr/async_server/Cargo.toml [INFO] started frobbing HustonMmmavr/async_server [INFO] finished frobbing HustonMmmavr/async_server [INFO] frobbed toml for HustonMmmavr/async_server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HustonMmmavr/async_server/Cargo.toml [INFO] crate HustonMmmavr/async_server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HustonMmmavr/async_server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HustonMmmavr/async_server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 991425da9cb958bc86fc63ff97b049955406a4a99e03bdb46d0310d4fb0e8a4c [INFO] running `"docker" "start" "-a" "991425da9cb958bc86fc63ff97b049955406a4a99e03bdb46d0310d4fb0e8a4c"` [INFO] [stderr] Checking async_server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/client.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | interest: interest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/client.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | interest: interest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod server; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/server/server.rs:2:29 [INFO] [stderr] | [INFO] [stderr] 2 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ClientState` [INFO] [stderr] --> src/server/server.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | use client::client::{HttpClient, ClientState}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `thread_pool::thread_pool::ThreadPool` [INFO] [stderr] --> src/server/server.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use thread_pool::thread_pool::ThreadPool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::os::unix::io::RawFd` [INFO] [stderr] --> src/server/server.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::os::unix::io::RawFd; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread::JoinHandle` [INFO] [stderr] --> src/server/server.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::thread::JoinHandle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/client/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod client; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Events`, `PollOpt`, `Poll` [INFO] [stderr] --> src/client/client.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | use mio::{Events, Poll, Ready, PollOpt, Token}; [INFO] [stderr] | ^^^^^^ ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpListener` [INFO] [stderr] --> src/client/client.rs:2:16 [INFO] [stderr] | [INFO] [stderr] 2 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::SocketAddr` [INFO] [stderr] --> src/client/client.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::net::SocketAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::Cell` [INFO] [stderr] --> src/client/client.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::cell::Cell; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mio::tcp::Shutdown` [INFO] [stderr] --> src/client/client.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use mio::tcp::Shutdown; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mio::IoVec` [INFO] [stderr] --> src/client/client.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use mio::IoVec; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `log::logger` [INFO] [stderr] --> src/client/client.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use log::logger; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | return HttpResponse::ok(headers, body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::ok(headers, body)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | "GET" => return HttpClient::create_response_part(req, true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpClient::create_response_part(req, true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | "HEAD" => return HttpClient::create_response_part(req, false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpClient::create_response_part(req, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | _ => return HttpResponse::not_allowed() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::not_allowed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return decoded_url; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decoded_url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/http/request.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if (request_info.len() < 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/response.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return resp_byte; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resp_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | "png" => return String::from("image/png"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/png")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | "swf" => return String::from("application/x-shockwave-flash"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("application/x-shockwave-flash")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | "gif" => return String::from("image/gif"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/gif")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | "css" => return String::from("text/css"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/css")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | "js" => return String::from("text/javascript"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/javascript")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | "jpg" => return String::from("image/jpeg"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/jpeg")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | "txt" => return String::from("text/plain"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/plain")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | "jpeg" => return String::from("image/jpeg"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/jpeg")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | "html" => return String::from("text/html"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/html")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | _ => return String::from("") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | / return Ok( [INFO] [stderr] 64 | | ( [INFO] [stderr] 65 | | data, [INFO] [stderr] 66 | | fs::metadata(path_to_file_ref).unwrap().len(), [INFO] [stderr] 67 | | FileHandler::get_http_ext(path.extension().unwrap().to_str().unwrap()) [INFO] [stderr] 68 | | ) [INFO] [stderr] 69 | | ) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | Ok( [INFO] [stderr] 64 | ( [INFO] [stderr] 65 | data, [INFO] [stderr] 66 | fs::metadata(path_to_file_ref).unwrap().len(), [INFO] [stderr] 67 | FileHandler::get_http_ext(path.extension().unwrap().to_str().unwrap()) [INFO] [stderr] 68 | ) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | false => return Err(is_dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(is_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/thread_pool/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod thread_pool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod server; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/server/server.rs:2:29 [INFO] [stderr] | [INFO] [stderr] 2 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ClientState` [INFO] [stderr] --> src/server/server.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | use client::client::{HttpClient, ClientState}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `thread_pool::thread_pool::ThreadPool` [INFO] [stderr] --> src/server/server.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use thread_pool::thread_pool::ThreadPool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::os::unix::io::RawFd` [INFO] [stderr] --> src/server/server.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::os::unix::io::RawFd; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread::JoinHandle` [INFO] [stderr] --> src/server/server.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::thread::JoinHandle; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/client/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod client; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Events`, `PollOpt`, `Poll` [INFO] [stderr] --> src/client/client.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | use mio::{Events, Poll, Ready, PollOpt, Token}; [INFO] [stderr] | ^^^^^^ ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpListener` [INFO] [stderr] --> src/client/client.rs:2:16 [INFO] [stderr] | [INFO] [stderr] 2 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::SocketAddr` [INFO] [stderr] --> src/client/client.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::net::SocketAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::Cell` [INFO] [stderr] --> src/client/client.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::cell::Cell; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mio::tcp::Shutdown` [INFO] [stderr] --> src/client/client.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use mio::tcp::Shutdown; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mio::IoVec` [INFO] [stderr] --> src/client/client.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use mio::IoVec; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `log::logger` [INFO] [stderr] --> src/client/client.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use log::logger; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | return HttpResponse::ok(headers, body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::ok(headers, body)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | "GET" => return HttpClient::create_response_part(req, true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpClient::create_response_part(req, true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | "HEAD" => return HttpClient::create_response_part(req, false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpClient::create_response_part(req, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/client.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | _ => return HttpResponse::not_allowed() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HttpResponse::not_allowed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return decoded_url; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decoded_url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/http/request.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if (request_info.len() < 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/response.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return resp_byte; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resp_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | "png" => return String::from("image/png"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/png")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | "swf" => return String::from("application/x-shockwave-flash"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("application/x-shockwave-flash")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | "gif" => return String::from("image/gif"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/gif")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | "css" => return String::from("text/css"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/css")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | "js" => return String::from("text/javascript"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/javascript")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | "jpg" => return String::from("image/jpeg"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/jpeg")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | "txt" => return String::from("text/plain"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/plain")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | "jpeg" => return String::from("image/jpeg"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("image/jpeg")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | "html" => return String::from("text/html"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("text/html")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | _ => return String::from("") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | / return Ok( [INFO] [stderr] 64 | | ( [INFO] [stderr] 65 | | data, [INFO] [stderr] 66 | | fs::metadata(path_to_file_ref).unwrap().len(), [INFO] [stderr] 67 | | FileHandler::get_http_ext(path.extension().unwrap().to_str().unwrap()) [INFO] [stderr] 68 | | ) [INFO] [stderr] 69 | | ) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | Ok( [INFO] [stderr] 64 | ( [INFO] [stderr] 65 | data, [INFO] [stderr] 66 | fs::metadata(path_to_file_ref).unwrap().len(), [INFO] [stderr] 67 | FileHandler::get_http_ext(path.extension().unwrap().to_str().unwrap()) [INFO] [stderr] 68 | ) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_handler/hanlder.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | false => return Err(is_dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(is_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/thread_pool/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod thread_pool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/server/server.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | continue; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::net::TcpListener::from_listener': use from_std instead [INFO] [stderr] --> src/server/server.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | let copy_listener = TcpListener::from_listener(listener.try_clone().unwrap(), &s_a).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/server/server.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | continue; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::net::TcpListener::from_listener': use from_std instead [INFO] [stderr] --> src/server/server.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | let copy_listener = TcpListener::from_listener(listener.try_clone().unwrap(), &s_a).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/server/server.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/server/server.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/server/server.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let addr: SocketAddr = addr.parse().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/server/server.rs:56:49 [INFO] [stderr] | [INFO] [stderr] 56 | Ok((mut client, addr)) => { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/server/server.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | for i in 0..4 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/client/client.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | let status = match is_forbidden { [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `http_response` [INFO] [stderr] --> src/client/client.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | let mut http_response = match self.req { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_http_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `st` [INFO] [stderr] --> src/client/client.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let st = str::from_utf8(&buf[0..len]).unwrap(); [INFO] [stderr] | ^^ help: consider using `_st` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d` [INFO] [stderr] --> src/file_handler/hanlder.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let d = ch; [INFO] [stderr] | ^ help: consider using `_d` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/server/server.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/server/server.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/server/server.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | let addr: SocketAddr = addr.parse().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/server/server.rs:56:49 [INFO] [stderr] | [INFO] [stderr] 56 | Ok((mut client, addr)) => { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/server/server.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | for i in 0..4 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/client/client.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | let status = match is_forbidden { [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `http_response` [INFO] [stderr] --> src/client/client.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | let mut http_response = match self.req { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_http_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `st` [INFO] [stderr] --> src/client/client.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let st = str::from_utf8(&buf[0..len]).unwrap(); [INFO] [stderr] | ^^ help: consider using `_st` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d` [INFO] [stderr] --> src/file_handler/hanlder.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | let d = ch; [INFO] [stderr] | ^ help: consider using `_d` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server/server.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let mut poll = Poll::new().unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/client/client.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut http_response = match self.req { [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server/server.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let mut poll = Poll::new().unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/client/client.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut http_response = match self.req { [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/file_handler/hanlder.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | let mut path_to_file_ref: &str = &new_path_to_file; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `poll` [INFO] [stderr] --> src/server/server.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | poll: Poll, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `events` [INFO] [stderr] --> src/server/server.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | events: Events, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `clients` [INFO] [stderr] --> src/server/server.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | clients: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `token` [INFO] [stderr] --> src/server/server.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | token: usize, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SERVER` [INFO] [stderr] --> src/client/client.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const SERVER: Token = Token(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `REQUEST_READED` [INFO] [stderr] --> src/client/client.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | REQUEST_READED, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RESPONSE_CREATED` [INFO] [stderr] --> src/client/client.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | RESPONSE_CREATED [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `state` [INFO] [stderr] --> src/client/client.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | state: ClientState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/http/request.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn new() -> HttpRequest { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_empty` [INFO] [stderr] --> src/http/response.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new_empty() -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/http/response.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new(status: i32, headers: Option>, body: Option>) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_status` [INFO] [stderr] --> src/http/response.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn set_status(&mut self, status: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_body` [INFO] [stderr] --> src/http/response.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn set_body(&mut self, body: Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_headers` [INFO] [stderr] --> src/http/response.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn set_headers(&mut self, headers: HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_connection` [INFO] [stderr] --> src/http/response.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn set_connection(&mut self, connection: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NewJob` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | NewJob(Job), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ThreadPool` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct ThreadPool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(size: usize) -> ThreadPool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `execute` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn execute(&self, f: F) [INFO] [stderr] 49 | | where [INFO] [stderr] 50 | | F: FnOnce() + Send + 'static [INFO] [stderr] 51 | | { [INFO] [stderr] ... | [INFO] [stderr] 54 | | self.sender.send(Message::NewJob(job)).unwrap(); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Worker` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | struct Worker { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / fn new(id: usize, receiver: Arc>>) -> [INFO] [stderr] 85 | | Worker { [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | let thread = thread::spawn(move ||{ [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/file_handler/hanlder.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | let mut path_to_file_ref: &str = &new_path_to_file; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/server.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | th.join(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variant `REQUEST_READED` should have a camel case name such as `RequestReaded` [INFO] [stderr] --> src/client/client.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | REQUEST_READED, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `RESPONSE_CREATED` should have a camel case name such as `ResponseCreated` [INFO] [stderr] --> src/client/client.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | RESPONSE_CREATED [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let status =` [INFO] [stderr] --> src/client/client.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / let status = match is_forbidden { [INFO] [stderr] 51 | | true => return HttpResponse::forbidden(), [INFO] [stderr] 52 | | false => return HttpResponse::not_found() [INFO] [stderr] 53 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/client/client.rs:50:30 [INFO] [stderr] | [INFO] [stderr] 50 | let status = match is_forbidden { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 51 | | true => return HttpResponse::forbidden(), [INFO] [stderr] 52 | | false => return HttpResponse::not_found() [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if is_forbidden { return HttpResponse::forbidden() } else { return HttpResponse::not_found() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: field is never used: `poll` [INFO] [stderr] --> src/server/server.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | poll: Poll, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `events` [INFO] [stderr] --> src/server/server.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | events: Events, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `clients` [INFO] [stderr] --> src/server/server.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | clients: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let mut http_response =` [INFO] [stderr] --> src/client/client.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / let mut http_response = match self.req { [INFO] [stderr] 68 | | Some(ref http_request) => return HttpClient::create_response(http_request), [INFO] [stderr] 69 | | None => return HttpResponse::bad_request() [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: field is never used: `token` [INFO] [stderr] --> src/server/server.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | token: usize, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SERVER` [INFO] [stderr] --> src/client/client.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | const SERVER: Token = Token(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `REQUEST_READED` [INFO] [stderr] --> src/client/client.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | REQUEST_READED, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RESPONSE_CREATED` [INFO] [stderr] --> src/client/client.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | RESPONSE_CREATED [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `state` [INFO] [stderr] --> src/client/client.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | state: ClientState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/http/request.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn new() -> HttpRequest { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_empty` [INFO] [stderr] --> src/http/response.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new_empty() -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/http/response.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new(status: i32, headers: Option>, body: Option>) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_status` [INFO] [stderr] --> src/http/response.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn set_status(&mut self, status: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_body` [INFO] [stderr] --> src/http/response.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn set_body(&mut self, body: Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_headers` [INFO] [stderr] --> src/http/response.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn set_headers(&mut self, headers: HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_connection` [INFO] [stderr] --> src/http/response.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn set_connection(&mut self, connection: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NewJob` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | NewJob(Job), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ThreadPool` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct ThreadPool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(size: usize) -> ThreadPool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `execute` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn execute(&self, f: F) [INFO] [stderr] 49 | | where [INFO] [stderr] 50 | | F: FnOnce() + Send + 'static [INFO] [stderr] 51 | | { [INFO] [stderr] ... | [INFO] [stderr] 54 | | self.sender.send(Message::NewJob(job)).unwrap(); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Worker` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | struct Worker { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/thread_pool/thread_pool.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / fn new(id: usize, receiver: Arc>>) -> [INFO] [stderr] 85 | | Worker { [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | let thread = thread::spawn(move ||{ [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/client/client.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => panic!("Incorrect string format") // todo deregister or else send err [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client/client.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | self.socket.write(bytes.as_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/http/request.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | let ch = encoded_url.get(idx..idx+1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `idx..=idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http/request.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if http_data_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `http_data_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:50:47 [INFO] [stderr] | [INFO] [stderr] 50 | let request_info = request_line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `stopPath` should have a snake case name such as `stop_path` [INFO] [stderr] --> src/http/request.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let mut stopPath: usize = 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/server.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | th.join(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variant `REQUEST_READED` should have a camel case name such as `RequestReaded` [INFO] [stderr] --> src/client/client.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | REQUEST_READED, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `RESPONSE_CREATED` should have a camel case name such as `ResponseCreated` [INFO] [stderr] --> src/client/client.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | RESPONSE_CREATED [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let status =` [INFO] [stderr] --> src/client/client.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / let status = match is_forbidden { [INFO] [stderr] 51 | | true => return HttpResponse::forbidden(), [INFO] [stderr] 52 | | false => return HttpResponse::not_found() [INFO] [stderr] 53 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/client/client.rs:50:30 [INFO] [stderr] | [INFO] [stderr] 50 | let status = match is_forbidden { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 51 | | true => return HttpResponse::forbidden(), [INFO] [stderr] 52 | | false => return HttpResponse::not_found() [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if is_forbidden { return HttpResponse::forbidden() } else { return HttpResponse::not_found() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let mut http_response =` [INFO] [stderr] --> src/client/client.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / let mut http_response = match self.req { [INFO] [stderr] 68 | | Some(ref http_request) => return HttpClient::create_response(http_request), [INFO] [stderr] 69 | | None => return HttpResponse::bad_request() [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http/response.rs:97:28 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn to_vec_response(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/client/client.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => panic!("Incorrect string format") // todo deregister or else send err [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client/client.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | self.socket.write(bytes.as_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/http/request.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | let ch = encoded_url.get(idx..idx+1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `idx..=idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/response.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match headers { [INFO] [stderr] 119 | | Some(map) => { [INFO] [stderr] 120 | | for (key, val) in map.iter() { [INFO] [stderr] 121 | | headers_string += key; [INFO] [stderr] ... | [INFO] [stderr] 127 | | None => {} [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Some(map) = headers { [INFO] [stderr] 119 | for (key, val) in map.iter() { [INFO] [stderr] 120 | headers_string += key; [INFO] [stderr] 121 | headers_string += ": "; [INFO] [stderr] 122 | headers_string += val; [INFO] [stderr] 123 | headers_string += HTTP_TERMINATOR; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/response.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match body { [INFO] [stderr] 132 | | Some(data) => body_bytes = data, [INFO] [stderr] 133 | | None => {} [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(data) = body { body_bytes = data }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http/request.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if http_data_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `http_data_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http/request.rs:50:47 [INFO] [stderr] | [INFO] [stderr] 50 | let request_info = request_line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `stopPath` should have a snake case name such as `stop_path` [INFO] [stderr] --> src/http/request.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let mut stopPath: usize = 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http/response.rs:97:28 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn to_vec_response(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/file_handler/hanlder.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match path.exists() { [INFO] [stderr] 55 | | true => { [INFO] [stderr] 56 | | let mut data = None; [INFO] [stderr] 57 | | if need_to_read { [INFO] [stderr] ... | [INFO] [stderr] 73 | | false => return Err(is_dir) [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 54 | if path.exists() { [INFO] [stderr] 55 | let mut data = None; [INFO] [stderr] 56 | if need_to_read { [INFO] [stderr] 57 | let mut bytes = Vec::new(); [INFO] [stderr] 58 | let mut file = File::open(path).unwrap(); [INFO] [stderr] 59 | file.read_to_end(&mut bytes); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/file_handler/hanlder.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut data = None; [INFO] [stderr] 57 | | if need_to_read { [INFO] [stderr] 58 | | let mut bytes = Vec::new(); [INFO] [stderr] 59 | | let mut file = File::open(path).unwrap(); [INFO] [stderr] 60 | | file.read_to_end(&mut bytes); [INFO] [stderr] 61 | | data = Some(bytes); [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let data = if need_to_read { ..; Some(bytes) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/file_handler/hanlder.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | file.read_to_end(&mut bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/response.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match headers { [INFO] [stderr] 119 | | Some(map) => { [INFO] [stderr] 120 | | for (key, val) in map.iter() { [INFO] [stderr] 121 | | headers_string += key; [INFO] [stderr] ... | [INFO] [stderr] 127 | | None => {} [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Some(map) = headers { [INFO] [stderr] 119 | for (key, val) in map.iter() { [INFO] [stderr] 120 | headers_string += key; [INFO] [stderr] 121 | headers_string += ": "; [INFO] [stderr] 122 | headers_string += val; [INFO] [stderr] 123 | headers_string += HTTP_TERMINATOR; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/response.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match body { [INFO] [stderr] 132 | | Some(data) => body_bytes = data, [INFO] [stderr] 133 | | None => {} [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(data) = body { body_bytes = data }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/file_handler/hanlder.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match path.exists() { [INFO] [stderr] 55 | | true => { [INFO] [stderr] 56 | | let mut data = None; [INFO] [stderr] 57 | | if need_to_read { [INFO] [stderr] ... | [INFO] [stderr] 73 | | false => return Err(is_dir) [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 54 | if path.exists() { [INFO] [stderr] 55 | let mut data = None; [INFO] [stderr] 56 | if need_to_read { [INFO] [stderr] 57 | let mut bytes = Vec::new(); [INFO] [stderr] 58 | let mut file = File::open(path).unwrap(); [INFO] [stderr] 59 | file.read_to_end(&mut bytes); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/file_handler/hanlder.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut data = None; [INFO] [stderr] 57 | | if need_to_read { [INFO] [stderr] 58 | | let mut bytes = Vec::new(); [INFO] [stderr] 59 | | let mut file = File::open(path).unwrap(); [INFO] [stderr] 60 | | file.read_to_end(&mut bytes); [INFO] [stderr] 61 | | data = Some(bytes); [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let data = if need_to_read { ..; Some(bytes) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/file_handler/hanlder.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | file.read_to_end(&mut bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `async_server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `async_server`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "991425da9cb958bc86fc63ff97b049955406a4a99e03bdb46d0310d4fb0e8a4c"` [INFO] running `"docker" "rm" "-f" "991425da9cb958bc86fc63ff97b049955406a4a99e03bdb46d0310d4fb0e8a4c"` [INFO] [stdout] 991425da9cb958bc86fc63ff97b049955406a4a99e03bdb46d0310d4fb0e8a4c