[INFO] updating cached repository Huanzo/WarframeNotify [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Huanzo/WarframeNotify [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Huanzo/WarframeNotify" "work/ex/clippy-test-run/sources/stable/gh/Huanzo/WarframeNotify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Huanzo/WarframeNotify'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Huanzo/WarframeNotify" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Huanzo/WarframeNotify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Huanzo/WarframeNotify'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d06a58f2f6f24cc36f1c4042031c75f6e999783 [INFO] sha for GitHub repo Huanzo/WarframeNotify: 2d06a58f2f6f24cc36f1c4042031c75f6e999783 [INFO] validating manifest of Huanzo/WarframeNotify on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Huanzo/WarframeNotify on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Huanzo/WarframeNotify [INFO] finished frobbing Huanzo/WarframeNotify [INFO] frobbed toml for Huanzo/WarframeNotify written to work/ex/clippy-test-run/sources/stable/gh/Huanzo/WarframeNotify/Cargo.toml [INFO] started frobbing Huanzo/WarframeNotify [INFO] finished frobbing Huanzo/WarframeNotify [INFO] frobbed toml for Huanzo/WarframeNotify written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Huanzo/WarframeNotify/Cargo.toml [INFO] crate Huanzo/WarframeNotify has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Huanzo/WarframeNotify against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Huanzo/WarframeNotify:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2171951bf2d5149e25423958a7db10a07d3ff8d2eab337a370e25ec158b55e84 [INFO] running `"docker" "start" "-a" "2171951bf2d5149e25423958a7db10a07d3ff8d2eab337a370e25ec158b55e84"` [INFO] [stderr] Checking xattr v0.1.11 [INFO] [stderr] Compiling oleaut32-sys v0.2.0 [INFO] [stderr] Compiling ole32-sys v0.2.0 [INFO] [stderr] Compiling runtimeobject-sys v0.2.0 [INFO] [stderr] Checking libflate v0.1.10 [INFO] [stderr] Checking semver v0.7.0 [INFO] [stderr] Checking glib-sys v0.4.0 [INFO] [stderr] Checking cairo-sys-rs v0.4.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking openssl v0.9.15 [INFO] [stderr] Checking tar v0.4.13 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking winrt v0.3.0 [INFO] [stderr] Checking gobject-sys v0.4.0 [INFO] [stderr] Checking gio-sys v0.4.0 [INFO] [stderr] Checking pango-sys v0.4.0 [INFO] [stderr] Checking glib v0.3.1 [INFO] [stderr] Checking atk-sys v0.4.0 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking gdk-pixbuf-sys v0.4.0 [INFO] [stderr] Checking pango v0.2.0 [INFO] [stderr] Checking gio v0.2.0 [INFO] [stderr] Checking cairo-rs v0.2.0 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking gdk-pixbuf v0.2.0 [INFO] [stderr] Checking gdk-sys v0.4.0 [INFO] [stderr] Checking reqwest v0.7.2 [INFO] [stderr] Checking gtk-sys v0.4.0 [INFO] [stderr] Checking gdk v0.6.0 [INFO] [stderr] Checking self_update v0.4.0 [INFO] [stderr] Checking gtk v0.2.0 [INFO] [stderr] Checking warframe_data v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | Alerts {missions: missions} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `missions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:55:11 [INFO] [stderr] | [INFO] [stderr] 55 | Sortie {missions: missions, boss: "null".to_string()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `missions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | Alerts {missions: missions} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `missions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:55:11 [INFO] [stderr] | [INFO] [stderr] 55 | Sortie {missions: missions, boss: "null".to_string()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `missions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | let mut iterator = alert_data.missions.len(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | let mut iterator = alert_data.missions.len(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | let mut iterator = alert_data.missions.len(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:136:10 [INFO] [stderr] | [INFO] [stderr] 136 | let mut iterator = alert_data.missions.len(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:175:6 [INFO] [stderr] | [INFO] [stderr] 175 | fs::rename("warframe_data.exe", "warframe_data_OLD.exe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:180:6 [INFO] [stderr] | [INFO] [stderr] 180 | response.read_to_end(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:183:6 [INFO] [stderr] | [INFO] [stderr] 183 | file_new.write_all(&buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:263:8 [INFO] [stderr] | [INFO] [stderr] 263 | while api["Alerts"][n].to_string() != "null" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `api["Alerts"][n]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:273:6 [INFO] [stderr] | [INFO] [stderr] 273 | if api["Alerts"][n]["MissionInfo"]["missionReward"]["items"][0].to_string() == "null".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `api["Alerts"][n]["MissionInfo"]["missionReward"]["items"][0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:273:82 [INFO] [stderr] | [INFO] [stderr] 273 | if api["Alerts"][n]["MissionInfo"]["missionReward"]["items"][0].to_string() == "null".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"null"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:279:26 [INFO] [stderr] | [INFO] [stderr] 279 | if mission.reward.1 == "ul".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"ul"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:290:3 [INFO] [stderr] | [INFO] [stderr] 290 | n = n+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:175:6 [INFO] [stderr] | [INFO] [stderr] 175 | fs::rename("warframe_data.exe", "warframe_data_OLD.exe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:180:6 [INFO] [stderr] | [INFO] [stderr] 180 | response.read_to_end(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:183:6 [INFO] [stderr] | [INFO] [stderr] 183 | file_new.write_all(&buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:263:8 [INFO] [stderr] | [INFO] [stderr] 263 | while api["Alerts"][n].to_string() != "null" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `api["Alerts"][n]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:273:6 [INFO] [stderr] | [INFO] [stderr] 273 | if api["Alerts"][n]["MissionInfo"]["missionReward"]["items"][0].to_string() == "null".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `api["Alerts"][n]["MissionInfo"]["missionReward"]["items"][0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:273:82 [INFO] [stderr] | [INFO] [stderr] 273 | if api["Alerts"][n]["MissionInfo"]["missionReward"]["items"][0].to_string() == "null".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"null"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:279:26 [INFO] [stderr] | [INFO] [stderr] 279 | if mission.reward.1 == "ul".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"ul"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:290:3 [INFO] [stderr] | [INFO] [stderr] 290 | n = n+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `"docker" "inspect" "2171951bf2d5149e25423958a7db10a07d3ff8d2eab337a370e25ec158b55e84"` [INFO] running `"docker" "rm" "-f" "2171951bf2d5149e25423958a7db10a07d3ff8d2eab337a370e25ec158b55e84"` [INFO] [stdout] 2171951bf2d5149e25423958a7db10a07d3ff8d2eab337a370e25ec158b55e84