[INFO] updating cached repository HobbyistRust/cargo-sysroot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HobbyistRust/cargo-sysroot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HobbyistRust/cargo-sysroot" "work/ex/clippy-test-run/sources/stable/gh/HobbyistRust/cargo-sysroot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HobbyistRust/cargo-sysroot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HobbyistRust/cargo-sysroot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HobbyistRust/cargo-sysroot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HobbyistRust/cargo-sysroot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5ea5cebd43f9d830d552f3e0e467a0f97b143bb7 [INFO] sha for GitHub repo HobbyistRust/cargo-sysroot: 5ea5cebd43f9d830d552f3e0e467a0f97b143bb7 [INFO] validating manifest of HobbyistRust/cargo-sysroot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HobbyistRust/cargo-sysroot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HobbyistRust/cargo-sysroot [INFO] finished frobbing HobbyistRust/cargo-sysroot [INFO] frobbed toml for HobbyistRust/cargo-sysroot written to work/ex/clippy-test-run/sources/stable/gh/HobbyistRust/cargo-sysroot/Cargo.toml [INFO] started frobbing HobbyistRust/cargo-sysroot [INFO] finished frobbing HobbyistRust/cargo-sysroot [INFO] frobbed toml for HobbyistRust/cargo-sysroot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HobbyistRust/cargo-sysroot/Cargo.toml [INFO] crate HobbyistRust/cargo-sysroot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HobbyistRust/cargo-sysroot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HobbyistRust/cargo-sysroot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 092c9a6f5483b92b9cd87fb26a93157ba11375e60e654d758ba5e324bb2510df [INFO] running `"docker" "start" "-a" "092c9a6f5483b92b9cd87fb26a93157ba11375e60e654d758ba5e324bb2510df"` [INFO] [stderr] Checking cargo-sysroot v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | Some(fs) => fs.into_iter().collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | format!("{}", cfg.local_sysroot.to_str().unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `cfg.local_sysroot.to_str().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | Some(fs) => fs.into_iter().collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | format!("{}", cfg.local_sysroot.to_str().unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `cfg.local_sysroot.to_str().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `"docker" "inspect" "092c9a6f5483b92b9cd87fb26a93157ba11375e60e654d758ba5e324bb2510df"` [INFO] running `"docker" "rm" "-f" "092c9a6f5483b92b9cd87fb26a93157ba11375e60e654d758ba5e324bb2510df"` [INFO] [stdout] 092c9a6f5483b92b9cd87fb26a93157ba11375e60e654d758ba5e324bb2510df