[INFO] updating cached repository HeroicKatora/automata
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/HeroicKatora/automata
[INFO] [stderr] * branch HEAD -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/HeroicKatora/automata" "work/ex/clippy-test-run/sources/stable/gh/HeroicKatora/automata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HeroicKatora/automata'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/HeroicKatora/automata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeroicKatora/automata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeroicKatora/automata'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 32d51d94edeedd2ac1ce98bf31939678beff7bd4
[INFO] sha for GitHub repo HeroicKatora/automata: 32d51d94edeedd2ac1ce98bf31939678beff7bd4
[INFO] validating manifest of HeroicKatora/automata on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of HeroicKatora/automata on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing HeroicKatora/automata
[INFO] finished frobbing HeroicKatora/automata
[INFO] frobbed toml for HeroicKatora/automata written to work/ex/clippy-test-run/sources/stable/gh/HeroicKatora/automata/Cargo.toml
[INFO] started frobbing HeroicKatora/automata
[INFO] finished frobbing HeroicKatora/automata
[INFO] frobbed toml for HeroicKatora/automata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeroicKatora/automata/Cargo.toml
[INFO] crate HeroicKatora/automata has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting HeroicKatora/automata against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HeroicKatora/automata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 815614ad2fbbd251aaa1934b55fc5346894d7bce40a51e4a24b56966c5ae0f82
[INFO] running `"docker" "start" "-a" "815614ad2fbbd251aaa1934b55fc5346894d7bce40a51e4a24b56966c5ae0f82"`
[INFO] [stderr] Checking automata v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:82:13
[INFO] [stderr] |
[INFO] [stderr] 82 | write!(&mut inner, "{} {} {{\n", family.name(), name)?;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:84:13
[INFO] [stderr] |
[INFO] [stderr] 84 | write!(&mut inner, "{} {{\n", family.name())?;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:127:13
[INFO] [stderr] |
[INFO] [stderr] 127 | write!(fmt, "[{}];\n", options)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:129:13
[INFO] [stderr] |
[INFO] [stderr] 129 | write!(fmt, ";\n")
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:140:13
[INFO] [stderr] |
[INFO] [stderr] 140 | write!(fmt, "[{}];\n", options)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:142:13
[INFO] [stderr] |
[INFO] [stderr] 142 | write!(fmt, ";\n")
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:82:13
[INFO] [stderr] |
[INFO] [stderr] 82 | write!(&mut inner, "{} {} {{\n", family.name(), name)?;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:84:13
[INFO] [stderr] |
[INFO] [stderr] 84 | write!(&mut inner, "{} {{\n", family.name())?;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:127:13
[INFO] [stderr] |
[INFO] [stderr] 127 | write!(fmt, "[{}];\n", options)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:129:13
[INFO] [stderr] |
[INFO] [stderr] 129 | write!(fmt, ";\n")
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:140:13
[INFO] [stderr] |
[INFO] [stderr] 140 | write!(fmt, "[{}];\n", options)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr] --> src/dot.rs:142:13
[INFO] [stderr] |
[INFO] [stderr] 142 | write!(fmt, ";\n")
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/dfa.rs:47:31
[INFO] [stderr] |
[INFO] [stderr] 47 | edges[from].push((a.clone(), Node(to)));
[INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr] --> src/dfa.rs:86:30
[INFO] [stderr] |
[INFO] [stderr] 86 | while let Some(ch) = sequence.next() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for ch in sequence { .. }`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/dfa.rs:98:21
[INFO] [stderr] |
[INFO] [stderr] 98 | pub fn to_regex(self) -> Regex {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr] --> src/dfa.rs:111:24
[INFO] [stderr] |
[INFO] [stderr] 111 | .. DotEdge::none()
[INFO] [stderr] | ^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/dfa.rs:180:29
[INFO] [stderr] |
[INFO] [stderr] 180 | edges.push((symbol.clone(), Node(node_id)));
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*symbol`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/dfa.rs:47:31
[INFO] [stderr] |
[INFO] [stderr] 47 | edges[from].push((a.clone(), Node(to)));
[INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr] --> src/dfa.rs:86:30
[INFO] [stderr] |
[INFO] [stderr] 86 | while let Some(ch) = sequence.next() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for ch in sequence { .. }`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/dfa.rs:98:21
[INFO] [stderr] |
[INFO] [stderr] 98 | pub fn to_regex(self) -> Regex {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr] --> src/dfa.rs:111:24
[INFO] [stderr] |
[INFO] [stderr] 111 | .. DotEdge::none()
[INFO] [stderr] | ^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/dfa.rs:180:29
[INFO] [stderr] |
[INFO] [stderr] 180 | edges.push((symbol.clone(), Node(node_id)));
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*symbol`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr] --> src/dot.rs:122:32
[INFO] [stderr] |
[INFO] [stderr] 122 | while let Some(next) = iter.next() {
[INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr]
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr] --> src/dot.rs:137:9
[INFO] [stderr] |
[INFO] [stderr] 137 | write!(fmt, "\t{} ", id);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(unused_must_use)] on by default
[INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr] --> src/dot.rs:122:32
[INFO] [stderr] |
[INFO] [stderr] 122 | while let Some(next) = iter.next() {
[INFO] [stderr] | ^^^^^^^^^^^ help: try: `for next in iter { .. }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr]
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr] --> src/dot.rs:137:9
[INFO] [stderr] |
[INFO] [stderr] 137 | write!(fmt, "\t{} ", id);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(unused_must_use)] on by default
[INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/dot.rs:260:25
[INFO] [stderr] |
[INFO] [stderr] 260 | assert!(vec.len() > 0, "contains at least one quote");
[INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/dot.rs:260:25
[INFO] [stderr] |
[INFO] [stderr] 260 | assert!(vec.len() > 0, "contains at least one quote");
[INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/dot.rs:368:36
[INFO] [stderr] |
[INFO] [stderr] 368 | if let Some(peripheries) = self.peripheries.clone() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.peripheries`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/dot.rs:368:36
[INFO] [stderr] |
[INFO] [stderr] 368 | if let Some(peripheries) = self.peripheries.clone() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.peripheries`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/nfa.rs:124:21
[INFO] [stderr] |
[INFO] [stderr] 124 | pub fn to_regex(self) -> Regex {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/nfa.rs:132:44
[INFO] [stderr] |
[INFO] [stderr] 132 | pub fn to_dfa>(self, alphabet_extension: I) -> Dfa {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/nfa.rs:148:24
[INFO] [stderr] |
[INFO] [stderr] 148 | let from = state_map.get(&next).unwrap().clone();
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*state_map.get(&next).unwrap()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr] --> src/nfa.rs:148:24
[INFO] [stderr] |
[INFO] [stderr] 148 | let from = state_map.get(&next).unwrap().clone();
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state_map[&next]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/nfa.rs:124:21
[INFO] [stderr] |
[INFO] [stderr] 124 | pub fn to_regex(self) -> Regex {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/nfa.rs:132:44
[INFO] [stderr] |
[INFO] [stderr] 132 | pub fn to_dfa>(self, alphabet_extension: I) -> Dfa {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr] --> src/nfa.rs:190:24
[INFO] [stderr] |
[INFO] [stderr] 190 | .. DotEdge::none()
[INFO] [stderr] | ^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr]
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr] --> src/nfa.rs:201:24
[INFO] [stderr] |
[INFO] [stderr] 201 | .. DotEdge::none()
[INFO] [stderr] | ^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr]
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr] --> src/nfa.rs:148:24
[INFO] [stderr] |
[INFO] [stderr] 148 | let from = state_map.get(&next).unwrap().clone();
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*state_map.get(&next).unwrap()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr] --> src/nfa.rs:148:24
[INFO] [stderr] |
[INFO] [stderr] 148 | let from = state_map.get(&next).unwrap().clone();
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&state_map[&next]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr]
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr] --> src/nfa.rs:233:30
[INFO] [stderr] |
[INFO] [stderr] 233 | while let Some(ch) = sequence.next() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for ch in sequence { .. }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/nfa.rs:283:19
[INFO] [stderr] |
[INFO] [stderr] 283 | pub fn to_nfa(self) -> Nfa {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/regex.rs:11:19
[INFO] [stderr] |
[INFO] [stderr] 11 | pub fn to_nfa(self) -> Nfa {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr] --> src/nfa.rs:190:24
[INFO] [stderr] |
[INFO] [stderr] 190 | .. DotEdge::none()
[INFO] [stderr] | ^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr]
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr] --> src/nfa.rs:201:24
[INFO] [stderr] |
[INFO] [stderr] 201 | .. DotEdge::none()
[INFO] [stderr] | ^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr]
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr] --> src/nfa.rs:233:30
[INFO] [stderr] |
[INFO] [stderr] 233 | while let Some(ch) = sequence.next() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for ch in sequence { .. }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/nfa.rs:283:19
[INFO] [stderr] |
[INFO] [stderr] 283 | pub fn to_nfa(self) -> Nfa {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr] --> src/regex.rs:11:19
[INFO] [stderr] |
[INFO] [stderr] 11 | pub fn to_nfa(self) -> Nfa {
[INFO] [stderr] | ^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr]
[INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.12s
[INFO] running `"docker" "inspect" "815614ad2fbbd251aaa1934b55fc5346894d7bce40a51e4a24b56966c5ae0f82"`
[INFO] running `"docker" "rm" "-f" "815614ad2fbbd251aaa1934b55fc5346894d7bce40a51e4a24b56966c5ae0f82"`
[INFO] [stdout] 815614ad2fbbd251aaa1934b55fc5346894d7bce40a51e4a24b56966c5ae0f82