[INFO] updating cached repository Henning-K/advent-of-code-2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Henning-K/advent-of-code-2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Henning-K/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/Henning-K/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Henning-K/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Henning-K/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Henning-K/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Henning-K/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3c227d2fa4644e2ad0d11f131aef990c887e6505
[INFO] sha for GitHub repo Henning-K/advent-of-code-2018: 3c227d2fa4644e2ad0d11f131aef990c887e6505
[INFO] validating manifest of Henning-K/advent-of-code-2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Henning-K/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Henning-K/advent-of-code-2018
[INFO] finished frobbing Henning-K/advent-of-code-2018
[INFO] frobbed toml for Henning-K/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/Henning-K/advent-of-code-2018/Cargo.toml
[INFO] started frobbing Henning-K/advent-of-code-2018
[INFO] finished frobbing Henning-K/advent-of-code-2018
[INFO] frobbed toml for Henning-K/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Henning-K/advent-of-code-2018/Cargo.toml
[INFO] crate Henning-K/advent-of-code-2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Henning-K/advent-of-code-2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Henning-K/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 96a08063f470da001f7bc98d3c7085c4a62c9e908afc4a86adf4cb9b8c587a6d
[INFO] running `"docker" "start" "-a" "96a08063f470da001f7bc98d3c7085c4a62c9e908afc4a86adf4cb9b8c587a6d"`
[INFO] [stderr]     Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused imports: `BufRead`, `Read`
[INFO] [stderr]  --> src/main.rs:7:15
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::io::{BufRead, BufReader, Read};
[INFO] [stderr]   |               ^^^^^^^             ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `BufRead`, `Read`
[INFO] [stderr]  --> src/main.rs:7:15
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::io::{BufRead, BufReader, Read};
[INFO] [stderr]   |               ^^^^^^^             ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/task_01.rs:12:11
[INFO] [stderr]    |
[INFO] [stderr] 12 |           })
[INFO] [stderr]    |  ___________^
[INFO] [stderr] 13 | |         .fold(0, |acc, x| acc + x);
[INFO] [stderr]    | |__________________________________^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `vec`.
[INFO] [stderr]   --> src/task_02.rs:42:18
[INFO] [stderr]    |
[INFO] [stderr] 42 |         for j in i..vec.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 42 |         for <item> in vec.iter().skip(i) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/task_03.rs:21:31
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let mut board: Vec<u32> = (0..width*height).into_iter().map(|_| 0u32).collect();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..width*height)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/task_03.rs:24:20
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for col in claim.x1..(claim.x2+1) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^ help: use: `claim.x1..=claim.x2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/task_03.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 |             for row in claim.y1..(claim.y2+1) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: use: `claim.y1..=claim.y2`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/task_03.rs:75:5
[INFO] [stderr]    |
[INFO] [stderr] 75 | /     fn from_str<'a>(s: &'a str) -> std::result::Result<Self, nom::Err<CompleteStr>> {
[INFO] [stderr] 76 | |         claim_line(CompleteStr::from(s)).map(|(_rest, claim)| claim)
[INFO] [stderr] 77 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/task_01.rs:12:11
[INFO] [stderr]    |
[INFO] [stderr] 12 |           })
[INFO] [stderr]    |  ___________^
[INFO] [stderr] 13 | |         .fold(0, |acc, x| acc + x);
[INFO] [stderr]    | |__________________________________^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]  --> src/task_05.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let mut bs = String::from(input).into_bytes();
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `vec`.
[INFO] [stderr]   --> src/task_02.rs:42:18
[INFO] [stderr]    |
[INFO] [stderr] 42 |         for j in i..vec.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 42 |         for <item> in vec.iter().skip(i) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/task_08.rs:50:30
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 metadata: if metadata.len() > 0 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!metadata.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/task_08.rs:65:20
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 if metadata.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!metadata.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/task_03.rs:21:31
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let mut board: Vec<u32> = (0..width*height).into_iter().map(|_| 0u32).collect();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..width*height)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/task_03.rs:24:20
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for col in claim.x1..(claim.x2+1) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^ help: use: `claim.x1..=claim.x2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/task_03.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 |             for row in claim.y1..(claim.y2+1) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: use: `claim.y1..=claim.y2`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/task_03.rs:75:5
[INFO] [stderr]    |
[INFO] [stderr] 75 | /     fn from_str<'a>(s: &'a str) -> std::result::Result<Self, nom::Err<CompleteStr>> {
[INFO] [stderr] 76 | |         claim_line(CompleteStr::from(s)).map(|(_rest, claim)| claim)
[INFO] [stderr] 77 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]  --> src/task_05.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let mut bs = String::from(input).into_bytes();
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/task_08.rs:50:30
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 metadata: if metadata.len() > 0 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!metadata.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/task_08.rs:65:20
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 if metadata.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!metadata.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.63s
[INFO] running `"docker" "inspect" "96a08063f470da001f7bc98d3c7085c4a62c9e908afc4a86adf4cb9b8c587a6d"`
[INFO] running `"docker" "rm" "-f" "96a08063f470da001f7bc98d3c7085c4a62c9e908afc4a86adf4cb9b8c587a6d"`
[INFO] [stdout] 96a08063f470da001f7bc98d3c7085c4a62c9e908afc4a86adf4cb9b8c587a6d