[INFO] updating cached repository HectorIX/tcp-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HectorIX/tcp-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HectorIX/tcp-server" "work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HectorIX/tcp-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HectorIX/tcp-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HectorIX/tcp-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2f33b729cdd2e575603eb23a888da934c0e3c32 [INFO] sha for GitHub repo HectorIX/tcp-server: a2f33b729cdd2e575603eb23a888da934c0e3c32 [INFO] validating manifest of HectorIX/tcp-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HectorIX/tcp-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HectorIX/tcp-server [INFO] finished frobbing HectorIX/tcp-server [INFO] frobbed toml for HectorIX/tcp-server written to work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-server/Cargo.toml [INFO] started frobbing HectorIX/tcp-server [INFO] finished frobbing HectorIX/tcp-server [INFO] frobbed toml for HectorIX/tcp-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HectorIX/tcp-server/Cargo.toml [INFO] crate HectorIX/tcp-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HectorIX/tcp-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6745c9d64cba38d382f09b6da4fed1688887e2a52ef00ea35f7fbe9ed01ebaa3 [INFO] running `"docker" "start" "-a" "6745c9d64cba38d382f09b6da4fed1688887e2a52ef00ea35f7fbe9ed01ebaa3"` [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking tcp-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | u [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let u = Mutex::new(User::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | username [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let username = USER.lock().unwrap().username.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | session_key [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let session_key = USER.lock().unwrap().session_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sign_in.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | session_key [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sign_in.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | let session_key = whirlpool_hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | u [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let u = Mutex::new(User::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | username [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let username = USER.lock().unwrap().username.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | session_key [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let session_key = USER.lock().unwrap().session_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sign_in.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | session_key [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sign_in.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | let session_key = whirlpool_hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parser.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | / if instruction.contains("::") { [INFO] [stderr] 15 | | return true; [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | else { [INFO] [stderr] 18 | | return false; [INFO] [stderr] 19 | | } [INFO] [stderr] | |____________^ help: you can reduce it to: `return instruction.contains("::")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sign_up.rs:13:8 [INFO] [stderr] | [INFO] [stderr] 13 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sign_up.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | / match fs::create_dir(user_folder) { [INFO] [stderr] 40 | | [INFO] [stderr] 41 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 42 | | Ok(_) => {}, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Err(e) = fs::create_dir(user_folder) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | format!("sign_up_state::OK**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::OK**".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | format!("sign_up_state::Failure**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::Failure**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | format!("sign_up_state::Dublicate**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::Dublicate**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | format!("sign_up_state::UNCONFIRMED**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::UNCONFIRMED**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | format!("sign_up_state::Unauthorised**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::Unauthorised**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sign_up.rs:120:45 [INFO] [stderr] | [INFO] [stderr] 120 | let id_vector:Vec<&str> = last_id.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sign_in.rs:19:8 [INFO] [stderr] | [INFO] [stderr] 19 | if credentials.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!credentials.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_in.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | format!("sign_in_state::NOT_Mactching**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_in_state::NOT_Mactching**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_in.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | format!("sign_in_state::ALREADY_Sign_in**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_in_state::ALREADY_Sign_in**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/upload.rs:12:8 [INFO] [stderr] | [INFO] [stderr] 12 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/download.rs:12:8 [INFO] [stderr] | [INFO] [stderr] 12 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parser.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | / if instruction.contains("::") { [INFO] [stderr] 15 | | return true; [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | else { [INFO] [stderr] 18 | | return false; [INFO] [stderr] 19 | | } [INFO] [stderr] | |____________^ help: you can reduce it to: `return instruction.contains("::")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sign_up.rs:13:8 [INFO] [stderr] | [INFO] [stderr] 13 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sign_up.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | / match fs::create_dir(user_folder) { [INFO] [stderr] 40 | | [INFO] [stderr] 41 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 42 | | Ok(_) => {}, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Err(e) = fs::create_dir(user_folder) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | format!("sign_up_state::OK**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::OK**".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | format!("sign_up_state::Failure**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::Failure**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | format!("sign_up_state::Dublicate**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::Dublicate**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | format!("sign_up_state::UNCONFIRMED**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::UNCONFIRMED**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_up.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | format!("sign_up_state::Unauthorised**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_up_state::Unauthorised**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sign_up.rs:120:45 [INFO] [stderr] | [INFO] [stderr] 120 | let id_vector:Vec<&str> = last_id.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sign_in.rs:19:8 [INFO] [stderr] | [INFO] [stderr] 19 | if credentials.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!credentials.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_in.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | format!("sign_in_state::NOT_Mactching**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_in_state::NOT_Mactching**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/sign_in.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | format!("sign_in_state::ALREADY_Sign_in**") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sign_in_state::ALREADY_Sign_in**".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/upload.rs:12:8 [INFO] [stderr] | [INFO] [stderr] 12 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/download.rs:12:8 [INFO] [stderr] | [INFO] [stderr] 12 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.19s [INFO] running `"docker" "inspect" "6745c9d64cba38d382f09b6da4fed1688887e2a52ef00ea35f7fbe9ed01ebaa3"` [INFO] running `"docker" "rm" "-f" "6745c9d64cba38d382f09b6da4fed1688887e2a52ef00ea35f7fbe9ed01ebaa3"` [INFO] [stdout] 6745c9d64cba38d382f09b6da4fed1688887e2a52ef00ea35f7fbe9ed01ebaa3