[INFO] updating cached repository HectorIX/tcp-client [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HectorIX/tcp-client [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HectorIX/tcp-client" "work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-client'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HectorIX/tcp-client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HectorIX/tcp-client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HectorIX/tcp-client'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae3406bdc726c3d604969b1975eb21589d492d33 [INFO] sha for GitHub repo HectorIX/tcp-client: ae3406bdc726c3d604969b1975eb21589d492d33 [INFO] validating manifest of HectorIX/tcp-client on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HectorIX/tcp-client on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HectorIX/tcp-client [INFO] finished frobbing HectorIX/tcp-client [INFO] frobbed toml for HectorIX/tcp-client written to work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-client/Cargo.toml [INFO] started frobbing HectorIX/tcp-client [INFO] finished frobbing HectorIX/tcp-client [INFO] frobbed toml for HectorIX/tcp-client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HectorIX/tcp-client/Cargo.toml [INFO] crate HectorIX/tcp-client has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HectorIX/tcp-client against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HectorIX/tcp-client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1270052fcbec0c01b9458068dd9b052aae028d27db8d7d24988d7cfdb0f2c07 [INFO] running `"docker" "start" "-a" "d1270052fcbec0c01b9458068dd9b052aae028d27db8d7d24988d7cfdb0f2c07"` [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking rpassword v0.4.0 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking tcp-client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let m = Mutex::new(User::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | username [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let username = USER.lock().unwrap().username.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | session_key [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let session_key = USER.lock().unwrap().session_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let status = USER.lock().unwrap().active.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/interface.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | filename [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/interface.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | let filename = rpassword::prompt_response_stdout("\nEnter filename: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/client_upload.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client_download.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client_download.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client_download.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/integrity.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | sha_512 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/integrity.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | let sha_512 = hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/integrity.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | whirlpool [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/integrity.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | let whirlpool = whirlpool_hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | BytesMut::from("\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:247:17 [INFO] [stderr] | [INFO] [stderr] 247 | BytesMut::from("\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let m = Mutex::new(User::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | username [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let username = USER.lock().unwrap().username.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | session_key [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let session_key = USER.lock().unwrap().session_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/user.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/user.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let status = USER.lock().unwrap().active.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/interface.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | filename [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/interface.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | let filename = rpassword::prompt_response_stdout("\nEnter filename: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/client_upload.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client_download.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client_download.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client_download.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/integrity.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | sha_512 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/integrity.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | let sha_512 = hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/integrity.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | whirlpool [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/integrity.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | let whirlpool = whirlpool_hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/file_io.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | Err(e) => { return "**Failed".to_string().into_bytes(); }, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/file_io.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | Err(e) => { return "**Failed {}".to_string().into_bytes(); }, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/client_upload.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let x = file_io::read_u8(path_to_file.clone().to_string()); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | BytesMut::from("\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:247:17 [INFO] [stderr] | [INFO] [stderr] 247 | BytesMut::from("\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/user.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let status = USER.lock().unwrap().active.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `USER.lock().unwrap().active` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | let req_vector: Vec<&str> = req.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:133:26 [INFO] [stderr] | [INFO] [stderr] 133 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:152:31 [INFO] [stderr] | [INFO] [stderr] 152 | else if status == "NOT_Mactching".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"NOT_Mactching"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | else if status == "UNCONFIRMED".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"UNCONFIRMED"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:160:31 [INFO] [stderr] | [INFO] [stderr] 160 | else if status == "ALREADY_Sign_in".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"ALREADY_Sign_in"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:172:26 [INFO] [stderr] | [INFO] [stderr] 172 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:176:31 [INFO] [stderr] | [INFO] [stderr] 176 | else if status == "Dublicate".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Dublicate"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | else if status == "Unauthorised".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Unauthorised"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:184:31 [INFO] [stderr] | [INFO] [stderr] 184 | else if status == "Failure".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"Failure"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:195:26 [INFO] [stderr] | [INFO] [stderr] 195 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:199:31 [INFO] [stderr] | [INFO] [stderr] 199 | else if status == "Failed".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"Failed"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:203:31 [INFO] [stderr] | [INFO] [stderr] 203 | else if status == "Failure".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"Failure"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:207:31 [INFO] [stderr] | [INFO] [stderr] 207 | else if status == "SESSION_Expired".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"SESSION_Expired"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:235:31 [INFO] [stderr] | [INFO] [stderr] 235 | else if status == "Failed".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"Failed"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:239:31 [INFO] [stderr] | [INFO] [stderr] 239 | else if status == "Failure".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"Failure"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:243:31 [INFO] [stderr] | [INFO] [stderr] 243 | else if status == "SESSION_Expired".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"SESSION_Expired"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/local_services.rs:125:55 [INFO] [stderr] | [INFO] [stderr] 125 | encrypted_string.push(std::char::from_u32(byte as u32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / match fs::create_dir(download_dir) { [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 66 | | Ok(_) => {}, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(download_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / match fs::create_dir(upload_dir) { [INFO] [stderr] 71 | | [INFO] [stderr] 72 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 73 | | Ok(_) => {}, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(upload_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match fs::create_dir(local_data_dir) { [INFO] [stderr] 79 | | [INFO] [stderr] 80 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 81 | | Ok(_) => {}, [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(local_data_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match fs::create_dir(raw_dir) { [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 88 | | Ok(_) => {}, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(raw_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / match fs::create_dir(decrypted_dir) { [INFO] [stderr] 93 | | [INFO] [stderr] 94 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 95 | | Ok(_) => {}, [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(decrypted_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / match fs::create_dir(encrypted_dir) { [INFO] [stderr] 100 | | [INFO] [stderr] 101 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 102 | | Ok(_) => {}, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(encrypted_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / match fs::create_dir(key_manager_dir) { [INFO] [stderr] 107 | | [INFO] [stderr] 108 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 109 | | Ok(_) => {}, [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(key_manager_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | / match fs::create_dir(integrity_dir) { [INFO] [stderr] 114 | | [INFO] [stderr] 115 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 116 | | Ok(_) => {}, [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(integrity_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/file_io.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | Err(e) => { return "**Failed".to_string().into_bytes(); }, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/file_io.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | Err(e) => { return "**Failed {}".to_string().into_bytes(); }, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/client_upload.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let x = file_io::read_u8(path_to_file.clone().to_string()); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client_download.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/aes_256.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/aes_256.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/user.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let status = USER.lock().unwrap().active.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `USER.lock().unwrap().active` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | let req_vector: Vec<&str> = req.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:133:26 [INFO] [stderr] | [INFO] [stderr] 133 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:152:31 [INFO] [stderr] | [INFO] [stderr] 152 | else if status == "NOT_Mactching".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"NOT_Mactching"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | else if status == "UNCONFIRMED".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"UNCONFIRMED"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:160:31 [INFO] [stderr] | [INFO] [stderr] 160 | else if status == "ALREADY_Sign_in".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"ALREADY_Sign_in"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:172:26 [INFO] [stderr] | [INFO] [stderr] 172 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:176:31 [INFO] [stderr] | [INFO] [stderr] 176 | else if status == "Dublicate".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Dublicate"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | else if status == "Unauthorised".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Unauthorised"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:184:31 [INFO] [stderr] | [INFO] [stderr] 184 | else if status == "Failure".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"Failure"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:195:26 [INFO] [stderr] | [INFO] [stderr] 195 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:199:31 [INFO] [stderr] | [INFO] [stderr] 199 | else if status == "Failed".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"Failed"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:203:31 [INFO] [stderr] | [INFO] [stderr] 203 | else if status == "Failure".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"Failure"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:207:31 [INFO] [stderr] | [INFO] [stderr] 207 | else if status == "SESSION_Expired".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"SESSION_Expired"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | if status == "OK".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:235:31 [INFO] [stderr] | [INFO] [stderr] 235 | else if status == "Failed".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"Failed"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:239:31 [INFO] [stderr] | [INFO] [stderr] 239 | else if status == "Failure".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"Failure"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parser.rs:243:31 [INFO] [stderr] | [INFO] [stderr] 243 | else if status == "SESSION_Expired".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"SESSION_Expired"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/local_services.rs:125:55 [INFO] [stderr] | [INFO] [stderr] 125 | encrypted_string.push(std::char::from_u32(byte as u32).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / match fs::create_dir(download_dir) { [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 66 | | Ok(_) => {}, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(download_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / match fs::create_dir(upload_dir) { [INFO] [stderr] 71 | | [INFO] [stderr] 72 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 73 | | Ok(_) => {}, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(upload_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match fs::create_dir(local_data_dir) { [INFO] [stderr] 79 | | [INFO] [stderr] 80 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 81 | | Ok(_) => {}, [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(local_data_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match fs::create_dir(raw_dir) { [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 88 | | Ok(_) => {}, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(raw_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / match fs::create_dir(decrypted_dir) { [INFO] [stderr] 93 | | [INFO] [stderr] 94 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 95 | | Ok(_) => {}, [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(decrypted_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / match fs::create_dir(encrypted_dir) { [INFO] [stderr] 100 | | [INFO] [stderr] 101 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 102 | | Ok(_) => {}, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(encrypted_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / match fs::create_dir(key_manager_dir) { [INFO] [stderr] 107 | | [INFO] [stderr] 108 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 109 | | Ok(_) => {}, [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(key_manager_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client_sign_up.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | / match fs::create_dir(integrity_dir) { [INFO] [stderr] 114 | | [INFO] [stderr] 115 | | Err(e) => println!("Failed to create folder: {:?}", e.kind()), [INFO] [stderr] 116 | | Ok(_) => {}, [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = fs::create_dir(integrity_dir) { println!("Failed to create folder: {:?}", e.kind()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client_download.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/aes_256.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/aes_256.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.40s [INFO] running `"docker" "inspect" "d1270052fcbec0c01b9458068dd9b052aae028d27db8d7d24988d7cfdb0f2c07"` [INFO] running `"docker" "rm" "-f" "d1270052fcbec0c01b9458068dd9b052aae028d27db8d7d24988d7cfdb0f2c07"` [INFO] [stdout] d1270052fcbec0c01b9458068dd9b052aae028d27db8d7d24988d7cfdb0f2c07