[INFO] updating cached repository HeapUnderfl0w/TCC [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HeapUnderfl0w/TCC [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HeapUnderfl0w/TCC" "work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/TCC"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/TCC'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HeapUnderfl0w/TCC" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeapUnderfl0w/TCC"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeapUnderfl0w/TCC'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe99aa83edd8b204e1ef400408405c66d8dce67a [INFO] sha for GitHub repo HeapUnderfl0w/TCC: fe99aa83edd8b204e1ef400408405c66d8dce67a [INFO] validating manifest of HeapUnderfl0w/TCC on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HeapUnderfl0w/TCC on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HeapUnderfl0w/TCC [INFO] finished frobbing HeapUnderfl0w/TCC [INFO] frobbed toml for HeapUnderfl0w/TCC written to work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/TCC/Cargo.toml [INFO] started frobbing HeapUnderfl0w/TCC [INFO] finished frobbing HeapUnderfl0w/TCC [INFO] frobbed toml for HeapUnderfl0w/TCC written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeapUnderfl0w/TCC/Cargo.toml [INFO] crate HeapUnderfl0w/TCC has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HeapUnderfl0w/TCC against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/TCC:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 756cb417f532589a0602e5b84732dee576b5cf890fe027b42304c054fb159c90 [INFO] running `"docker" "start" "-a" "756cb417f532589a0602e5b84732dee576b5cf890fe027b42304c054fb159c90"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking backtrace-sys v0.1.23 [INFO] [stderr] Compiling syn v0.14.1 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking tui v0.2.2 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.64 [INFO] [stderr] Compiling derive-error-chain v0.11.2 [INFO] [stderr] Checking dotenv v0.11.0 [INFO] [stderr] Checking irc v0.13.5 [INFO] [stderr] Checking tcc v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/color.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/color.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/color.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/color.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ui/wrapper.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 112 | | if scroll >= self.screen_lines.len() as u16 { [INFO] [stderr] 113 | | Err(String::from("Cannot scroll past end")) [INFO] [stderr] 114 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 111 | } else if scroll >= self.screen_lines.len() as u16 { [INFO] [stderr] 112 | Err(String::from("Cannot scroll past end")) [INFO] [stderr] 113 | } else { [INFO] [stderr] 114 | let to = self.screen_lines.len() - scroll as usize; [INFO] [stderr] 115 | let from = match to.checked_sub(lines as usize) { [INFO] [stderr] 116 | Some(off) => off, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ui/wrapper.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 112 | | if scroll >= self.screen_lines.len() as u16 { [INFO] [stderr] 113 | | Err(String::from("Cannot scroll past end")) [INFO] [stderr] 114 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 111 | } else if scroll >= self.screen_lines.len() as u16 { [INFO] [stderr] 112 | Err(String::from("Cannot scroll past end")) [INFO] [stderr] 113 | } else { [INFO] [stderr] 114 | let to = self.screen_lines.len() - scroll as usize; [INFO] [stderr] 115 | let from = match to.checked_sub(lines as usize) { [INFO] [stderr] 116 | Some(off) => off, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/utils.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | tags.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | Irc(IrcError), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 55 | Irc(Box), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> src/client.rs:270:1 [INFO] [stderr] | [INFO] [stderr] 270 | / fn raw(m: Message, tx: Sender) -> Result<(), Error> { [INFO] [stderr] 271 | | let c = match m.command { [INFO] [stderr] 272 | | Command::Raw(ref c, ..) => c, [INFO] [stderr] 273 | | _ => unreachable!(), [INFO] [stderr] ... | [INFO] [stderr] 633 | | Ok(()) [INFO] [stderr] 634 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/utils.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | tags.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/utils.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | let ch = if !chn.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/utils.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | let ch = if !chn.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/utils.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | let ch = if !chn.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: item `ui::wrapper::WordWrapper` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ui/wrapper.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / impl WordWrapper { [INFO] [stderr] 28 | | /// Create a new instance of this object with the given wrap width. [INFO] [stderr] 29 | | pub fn new(width: usize) -> Self { [INFO] [stderr] 30 | | WordWrapper { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ui/wrapper.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if self.input_lines.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.input_lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ui/wrapper.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | if lines == 0 || self.screen_lines.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.screen_lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | Irc(IrcError), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 55 | Irc(Box), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> src/client.rs:270:1 [INFO] [stderr] | [INFO] [stderr] 270 | / fn raw(m: Message, tx: Sender) -> Result<(), Error> { [INFO] [stderr] 271 | | let c = match m.command { [INFO] [stderr] 272 | | Command::Raw(ref c, ..) => c, [INFO] [stderr] 273 | | _ => unreachable!(), [INFO] [stderr] ... | [INFO] [stderr] 633 | | Ok(()) [INFO] [stderr] 634 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/ui/mod.rs:146:28 [INFO] [stderr] | [INFO] [stderr] 146 | if &state.input == &['$', 'q', 'u', 'i', 't'] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 146 | if state.input == ['$', 'q', 'u', 'i', 't'] { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/mod.rs:148:29 [INFO] [stderr] | [INFO] [stderr] 148 | / match out.send(Event::IrcCommand(Command::PING( [INFO] [stderr] 149 | | String::from("tmi.twitch.tv"), [INFO] [stderr] 150 | | None, [INFO] [stderr] 151 | | ))) { [INFO] [stderr] 152 | | Ok(_) => (), [INFO] [stderr] 153 | | Err(_) => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 148 | if let Ok(_) = out.send(Event::IrcCommand(Command::PING( [INFO] [stderr] 149 | String::from("tmi.twitch.tv"), [INFO] [stderr] 150 | None, [INFO] [stderr] 151 | ))) { () } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/mod.rs:164:56 [INFO] [stderr] | [INFO] [stderr] 164 | c if c.starts_with("#") => c.to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/mod.rs:188:56 [INFO] [stderr] | [INFO] [stderr] 188 | c if c.starts_with("#") => c.to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/mod.rs:214:56 [INFO] [stderr] | [INFO] [stderr] 214 | c if c.starts_with("#") => c.to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/mod.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | / match d { [INFO] [stderr] 362 | | Event::IrcCommand(comm) => match client.send(comm) { [INFO] [stderr] 363 | | Ok(_) => (), [INFO] [stderr] 364 | | Err(_) => (), [INFO] [stderr] 365 | | }, [INFO] [stderr] 366 | | _ => (), [INFO] [stderr] 367 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 361 | if let Event::IrcCommand(comm) = d { match client.send(comm) { [INFO] [stderr] 362 | Ok(_) => (), [INFO] [stderr] 363 | Err(_) => (), [INFO] [stderr] 364 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/mod.rs:362:44 [INFO] [stderr] | [INFO] [stderr] 362 | Event::IrcCommand(comm) => match client.send(comm) { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 363 | | Ok(_) => (), [INFO] [stderr] 364 | | Err(_) => (), [INFO] [stderr] 365 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let Ok(_) = client.send(comm) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/utils.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | let ch = if !chn.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/utils.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | let ch = if !chn.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/utils.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | let ch = if !chn.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: item `ui::wrapper::WordWrapper` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ui/wrapper.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / impl WordWrapper { [INFO] [stderr] 28 | | /// Create a new instance of this object with the given wrap width. [INFO] [stderr] 29 | | pub fn new(width: usize) -> Self { [INFO] [stderr] 30 | | WordWrapper { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ui/wrapper.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if self.input_lines.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.input_lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ui/wrapper.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | if lines == 0 || self.screen_lines.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.screen_lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/ui/mod.rs:146:28 [INFO] [stderr] | [INFO] [stderr] 146 | if &state.input == &['$', 'q', 'u', 'i', 't'] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 146 | if state.input == ['$', 'q', 'u', 'i', 't'] { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/mod.rs:148:29 [INFO] [stderr] | [INFO] [stderr] 148 | / match out.send(Event::IrcCommand(Command::PING( [INFO] [stderr] 149 | | String::from("tmi.twitch.tv"), [INFO] [stderr] 150 | | None, [INFO] [stderr] 151 | | ))) { [INFO] [stderr] 152 | | Ok(_) => (), [INFO] [stderr] 153 | | Err(_) => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 148 | if let Ok(_) = out.send(Event::IrcCommand(Command::PING( [INFO] [stderr] 149 | String::from("tmi.twitch.tv"), [INFO] [stderr] 150 | None, [INFO] [stderr] 151 | ))) { () } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/mod.rs:164:56 [INFO] [stderr] | [INFO] [stderr] 164 | c if c.starts_with("#") => c.to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/mod.rs:188:56 [INFO] [stderr] | [INFO] [stderr] 188 | c if c.starts_with("#") => c.to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ui/mod.rs:214:56 [INFO] [stderr] | [INFO] [stderr] 214 | c if c.starts_with("#") => c.to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | .expect(&format!("Unable to join channel {}", &chn)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to join channel {}", &chn))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(o) => Ok(o), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 131 | Ok(o) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/mod.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | / match d { [INFO] [stderr] 362 | | Event::IrcCommand(comm) => match client.send(comm) { [INFO] [stderr] 363 | | Ok(_) => (), [INFO] [stderr] 364 | | Err(_) => (), [INFO] [stderr] 365 | | }, [INFO] [stderr] 366 | | _ => (), [INFO] [stderr] 367 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 361 | if let Event::IrcCommand(comm) = d { match client.send(comm) { [INFO] [stderr] 362 | Ok(_) => (), [INFO] [stderr] 363 | Err(_) => (), [INFO] [stderr] 364 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/mod.rs:362:44 [INFO] [stderr] | [INFO] [stderr] 362 | Event::IrcCommand(comm) => match client.send(comm) { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 363 | | Ok(_) => (), [INFO] [stderr] 364 | | Err(_) => (), [INFO] [stderr] 365 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let Ok(_) = client.send(comm) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | .expect(&format!("Unable to join channel {}", &chn)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to join channel {}", &chn))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(o) => Ok(o), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 131 | Ok(o) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.21s [INFO] running `"docker" "inspect" "756cb417f532589a0602e5b84732dee576b5cf890fe027b42304c054fb159c90"` [INFO] running `"docker" "rm" "-f" "756cb417f532589a0602e5b84732dee576b5cf890fe027b42304c054fb159c90"` [INFO] [stdout] 756cb417f532589a0602e5b84732dee576b5cf890fe027b42304c054fb159c90