[INFO] updating cached repository HeapUnderfl0w/FractalDrawer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HeapUnderfl0w/FractalDrawer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HeapUnderfl0w/FractalDrawer" "work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/FractalDrawer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/FractalDrawer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HeapUnderfl0w/FractalDrawer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeapUnderfl0w/FractalDrawer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeapUnderfl0w/FractalDrawer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 78ae157d9f3e0ac3edefe3ecb4afd8c67dff7678 [INFO] sha for GitHub repo HeapUnderfl0w/FractalDrawer: 78ae157d9f3e0ac3edefe3ecb4afd8c67dff7678 [INFO] validating manifest of HeapUnderfl0w/FractalDrawer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HeapUnderfl0w/FractalDrawer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HeapUnderfl0w/FractalDrawer [INFO] finished frobbing HeapUnderfl0w/FractalDrawer [INFO] frobbed toml for HeapUnderfl0w/FractalDrawer written to work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/FractalDrawer/Cargo.toml [INFO] started frobbing HeapUnderfl0w/FractalDrawer [INFO] finished frobbing HeapUnderfl0w/FractalDrawer [INFO] frobbed toml for HeapUnderfl0w/FractalDrawer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HeapUnderfl0w/FractalDrawer/Cargo.toml [INFO] crate HeapUnderfl0w/FractalDrawer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HeapUnderfl0w/FractalDrawer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HeapUnderfl0w/FractalDrawer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0142a278e5cb8a69d2a3a3a905e7c643b7c0dcd68eaa39f8fcc97829964fd3ed [INFO] running `"docker" "start" "-a" "0142a278e5cb8a69d2a3a3a905e7c643b7c0dcd68eaa39f8fcc97829964fd3ed"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Compiling serde_derive v1.0.30 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking rusty_mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractals/mandelbrot.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | iter = iter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `iter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractals/mandelbrot.rs:51:55 [INFO] [stderr] | [INFO] [stderr] 51 | let xstep = (self.reals[1] - self.reals[0]) / (self.size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractals/mandelbrot.rs:52:61 [INFO] [stderr] | [INFO] [stderr] 52 | let ystep = (self.imagines[1] - self.imagines[0]) / (self.size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractals/mandelbrot.rs:66:46 [INFO] [stderr] | [INFO] [stderr] 66 | re: re[0] + ((x as f64) * xstep), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fractals/mandelbrot.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | iter = iter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `iter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractals/mandelbrot.rs:51:55 [INFO] [stderr] | [INFO] [stderr] 51 | let xstep = (self.reals[1] - self.reals[0]) / (self.size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractals/mandelbrot.rs:52:61 [INFO] [stderr] | [INFO] [stderr] 52 | let ystep = (self.imagines[1] - self.imagines[0]) / (self.size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractals/mandelbrot.rs:66:46 [INFO] [stderr] | [INFO] [stderr] 66 | re: re[0] + ((x as f64) * xstep), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | let offset = args.width as f64 / FRACTAL_IMAGE_SIZE as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | let offset = args.width as f64 / FRACTAL_IMAGE_SIZE as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(FRACTAL_IMAGE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | let offset = args.width as f64 / FRACTAL_IMAGE_SIZE as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | let offset = args.width as f64 / FRACTAL_IMAGE_SIZE as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(FRACTAL_IMAGE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:91:60 [INFO] [stderr] | [INFO] [stderr] 91 | let trans = c.transform.trans(offset * x as f64, offset * y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:91:79 [INFO] [stderr] | [INFO] [stderr] 91 | let trans = c.transform.trans(offset * x as f64, offset * y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:91:60 [INFO] [stderr] | [INFO] [stderr] 91 | let trans = c.transform.trans(offset * x as f64, offset * y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:131:33 [INFO] [stderr] | [INFO] [stderr] 131 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:91:79 [INFO] [stderr] | [INFO] [stderr] 91 | let trans = c.transform.trans(offset * x as f64, offset * y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | if let Err(_) = flush_stdout() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 166 | | println!("\nERR:STDOUTERR"); [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________- help: try this: `if flush_stdout().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:131:33 [INFO] [stderr] | [INFO] [stderr] 131 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | if let Err(_) = flush_stdout() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 166 | | println!("\nERR:STDOUTERR"); [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________- help: try this: `if flush_stdout().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.84s [INFO] running `"docker" "inspect" "0142a278e5cb8a69d2a3a3a905e7c643b7c0dcd68eaa39f8fcc97829964fd3ed"` [INFO] running `"docker" "rm" "-f" "0142a278e5cb8a69d2a3a3a905e7c643b7c0dcd68eaa39f8fcc97829964fd3ed"` [INFO] [stdout] 0142a278e5cb8a69d2a3a3a905e7c643b7c0dcd68eaa39f8fcc97829964fd3ed