[INFO] updating cached repository HazardDev/game-of-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HazardDev/game-of-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HazardDev/game-of-life" "work/ex/clippy-test-run/sources/stable/gh/HazardDev/game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HazardDev/game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HazardDev/game-of-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HazardDev/game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HazardDev/game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a6f50c9d3347475ab1e19391d8919cfbae14283 [INFO] sha for GitHub repo HazardDev/game-of-life: 5a6f50c9d3347475ab1e19391d8919cfbae14283 [INFO] validating manifest of HazardDev/game-of-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HazardDev/game-of-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HazardDev/game-of-life [INFO] finished frobbing HazardDev/game-of-life [INFO] frobbed toml for HazardDev/game-of-life written to work/ex/clippy-test-run/sources/stable/gh/HazardDev/game-of-life/Cargo.toml [INFO] started frobbing HazardDev/game-of-life [INFO] finished frobbing HazardDev/game-of-life [INFO] frobbed toml for HazardDev/game-of-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HazardDev/game-of-life/Cargo.toml [INFO] crate HazardDev/game-of-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HazardDev/game-of-life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HazardDev/game-of-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f8f060434782dcc66218e6c1e4e9cc0bb91a8af75c26361661241ffdcb93850 [INFO] running `"docker" "start" "-a" "9f8f060434782dcc66218e6c1e4e9cc0bb91a8af75c26361661241ffdcb93850"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Compiling wayland-scanner v0.21.7 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling wayland-client v0.21.7 [INFO] [stderr] Compiling wayland-protocols v0.21.7 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling glutin v0.19.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking wayland-sys v0.21.7 [INFO] [stderr] Checking wayland-commons v0.21.7 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking game-of-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | board: board, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | board: board, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | new_tile [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | let new_tile = match adjacent_tiles { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 176 | | x if x < 2 => Tile::Dead, [INFO] [stderr] 177 | | x if (x == 2 || x == 3) && tile != Tile::Dead => Tile::Alive, [INFO] [stderr] 178 | | x if x > 3 => Tile::Dead, [INFO] [stderr] 179 | | x if x == 3 && tile == Tile::Dead => Tile::Alive, [INFO] [stderr] 180 | | _ => Tile::Dead, [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | new_tile [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | let new_tile = match adjacent_tiles { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 176 | | x if x < 2 => Tile::Dead, [INFO] [stderr] 177 | | x if (x == 2 || x == 3) && tile != Tile::Dead => Tile::Alive, [INFO] [stderr] 178 | | x if x > 3 => Tile::Dead, [INFO] [stderr] 179 | | x if x == 3 && tile == Tile::Dead => Tile::Alive, [INFO] [stderr] 180 | | _ => Tile::Dead, [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | fn update(&mut self, arg: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | scale: scale as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | scale: scale as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:162:33 [INFO] [stderr] | [INFO] [stderr] 162 | fn update(&mut self, _args: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | / match e { [INFO] [stderr] 307 | | Event::Input(Input::Move(Motion::MouseCursor(x, y))) => { [INFO] [stderr] 308 | | last_mouse_location = Some([x, y]) [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | _ => {} [INFO] [stderr] 311 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 306 | if let Event::Input(Input::Move(Motion::MouseCursor(x, y))) = e { [INFO] [stderr] 307 | last_mouse_location = Some([x, y]) [INFO] [stderr] 308 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | fn update(&mut self, arg: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | scale: scale as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | scale: scale as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:162:33 [INFO] [stderr] | [INFO] [stderr] 162 | fn update(&mut self, _args: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | / match e { [INFO] [stderr] 307 | | Event::Input(Input::Move(Motion::MouseCursor(x, y))) => { [INFO] [stderr] 308 | | last_mouse_location = Some([x, y]) [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | _ => {} [INFO] [stderr] 311 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 306 | if let Event::Input(Input::Move(Motion::MouseCursor(x, y))) = e { [INFO] [stderr] 307 | last_mouse_location = Some([x, y]) [INFO] [stderr] 308 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 11s [INFO] running `"docker" "inspect" "9f8f060434782dcc66218e6c1e4e9cc0bb91a8af75c26361661241ffdcb93850"` [INFO] running `"docker" "rm" "-f" "9f8f060434782dcc66218e6c1e4e9cc0bb91a8af75c26361661241ffdcb93850"` [INFO] [stdout] 9f8f060434782dcc66218e6c1e4e9cc0bb91a8af75c26361661241ffdcb93850