[INFO] updating cached repository HadrienG2/3photons-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HadrienG2/3photons-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HadrienG2/3photons-rust" "work/ex/clippy-test-run/sources/stable/gh/HadrienG2/3photons-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HadrienG2/3photons-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HadrienG2/3photons-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HadrienG2/3photons-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HadrienG2/3photons-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da873f76eb4243e3e675815cc0c4b82bcbcbcfde [INFO] sha for GitHub repo HadrienG2/3photons-rust: da873f76eb4243e3e675815cc0c4b82bcbcbcfde [INFO] validating manifest of HadrienG2/3photons-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HadrienG2/3photons-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HadrienG2/3photons-rust [INFO] finished frobbing HadrienG2/3photons-rust [INFO] frobbed toml for HadrienG2/3photons-rust written to work/ex/clippy-test-run/sources/stable/gh/HadrienG2/3photons-rust/Cargo.toml [INFO] started frobbing HadrienG2/3photons-rust [INFO] finished frobbing HadrienG2/3photons-rust [INFO] frobbed toml for HadrienG2/3photons-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HadrienG2/3photons-rust/Cargo.toml [INFO] crate HadrienG2/3photons-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HadrienG2/3photons-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/HadrienG2/3photons-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26959ba6a3d0529daed26f6b7a8139e6e15f37c651288d79f870acecb9f97a2b [INFO] running `"docker" "start" "-a" "26959ba6a3d0529daed26f6b7a8139e6e15f37c651288d79f870acecb9f97a2b"` [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking nalgebra v0.16.4 [INFO] [stderr] Checking trois_photons v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | a_cut: a_cut, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `a_cut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | b_cut: b_cut, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_cut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | e_min: e_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `e_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | sin_cut: sin_cut, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sin_cut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resfin.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | sigma_contribs: sigma_contribs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sigma_contribs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | a_cut: a_cut, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `a_cut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | b_cut: b_cut, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_cut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | e_min: e_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `e_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evcut.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | sin_cut: sin_cut, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sin_cut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resfin.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | sigma_contribs: sigma_contribs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sigma_contribs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/event.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | event [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/event.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | let event = Event(Matrix5x4::from_fn(|par, coord| { [INFO] [stderr] | _____________________^ [INFO] [stderr] 162 | | if par < INCOMING_COUNT { [INFO] [stderr] 163 | | self.incoming_momenta[(par, coord)] [INFO] [stderr] 164 | | } else if coord <= Z { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | })); [INFO] [stderr] | |___________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random/ranf.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | Self::seeded_new(234612947) [INFO] [stderr] | ^^^^^^^^^ help: consider: `234_612_947` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/spinor.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/spinor.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | let result = Self { [INFO] [stderr] | ______________________^ [INFO] [stderr] 71 | | sx: ParticleMatrix::from_fn(|i, j| { [INFO] [stderr] 72 | | fx[i] * xx[j] - fx[j] * xx[i] [INFO] [stderr] 73 | | }), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/event.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | event [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/event.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | let event = Event(Matrix5x4::from_fn(|par, coord| { [INFO] [stderr] | _____________________^ [INFO] [stderr] 162 | | if par < INCOMING_COUNT { [INFO] [stderr] 163 | | self.incoming_momenta[(par, coord)] [INFO] [stderr] 164 | | } else if coord <= Z { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | })); [INFO] [stderr] | |___________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random/ranf.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | Self::seeded_new(234612947) [INFO] [stderr] | ^^^^^^^^^ help: consider: `234_612_947` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/spinor.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/spinor.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | let result = Self { [INFO] [stderr] | ______________________^ [INFO] [stderr] 71 | | sx: ParticleMatrix::from_fn(|i, j| { [INFO] [stderr] 72 | | fx[i] * xx[j] - fx[j] * xx[i] [INFO] [stderr] 73 | | }), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | .ok_or(format_err!("Missing configuration of {}", name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Missing configuration of {}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | .ok_or(format_err!("Missing configuration of {}", name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Missing configuration of {}", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:186:22 [INFO] [stderr] | [INFO] [stderr] 186 | .map_err(|e| SyncFailure::new(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SyncFailure::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:186:22 [INFO] [stderr] | [INFO] [stderr] 186 | .map_err(|e| SyncFailure::new(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SyncFailure::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the loop variable `par` is used to index `radius2` [INFO] [stderr] --> src/event.rs:279:20 [INFO] [stderr] | [INFO] [stderr] 279 | for par in 0..OUTGOING_COUNT { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 279 | for (par, ) in radius2.iter_mut().enumerate().take(OUTGOING_COUNT) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `par` is used to index `radius2` [INFO] [stderr] --> src/event.rs:279:20 [INFO] [stderr] | [INFO] [stderr] 279 | for par in 0..OUTGOING_COUNT { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 279 | for (par, ) in radius2.iter_mut().enumerate().take(OUTGOING_COUNT) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/output.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | write!(writer, "{:.1$}", x, precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/output.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | write!(writer, "{:.1$e}", x, precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/output.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | write!(writer, "{:.1$}", x, precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/output.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | write!(writer, "{:.1$e}", x, precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/output.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | write!(*file, " {:<31}: ", label); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:143:38 [INFO] [stderr] | [INFO] [stderr] 143 | 1e-9 * (elapsed_time.subsec_nanos() as Real); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/output.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | write!(*file, " {:<31}: ", label); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:143:38 [INFO] [stderr] | [INFO] [stderr] 143 | 1e-9 * (elapsed_time.subsec_nanos() as Real); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/random/ranf.rs:128:37 [INFO] [stderr] | [INFO] [stderr] 128 | let numbers = &self.numbers[self.index+1..self.index+request_len+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.index+1..=self.index+request_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/random/ranf.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | *dst = (*src as Real) * INV_MODULO; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(*src)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/random/ranf.rs:128:37 [INFO] [stderr] | [INFO] [stderr] 128 | let numbers = &self.numbers[self.index+1..self.index+request_len+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.index+1..=self.index+request_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/random/ranf.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | *dst = (*src as Real) * INV_MODULO; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(*src)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/resfin.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | let ref ev_cut = cfg.event_cut; [INFO] [stderr] | ----^^^^^^^^^^----------------- help: try: `let ev_cut = &cfg.event_cut;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/resfin.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | let ref ev_cut = cfg.event_cut; [INFO] [stderr] | ----^^^^^^^^^^----------------- help: try: `let ev_cut = &cfg.event_cut;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/scheduling/sequential.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | num_events = num_events % EVENT_BATCH_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_events %= EVENT_BATCH_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/scheduling/sequential.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | num_events = num_events % EVENT_BATCH_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_events %= EVENT_BATCH_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.79s [INFO] running `"docker" "inspect" "26959ba6a3d0529daed26f6b7a8139e6e15f37c651288d79f870acecb9f97a2b"` [INFO] running `"docker" "rm" "-f" "26959ba6a3d0529daed26f6b7a8139e6e15f37c651288d79f870acecb9f97a2b"` [INFO] [stdout] 26959ba6a3d0529daed26f6b7a8139e6e15f37c651288d79f870acecb9f97a2b