[INFO] updating cached repository Guillaume-Mayer/rest-in-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Guillaume-Mayer/rest-in-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Guillaume-Mayer/rest-in-rust" "work/ex/clippy-test-run/sources/stable/gh/Guillaume-Mayer/rest-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Guillaume-Mayer/rest-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Guillaume-Mayer/rest-in-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Guillaume-Mayer/rest-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Guillaume-Mayer/rest-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 86044d8fd37fe880df68d018ff0571c8b64f2da3 [INFO] sha for GitHub repo Guillaume-Mayer/rest-in-rust: 86044d8fd37fe880df68d018ff0571c8b64f2da3 [INFO] validating manifest of Guillaume-Mayer/rest-in-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Guillaume-Mayer/rest-in-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Guillaume-Mayer/rest-in-rust [INFO] finished frobbing Guillaume-Mayer/rest-in-rust [INFO] frobbed toml for Guillaume-Mayer/rest-in-rust written to work/ex/clippy-test-run/sources/stable/gh/Guillaume-Mayer/rest-in-rust/Cargo.toml [INFO] started frobbing Guillaume-Mayer/rest-in-rust [INFO] finished frobbing Guillaume-Mayer/rest-in-rust [INFO] frobbed toml for Guillaume-Mayer/rest-in-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Guillaume-Mayer/rest-in-rust/Cargo.toml [INFO] crate Guillaume-Mayer/rest-in-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Guillaume-Mayer/rest-in-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Guillaume-Mayer/rest-in-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 474f97847b07c6d644ca477571c5210c3dd74315e496e800b594ff0691b59cbe [INFO] running `"docker" "start" "-a" "474f97847b07c6d644ca477571c5210c3dd74315e496e800b594ff0691b59cbe"` [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking hyper v0.9.14 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Checking router v0.4.0 [INFO] [stderr] Checking rest v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:17:33 [INFO] [stderr] | [INFO] [stderr] 17 | let port: u16 = args.next().unwrap_or(String::from("3000")).parse().unwrap_or(3000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("3000"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let ref name = req.extensions.get::().unwrap().find("name").unwrap(); [INFO] [stderr] | ----^^^^^^^^----------------------------------------------------------------- help: try: `let name = &req.extensions.get::().unwrap().find("name").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:17:33 [INFO] [stderr] | [INFO] [stderr] 17 | let port: u16 = args.next().unwrap_or(String::from("3000")).parse().unwrap_or(3000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("3000"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let ref name = req.extensions.get::().unwrap().find("name").unwrap(); [INFO] [stderr] | ----^^^^^^^^----------------------------------------------------------------- help: try: `let name = &req.extensions.get::().unwrap().find("name").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.46s [INFO] running `"docker" "inspect" "474f97847b07c6d644ca477571c5210c3dd74315e496e800b594ff0691b59cbe"` [INFO] running `"docker" "rm" "-f" "474f97847b07c6d644ca477571c5210c3dd74315e496e800b594ff0691b59cbe"` [INFO] [stdout] 474f97847b07c6d644ca477571c5210c3dd74315e496e800b594ff0691b59cbe