[INFO] updating cached repository Gstayton/IslaBot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Gstayton/IslaBot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Gstayton/IslaBot" "work/ex/clippy-test-run/sources/stable/gh/Gstayton/IslaBot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Gstayton/IslaBot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Gstayton/IslaBot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gstayton/IslaBot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gstayton/IslaBot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 441bbd8f0acc2805d76cbb0c9d35a3c62b1b0108 [INFO] sha for GitHub repo Gstayton/IslaBot: 441bbd8f0acc2805d76cbb0c9d35a3c62b1b0108 [INFO] validating manifest of Gstayton/IslaBot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Gstayton/IslaBot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Gstayton/IslaBot [INFO] finished frobbing Gstayton/IslaBot [INFO] frobbed toml for Gstayton/IslaBot written to work/ex/clippy-test-run/sources/stable/gh/Gstayton/IslaBot/Cargo.toml [INFO] started frobbing Gstayton/IslaBot [INFO] finished frobbing Gstayton/IslaBot [INFO] frobbed toml for Gstayton/IslaBot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gstayton/IslaBot/Cargo.toml [INFO] crate Gstayton/IslaBot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Gstayton/IslaBot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Gstayton/IslaBot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 545d533a884449cd213df64dfacb6551049b9743a026e0e205680312d2613ef3 [INFO] running `"docker" "start" "-a" "545d533a884449cd213df64dfacb6551049b9743a026e0e205680312d2613ef3"` [INFO] [stderr] Checking isla_bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/config.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | password: password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/config.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | server: server, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/message.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/message.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/config.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | password: password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/config.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | server: server, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/message.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/message.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `ToSocketAddrs` [INFO] [stderr] --> src/main.rs:3:27 [INFO] [stderr] | [INFO] [stderr] 3 | use std::net::{TcpStream, ToSocketAddrs}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::vec` [INFO] [stderr] --> src/irc/message.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::vec; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ToSocketAddrs` [INFO] [stderr] --> src/main.rs:3:27 [INFO] [stderr] | [INFO] [stderr] 3 | use std::net::{TcpStream, ToSocketAddrs}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::vec` [INFO] [stderr] --> src/irc/message.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::vec; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bufw` [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut bufw = BufWriter::new(stream.try_clone().unwrap()); [INFO] [stderr] | ^^^^ help: consider using `_bufw` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/irc/config.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | Err(e) => None, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut bufw = BufWriter::new(stream.try_clone().unwrap()); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/irc/message.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut args: Vec<&str> = s.splitn(14, ' ').filter(|s| !s.is_empty()).collect(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bufw` [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut bufw = BufWriter::new(stream.try_clone().unwrap()); [INFO] [stderr] | ^^^^ help: consider using `_bufw` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/irc/config.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | Err(e) => None, [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: method `FromStr` should have a snake case name such as `from_str` [INFO] [stderr] --> src/irc/message.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn FromStr(line: &str) -> Result { [INFO] [stderr] 30 | | let mut s: &str = line; [INFO] [stderr] 31 | | let nick: Option<&str> = if s.starts_with(":") { [INFO] [stderr] 32 | | // Consider replacing with a split() [INFO] [stderr] ... | [INFO] [stderr] 77 | | Message::new(Some(sender), contents, line) [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/irc/message.rs:31:51 [INFO] [stderr] | [INFO] [stderr] 31 | let nick: Option<&str> = if s.starts_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/irc/message.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | s = s.find(" :").map_or("", |i| &s[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/irc/message.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match trailing { [INFO] [stderr] 66 | | Some(trailing) => params.push(trailing.trim().to_owned()), [INFO] [stderr] 67 | | _ => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(trailing) = trailing { params.push(trailing.trim().to_owned()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/irc/message.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | prefix.find("!").map(|i| &prefix[..i]).unwrap_or(prefix) [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut bufw = BufWriter::new(stream.try_clone().unwrap()); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/irc/message.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut args: Vec<&str> = s.splitn(14, ' ').filter(|s| !s.is_empty()).collect(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | let resp = r.find(":").map(|i| &r[i..]); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | send_stream(&stream, &format!("PONG {}", resp.unwrap().trim())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: method `FromStr` should have a snake case name such as `from_str` [INFO] [stderr] --> src/irc/message.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn FromStr(line: &str) -> Result { [INFO] [stderr] 30 | | let mut s: &str = line; [INFO] [stderr] 31 | | let nick: Option<&str> = if s.starts_with(":") { [INFO] [stderr] 32 | | // Consider replacing with a split() [INFO] [stderr] ... | [INFO] [stderr] 77 | | Message::new(Some(sender), contents, line) [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | send_stream(&stream, "JOIN #omnius"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/main.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | (); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/irc/message.rs:31:51 [INFO] [stderr] | [INFO] [stderr] 31 | let nick: Option<&str> = if s.starts_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/irc/message.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | s = s.find(" :").map_or("", |i| &s[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/irc/message.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match trailing { [INFO] [stderr] 66 | | Some(trailing) => params.push(trailing.trim().to_owned()), [INFO] [stderr] 67 | | _ => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(trailing) = trailing { params.push(trailing.trim().to_owned()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/irc/message.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | prefix.find("!").map(|i| &prefix[..i]).unwrap_or(prefix) [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | let resp = r.find(":").map(|i| &r[i..]); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | send_stream(&stream, &format!("PONG {}", resp.unwrap().trim())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | send_stream(&stream, "JOIN #omnius"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/main.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | (); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "545d533a884449cd213df64dfacb6551049b9743a026e0e205680312d2613ef3"` [INFO] running `"docker" "rm" "-f" "545d533a884449cd213df64dfacb6551049b9743a026e0e205680312d2613ef3"` [INFO] [stdout] 545d533a884449cd213df64dfacb6551049b9743a026e0e205680312d2613ef3