[INFO] updating cached repository GrossBetruger/ArithMaster [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/GrossBetruger/ArithMaster [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/GrossBetruger/ArithMaster" "work/ex/clippy-test-run/sources/stable/gh/GrossBetruger/ArithMaster"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/GrossBetruger/ArithMaster'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/GrossBetruger/ArithMaster" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GrossBetruger/ArithMaster"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GrossBetruger/ArithMaster'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 30a9b9069a41463ce99179d73f939d44137770fd [INFO] sha for GitHub repo GrossBetruger/ArithMaster: 30a9b9069a41463ce99179d73f939d44137770fd [INFO] validating manifest of GrossBetruger/ArithMaster on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of GrossBetruger/ArithMaster on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing GrossBetruger/ArithMaster [INFO] finished frobbing GrossBetruger/ArithMaster [INFO] frobbed toml for GrossBetruger/ArithMaster written to work/ex/clippy-test-run/sources/stable/gh/GrossBetruger/ArithMaster/Cargo.toml [INFO] started frobbing GrossBetruger/ArithMaster [INFO] finished frobbing GrossBetruger/ArithMaster [INFO] frobbed toml for GrossBetruger/ArithMaster written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GrossBetruger/ArithMaster/Cargo.toml [INFO] crate GrossBetruger/ArithMaster has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting GrossBetruger/ArithMaster against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/GrossBetruger/ArithMaster:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86f5a62ec7b085ee4d0800d847924068d76ba03657951b8c0e23f97713f5fe1a [INFO] running `"docker" "start" "-a" "86f5a62ec7b085ee4d0800d847924068d76ba03657951b8c0e23f97713f5fe1a"` [INFO] [stderr] Checking arithmaster v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return (a, b, (a + b) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, (a + b) as f32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return (a, b, (a - b) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, (a - b) as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return (a, b, (a * b) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, (a * b) as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return (a, e, a.pow(e as u32) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, e, a.pow(e as u32) as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | return (a, b, a as f32 / b as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, a as f32 / b as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match num < 0 { [INFO] [stderr] 144 | | true => format!("({})", num), [INFO] [stderr] 145 | | false => format!("{}", num), [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if num < 0 { format!("({})", num) } else { format!("{}", num) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | / match ask_question(¤t_question_type, ¤t_difficulty) { [INFO] [stderr] 285 | | true => { [INFO] [stderr] 286 | | streak += 1; [INFO] [stderr] 287 | | if streak % STREAK_CONSTANT == 0 { [INFO] [stderr] ... | [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 284 | if ask_question(¤t_question_type, ¤t_difficulty) { [INFO] [stderr] 285 | streak += 1; [INFO] [stderr] 286 | if streak % STREAK_CONSTANT == 0 { [INFO] [stderr] 287 | let praise = PRAISES[praise_counter]; [INFO] [stderr] 288 | if praise_counter < NUM_OF_PRAISES - 1 { [INFO] [stderr] 289 | praise_counter += 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:294:21 [INFO] [stderr] | [INFO] [stderr] 294 | / match streak < SUPER_PRAISES_THRESHOLD { [INFO] [stderr] 295 | | true => print_spaced(&say_praise(&praise)), [INFO] [stderr] 296 | | _ => print_spaced(&say_super_praise(&praise)), [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if streak < SUPER_PRAISES_THRESHOLD { print_spaced(&say_praise(&praise)) } else { print_spaced(&say_super_praise(&praise)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return (a, b, (a + b) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, (a + b) as f32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return (a, b, (a - b) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, (a - b) as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return (a, b, (a * b) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, (a * b) as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return (a, e, a.pow(e as u32) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, e, a.pow(e as u32) as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | return (a, b, a as f32 / b as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b, a as f32 / b as f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match num < 0 { [INFO] [stderr] 144 | | true => format!("({})", num), [INFO] [stderr] 145 | | false => format!("{}", num), [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if num < 0 { format!("({})", num) } else { format!("{}", num) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | / match ask_question(¤t_question_type, ¤t_difficulty) { [INFO] [stderr] 285 | | true => { [INFO] [stderr] 286 | | streak += 1; [INFO] [stderr] 287 | | if streak % STREAK_CONSTANT == 0 { [INFO] [stderr] ... | [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 284 | if ask_question(¤t_question_type, ¤t_difficulty) { [INFO] [stderr] 285 | streak += 1; [INFO] [stderr] 286 | if streak % STREAK_CONSTANT == 0 { [INFO] [stderr] 287 | let praise = PRAISES[praise_counter]; [INFO] [stderr] 288 | if praise_counter < NUM_OF_PRAISES - 1 { [INFO] [stderr] 289 | praise_counter += 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:294:21 [INFO] [stderr] | [INFO] [stderr] 294 | / match streak < SUPER_PRAISES_THRESHOLD { [INFO] [stderr] 295 | | true => print_spaced(&say_praise(&praise)), [INFO] [stderr] 296 | | _ => print_spaced(&say_super_praise(&praise)), [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if streak < SUPER_PRAISES_THRESHOLD { print_spaced(&say_praise(&praise)) } else { print_spaced(&say_super_praise(&praise)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | assert_eq!((a + b) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | assert_eq!((a + b) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!((a - b) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!((a - b) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | assert_eq!((a * b) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | assert_eq!((a * b) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | assert_eq!((a.pow(e as u32)) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | assert_eq!((a.pow(e as u32)) as f32, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:432:9 [INFO] [stderr] | [INFO] [stderr] 432 | file.write(input).expect("filed to write number to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `arithmaster`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "86f5a62ec7b085ee4d0800d847924068d76ba03657951b8c0e23f97713f5fe1a"` [INFO] running `"docker" "rm" "-f" "86f5a62ec7b085ee4d0800d847924068d76ba03657951b8c0e23f97713f5fe1a"` [INFO] [stdout] 86f5a62ec7b085ee4d0800d847924068d76ba03657951b8c0e23f97713f5fe1a