[INFO] updating cached repository Griffone/RustyGame [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Griffone/RustyGame [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Griffone/RustyGame" "work/ex/clippy-test-run/sources/stable/gh/Griffone/RustyGame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Griffone/RustyGame'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Griffone/RustyGame" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Griffone/RustyGame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Griffone/RustyGame'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 44a4271d61d34f72ef7b1c9e2a86908e69a0dde3 [INFO] sha for GitHub repo Griffone/RustyGame: 44a4271d61d34f72ef7b1c9e2a86908e69a0dde3 [INFO] validating manifest of Griffone/RustyGame on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Griffone/RustyGame on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Griffone/RustyGame [INFO] finished frobbing Griffone/RustyGame [INFO] frobbed toml for Griffone/RustyGame written to work/ex/clippy-test-run/sources/stable/gh/Griffone/RustyGame/Cargo.toml [INFO] started frobbing Griffone/RustyGame [INFO] finished frobbing Griffone/RustyGame [INFO] frobbed toml for Griffone/RustyGame written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Griffone/RustyGame/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Griffone/RustyGame against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Griffone/RustyGame:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d9f0e44c82d23dcee7276e7d5358b9cfed0076fd12ae1aadcf3c71f55149e32 [INFO] running `"docker" "start" "-a" "1d9f0e44c82d23dcee7276e7d5358b9cfed0076fd12ae1aadcf3c71f55149e32"` [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking rustc-demangle v0.1.13 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking stb_truetype v0.2.5 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking rand_chacha v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking glium v0.22.0 [INFO] [stderr] Checking rusty_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/graphics.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/graphics.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/graphics.rs:45:4 [INFO] [stderr] | [INFO] [stderr] 45 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/texture.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(TextureCollection {textures: textures, texture: texture}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/texture.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(TextureCollection {textures: textures, texture: texture}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/transform.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Self {translation: translation, rotation: rotation, scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `translation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/transform.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | Self {translation: translation, rotation: rotation, scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rotation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/transform.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | Self {translation: translation, rotation: rotation, scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/scene.rs:104:4 [INFO] [stderr] | [INFO] [stderr] 104 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/scene.rs:114:4 [INFO] [stderr] | [INFO] [stderr] 114 | texture_collection: texture_collection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_collection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/graphics.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/graphics.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/graphics.rs:45:4 [INFO] [stderr] | [INFO] [stderr] 45 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/math.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | Self {min: min, max: max} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/texture.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(TextureCollection {textures: textures, texture: texture}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/texture.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(TextureCollection {textures: textures, texture: texture}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/transform.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Self {translation: translation, rotation: rotation, scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `translation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/transform.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | Self {translation: translation, rotation: rotation, scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rotation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/transform.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | Self {translation: translation, rotation: rotation, scale: scale} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/scene.rs:104:4 [INFO] [stderr] | [INFO] [stderr] 104 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics/scene.rs:114:4 [INFO] [stderr] | [INFO] [stderr] 114 | texture_collection: texture_collection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_collection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/graphics/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub mod graphics; // Graphical context, core module [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics/scene.rs:121:77 [INFO] [stderr] | [INFO] [stderr] 121 | let delta = now.duration_since(self.last_update).subsec_micros() as f32 / 1000000.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/graphics/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub mod graphics; // Graphical context, core module [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/graphics/scene.rs:121:77 [INFO] [stderr] | [INFO] [stderr] 121 | let delta = now.duration_since(self.last_update).subsec_micros() as f32 / 1000000.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/input.rs:189:24 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn load_from_file(path: &std::path::Path) -> Self { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:59:7 [INFO] [stderr] | [INFO] [stderr] 59 | let mut count: i8 = 3; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_debug_mode` [INFO] [stderr] --> src/config.rs:85:2 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn set_debug_mode(&mut self, enabled: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_window_position` [INFO] [stderr] --> src/config.rs:95:2 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn reset_window_position(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_window_size` [INFO] [stderr] --> src/config.rs:105:2 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn reset_window_size(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `short_angle_distance` [INFO] [stderr] --> src/graphics/math.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn short_angle_distance(a: f32, b: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lerp_angle` [INFO] [stderr] --> src/graphics/math.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn lerp_angle(a: f32, b: f32, t: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bounds` [INFO] [stderr] --> src/graphics/math.rs:44:2 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn from_bounds(points: &Bounds) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `grow_to_fit` [INFO] [stderr] --> src/graphics/math.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn grow_to_fit(&mut self, point: &Point) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `min` [INFO] [stderr] --> src/graphics/math.rs:88:2 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn min(&self) -> [f32; 2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `max` [INFO] [stderr] --> src/graphics/math.rs:100:2 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn max(&self) -> [f32; 2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `max_x` [INFO] [stderr] --> src/graphics/math.rs:104:2 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn max_x(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `max_y` [INFO] [stderr] --> src/graphics/math.rs:108:2 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn max_y(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `size` [INFO] [stderr] --> src/graphics/math.rs:128:2 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn size(&self) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DEFAULT_FORMAT` [INFO] [stderr] --> src/graphics/texture.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const DEFAULT_FORMAT: GLTextureFormat = GLTextureFormat::S3tcDxt1Alpha; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `USED_MIPMAP` [INFO] [stderr] --> src/graphics/texture.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const USED_MIPMAP: glium::texture::CompressedMipmapsOption = glium::texture::CompressedMipmapsOption::NoMipmap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graphics/instance.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | fn new( [INFO] [stderr] | _____^ [INFO] [stderr] 18 | | transform: Transform, [INFO] [stderr] 19 | | color_lit: [f32; 4], [INFO] [stderr] 20 | | color_unlit: [f32; 4], [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unlit` [INFO] [stderr] --> src/graphics/instance.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | fn unlit(transform: Transform, color: [f32; 4], texture: &Texture) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_rotation` [INFO] [stderr] --> src/graphics/transform.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn set_rotation(&mut self, angle: f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `translate` [INFO] [stderr] --> src/graphics/transform.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn translate(&mut self, delta: [f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_position` [INFO] [stderr] --> src/graphics/transform.rs:36:2 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn set_position(&mut self, position: [f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_scale` [INFO] [stderr] --> src/graphics/transform.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn set_scale(&mut self, scale: [f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `free_texture_collection` [INFO] [stderr] --> src/graphics/scene.rs:129:2 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn free_texture_collection(self) -> TextureCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `mouse_wheel` [INFO] [stderr] --> src/input.rs:84:2 [INFO] [stderr] | [INFO] [stderr] 84 | mouse_wheel: f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_from_file` [INFO] [stderr] --> src/input.rs:189:2 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn load_from_file(path: &std::path::Path) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_on_key_down` [INFO] [stderr] --> src/input.rs:211:2 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn set_on_key_down(&mut self, key: Key, action: Action) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_on_button_down` [INFO] [stderr] --> src/input.rs:227:2 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn set_on_button_down(&mut self, button: Button, action: Action) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_on_button_up` [INFO] [stderr] --> src/input.rs:259:2 [INFO] [stderr] | [INFO] [stderr] 259 | pub fn set_on_button_up(&mut self, button: Button, action: Action) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_key` [INFO] [stderr] --> src/input.rs:279:2 [INFO] [stderr] | [INFO] [stderr] 279 | pub fn clear_key(&mut self, key: Key) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_button` [INFO] [stderr] --> src/input.rs:283:2 [INFO] [stderr] | [INFO] [stderr] 283 | pub fn clear_button(&mut self, button: Button) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_wheel_delta` [INFO] [stderr] --> src/input.rs:287:2 [INFO] [stderr] | [INFO] [stderr] 287 | pub fn clear_wheel_delta(&mut self, modifiers: KeyModifiers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `absolute_mouse_position` [INFO] [stderr] --> src/input.rs:380:2 [INFO] [stderr] | [INFO] [stderr] 380 | pub fn absolute_mouse_position(&self) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mouse_wheel` [INFO] [stderr] --> src/input.rs:393:2 [INFO] [stderr] | [INFO] [stderr] 393 | pub fn mouse_wheel(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FONT_PREFIX` [INFO] [stderr] --> src/main.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | const FONT_PREFIX: &str = "data/fonts/"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | write!(f, "(IO)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | write!(f, "(Program)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | write!(f, "(VertexBuffer)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | write!(f, "(IndexBuffer)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphics/math.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn from_bounds(points: &Bounds) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/math.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn grow_to_fit(&mut self, point: &Point) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphics/texture.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | texture_filenames: &Vec<&str>, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/texture.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn get(&self, id: &TextureID) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/texture.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | Some(texture) => Some(texture.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | texture_lit: texture_lit.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture_lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | texture_unlit: texture_unlit.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture_unlit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | texture_lit: texture.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | texture_unlit: texture.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/graphics/instance.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | let texture_unlit; [INFO] [stderr] | _________^ [INFO] [stderr] 48 | | if t <= 0.5 { [INFO] [stderr] 49 | | texture_lit = a.texture_lit.clone(); [INFO] [stderr] 50 | | texture_unlit = a.texture_unlit.clone(); [INFO] [stderr] ... | [INFO] [stderr] 53 | | texture_unlit = b.texture_unlit.clone(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let texture_unlit = if t <= 0.5 { ..; a.texture_unlit.clone() } else { ..; b.texture_unlit.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | texture_lit = a.texture_lit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.texture_lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | texture_unlit = a.texture_unlit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.texture_unlit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | texture_lit = b.texture_lit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `b.texture_lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | texture_unlit = b.texture_unlit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `b.texture_unlit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/scene.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | self.view_rect.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.view_rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | fn from_state(&glium::glutin::ModifiersState) -> Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ModifiersState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:212:3 [INFO] [stderr] | [INFO] [stderr] 212 | if self.keys.contains_key(&key) { [INFO] [stderr] | _________^ [INFO] [stderr] 213 | | if let Some(info) = self.keys.get_mut(&key) { [INFO] [stderr] 214 | | info.on_down = action; [INFO] [stderr] 215 | | } [INFO] [stderr] ... | [INFO] [stderr] 223 | | ); [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________^ help: consider using: `self.keys.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:228:3 [INFO] [stderr] | [INFO] [stderr] 228 | if self.buttons.contains_key(&button) { [INFO] [stderr] | _________^ [INFO] [stderr] 229 | | if let Some(info) = self.buttons.get_mut(&button) { [INFO] [stderr] 230 | | info.on_down = action; [INFO] [stderr] 231 | | } [INFO] [stderr] ... | [INFO] [stderr] 239 | | ); [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________^ help: consider using: `self.buttons.entry(button)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | if self.keys.contains_key(&key) { [INFO] [stderr] | _________^ [INFO] [stderr] 245 | | if let Some(info) = self.keys.get_mut(&key) { [INFO] [stderr] 246 | | info.on_up = action; [INFO] [stderr] 247 | | } [INFO] [stderr] ... | [INFO] [stderr] 255 | | ); [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ help: consider using: `self.keys.entry(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:260:3 [INFO] [stderr] | [INFO] [stderr] 260 | if self.buttons.contains_key(&button) { [INFO] [stderr] | _________^ [INFO] [stderr] 261 | | if let Some(info) = self.buttons.get_mut(&button) { [INFO] [stderr] 262 | | info.on_up = action; [INFO] [stderr] 263 | | } [INFO] [stderr] ... | [INFO] [stderr] 271 | | ); [INFO] [stderr] 272 | | } [INFO] [stderr] | |_________^ help: consider using: `self.buttons.entry(button)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:318:10 [INFO] [stderr] | [INFO] [stderr] 318 | state: &glium::glutin::ElementState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ElementState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:319:11 [INFO] [stderr] | [INFO] [stderr] 319 | button: &MouseButton, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | modifiers: &glium::glutin::ModifiersState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ModifiersState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/input.rs:324:12 [INFO] [stderr] | [INFO] [stderr] 324 | button: button.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:354:14 [INFO] [stderr] | [INFO] [stderr] 354 | modifiers: &glium::glutin::ModifiersState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ModifiersState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/input.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | action = wheel_action.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*wheel_action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:248:2 [INFO] [stderr] | [INFO] [stderr] 248 | match event { [INFO] [stderr] | _____^ [INFO] [stderr] 249 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 250 | | glutin::WindowEvent::CloseRequested => window_state.closed = true, [INFO] [stderr] 251 | | glutin::WindowEvent::KeyboardInput { [INFO] [stderr] ... | [INFO] [stderr] 299 | | _ => (), [INFO] [stderr] 300 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 248 | if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 249 | glutin::WindowEvent::CloseRequested => window_state.closed = true, [INFO] [stderr] 250 | glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 251 | input: keyboard_input, [INFO] [stderr] 252 | .. [INFO] [stderr] 253 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/input.rs:189:24 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn load_from_file(path: &std::path::Path) -> Self { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:59:7 [INFO] [stderr] | [INFO] [stderr] 59 | let mut count: i8 = 3; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_debug_mode` [INFO] [stderr] --> src/config.rs:85:2 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn set_debug_mode(&mut self, enabled: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_window_position` [INFO] [stderr] --> src/config.rs:95:2 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn reset_window_position(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_window_size` [INFO] [stderr] --> src/config.rs:105:2 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn reset_window_size(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `short_angle_distance` [INFO] [stderr] --> src/graphics/math.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn short_angle_distance(a: f32, b: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lerp_angle` [INFO] [stderr] --> src/graphics/math.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn lerp_angle(a: f32, b: f32, t: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bounds` [INFO] [stderr] --> src/graphics/math.rs:44:2 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn from_bounds(points: &Bounds) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `grow_to_fit` [INFO] [stderr] --> src/graphics/math.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn grow_to_fit(&mut self, point: &Point) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `min` [INFO] [stderr] --> src/graphics/math.rs:88:2 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn min(&self) -> [f32; 2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `max` [INFO] [stderr] --> src/graphics/math.rs:100:2 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn max(&self) -> [f32; 2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `max_x` [INFO] [stderr] --> src/graphics/math.rs:104:2 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn max_x(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `max_y` [INFO] [stderr] --> src/graphics/math.rs:108:2 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn max_y(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `size` [INFO] [stderr] --> src/graphics/math.rs:128:2 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn size(&self) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DEFAULT_FORMAT` [INFO] [stderr] --> src/graphics/texture.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const DEFAULT_FORMAT: GLTextureFormat = GLTextureFormat::S3tcDxt1Alpha; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `USED_MIPMAP` [INFO] [stderr] --> src/graphics/texture.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const USED_MIPMAP: glium::texture::CompressedMipmapsOption = glium::texture::CompressedMipmapsOption::NoMipmap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graphics/instance.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | fn new( [INFO] [stderr] | _____^ [INFO] [stderr] 18 | | transform: Transform, [INFO] [stderr] 19 | | color_lit: [f32; 4], [INFO] [stderr] 20 | | color_unlit: [f32; 4], [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `unlit` [INFO] [stderr] --> src/graphics/instance.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | fn unlit(transform: Transform, color: [f32; 4], texture: &Texture) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_rotation` [INFO] [stderr] --> src/graphics/transform.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn set_rotation(&mut self, angle: f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `translate` [INFO] [stderr] --> src/graphics/transform.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn translate(&mut self, delta: [f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_position` [INFO] [stderr] --> src/graphics/transform.rs:36:2 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn set_position(&mut self, position: [f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_scale` [INFO] [stderr] --> src/graphics/transform.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn set_scale(&mut self, scale: [f32; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `free_texture_collection` [INFO] [stderr] --> src/graphics/scene.rs:129:2 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn free_texture_collection(self) -> TextureCollection { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `mouse_wheel` [INFO] [stderr] --> src/input.rs:84:2 [INFO] [stderr] | [INFO] [stderr] 84 | mouse_wheel: f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_from_file` [INFO] [stderr] --> src/input.rs:189:2 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn load_from_file(path: &std::path::Path) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_on_key_down` [INFO] [stderr] --> src/input.rs:211:2 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn set_on_key_down(&mut self, key: Key, action: Action) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_on_button_down` [INFO] [stderr] --> src/input.rs:227:2 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn set_on_button_down(&mut self, button: Button, action: Action) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_on_button_up` [INFO] [stderr] --> src/input.rs:259:2 [INFO] [stderr] | [INFO] [stderr] 259 | pub fn set_on_button_up(&mut self, button: Button, action: Action) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_key` [INFO] [stderr] --> src/input.rs:279:2 [INFO] [stderr] | [INFO] [stderr] 279 | pub fn clear_key(&mut self, key: Key) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_button` [INFO] [stderr] --> src/input.rs:283:2 [INFO] [stderr] | [INFO] [stderr] 283 | pub fn clear_button(&mut self, button: Button) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clear_wheel_delta` [INFO] [stderr] --> src/input.rs:287:2 [INFO] [stderr] | [INFO] [stderr] 287 | pub fn clear_wheel_delta(&mut self, modifiers: KeyModifiers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `absolute_mouse_position` [INFO] [stderr] --> src/input.rs:380:2 [INFO] [stderr] | [INFO] [stderr] 380 | pub fn absolute_mouse_position(&self) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mouse_wheel` [INFO] [stderr] --> src/input.rs:393:2 [INFO] [stderr] | [INFO] [stderr] 393 | pub fn mouse_wheel(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FONT_PREFIX` [INFO] [stderr] --> src/main.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | const FONT_PREFIX: &str = "data/fonts/"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | write!(f, "(IO)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | write!(f, "(Program)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | write!(f, "(VertexBuffer)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/graphics/graphics.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | write!(f, "(IndexBuffer)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphics/math.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn from_bounds(points: &Bounds) -> Self { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/math.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn grow_to_fit(&mut self, point: &Point) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graphics/texture.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | texture_filenames: &Vec<&str>, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graphics/texture.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn get(&self, id: &TextureID) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/texture.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | Some(texture) => Some(texture.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | texture_lit: texture_lit.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture_lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | texture_unlit: texture_unlit.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture_unlit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | texture_lit: texture.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | texture_unlit: texture.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/graphics/instance.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | let texture_unlit; [INFO] [stderr] | _________^ [INFO] [stderr] 48 | | if t <= 0.5 { [INFO] [stderr] 49 | | texture_lit = a.texture_lit.clone(); [INFO] [stderr] 50 | | texture_unlit = a.texture_unlit.clone(); [INFO] [stderr] ... | [INFO] [stderr] 53 | | texture_unlit = b.texture_unlit.clone(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let texture_unlit = if t <= 0.5 { ..; a.texture_unlit.clone() } else { ..; b.texture_unlit.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | texture_lit = a.texture_lit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.texture_lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | texture_unlit = a.texture_unlit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `a.texture_unlit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | texture_lit = b.texture_lit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `b.texture_lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/instance.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | texture_unlit = b.texture_unlit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `b.texture_unlit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graphics/scene.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | self.view_rect.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.view_rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | fn from_state(&glium::glutin::ModifiersState) -> Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ModifiersState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:212:3 [INFO] [stderr] | [INFO] [stderr] 212 | if self.keys.contains_key(&key) { [INFO] [stderr] | _________^ [INFO] [stderr] 213 | | if let Some(info) = self.keys.get_mut(&key) { [INFO] [stderr] 214 | | info.on_down = action; [INFO] [stderr] 215 | | } [INFO] [stderr] ... | [INFO] [stderr] 223 | | ); [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________^ help: consider using: `self.keys.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:228:3 [INFO] [stderr] | [INFO] [stderr] 228 | if self.buttons.contains_key(&button) { [INFO] [stderr] | _________^ [INFO] [stderr] 229 | | if let Some(info) = self.buttons.get_mut(&button) { [INFO] [stderr] 230 | | info.on_down = action; [INFO] [stderr] 231 | | } [INFO] [stderr] ... | [INFO] [stderr] 239 | | ); [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________^ help: consider using: `self.buttons.entry(button)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | if self.keys.contains_key(&key) { [INFO] [stderr] | _________^ [INFO] [stderr] 245 | | if let Some(info) = self.keys.get_mut(&key) { [INFO] [stderr] 246 | | info.on_up = action; [INFO] [stderr] 247 | | } [INFO] [stderr] ... | [INFO] [stderr] 255 | | ); [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ help: consider using: `self.keys.entry(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/input.rs:260:3 [INFO] [stderr] | [INFO] [stderr] 260 | if self.buttons.contains_key(&button) { [INFO] [stderr] | _________^ [INFO] [stderr] 261 | | if let Some(info) = self.buttons.get_mut(&button) { [INFO] [stderr] 262 | | info.on_up = action; [INFO] [stderr] 263 | | } [INFO] [stderr] ... | [INFO] [stderr] 271 | | ); [INFO] [stderr] 272 | | } [INFO] [stderr] | |_________^ help: consider using: `self.buttons.entry(button)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:318:10 [INFO] [stderr] | [INFO] [stderr] 318 | state: &glium::glutin::ElementState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ElementState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:319:11 [INFO] [stderr] | [INFO] [stderr] 319 | button: &MouseButton, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | modifiers: &glium::glutin::ModifiersState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ModifiersState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/input.rs:324:12 [INFO] [stderr] | [INFO] [stderr] 324 | button: button.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:354:14 [INFO] [stderr] | [INFO] [stderr] 354 | modifiers: &glium::glutin::ModifiersState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `glium::glutin::ModifiersState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/input.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | action = wheel_action.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*wheel_action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:248:2 [INFO] [stderr] | [INFO] [stderr] 248 | match event { [INFO] [stderr] | _____^ [INFO] [stderr] 249 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 250 | | glutin::WindowEvent::CloseRequested => window_state.closed = true, [INFO] [stderr] 251 | | glutin::WindowEvent::KeyboardInput { [INFO] [stderr] ... | [INFO] [stderr] 299 | | _ => (), [INFO] [stderr] 300 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 248 | if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 249 | glutin::WindowEvent::CloseRequested => window_state.closed = true, [INFO] [stderr] 250 | glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 251 | input: keyboard_input, [INFO] [stderr] 252 | .. [INFO] [stderr] 253 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 29s [INFO] running `"docker" "inspect" "1d9f0e44c82d23dcee7276e7d5358b9cfed0076fd12ae1aadcf3c71f55149e32"` [INFO] running `"docker" "rm" "-f" "1d9f0e44c82d23dcee7276e7d5358b9cfed0076fd12ae1aadcf3c71f55149e32"` [INFO] [stdout] 1d9f0e44c82d23dcee7276e7d5358b9cfed0076fd12ae1aadcf3c71f55149e32