[INFO] updating cached repository GrahamClark/collections-exercises-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/GrahamClark/collections-exercises-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/GrahamClark/collections-exercises-rust" "work/ex/clippy-test-run/sources/stable/gh/GrahamClark/collections-exercises-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/GrahamClark/collections-exercises-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/GrahamClark/collections-exercises-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GrahamClark/collections-exercises-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GrahamClark/collections-exercises-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07217f7bbfeea46e91534db8ae932919ea060e90 [INFO] sha for GitHub repo GrahamClark/collections-exercises-rust: 07217f7bbfeea46e91534db8ae932919ea060e90 [INFO] validating manifest of GrahamClark/collections-exercises-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of GrahamClark/collections-exercises-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing GrahamClark/collections-exercises-rust [INFO] finished frobbing GrahamClark/collections-exercises-rust [INFO] frobbed toml for GrahamClark/collections-exercises-rust written to work/ex/clippy-test-run/sources/stable/gh/GrahamClark/collections-exercises-rust/Cargo.toml [INFO] started frobbing GrahamClark/collections-exercises-rust [INFO] finished frobbing GrahamClark/collections-exercises-rust [INFO] frobbed toml for GrahamClark/collections-exercises-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GrahamClark/collections-exercises-rust/Cargo.toml [INFO] crate GrahamClark/collections-exercises-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting GrahamClark/collections-exercises-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/GrahamClark/collections-exercises-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2c107dee3e7c0a12b3adc6b8b2327db5b0d0290af6cd824eaff72a6d8d60bd8 [INFO] running `"docker" "start" "-a" "d2c107dee3e7c0a12b3adc6b8b2327db5b0d0290af6cd824eaff72a6d8d60bd8"` [INFO] [stderr] Checking collections_exercises v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/employees.rs:3:40 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn staff_to_dept(command: &str, h: HashMap>) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 3 | pub fn staff_to_dept(command: &str, h: HashMap, S>) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/employees.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | h.entry(dept).or_insert(Vec::new()).push(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/employees.rs:3:40 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn staff_to_dept(command: &str, h: HashMap>) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 3 | pub fn staff_to_dept(command: &str, h: HashMap, S>) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/employees.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | h.entry(dept).or_insert(Vec::new()).push(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.03s [INFO] running `"docker" "inspect" "d2c107dee3e7c0a12b3adc6b8b2327db5b0d0290af6cd824eaff72a6d8d60bd8"` [INFO] running `"docker" "rm" "-f" "d2c107dee3e7c0a12b3adc6b8b2327db5b0d0290af6cd824eaff72a6d8d60bd8"` [INFO] [stdout] d2c107dee3e7c0a12b3adc6b8b2327db5b0d0290af6cd824eaff72a6d8d60bd8