[INFO] updating cached repository GodTamIt/caching-simulation-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/GodTamIt/caching-simulation-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/GodTamIt/caching-simulation-rs" "work/ex/clippy-test-run/sources/stable/gh/GodTamIt/caching-simulation-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/GodTamIt/caching-simulation-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/GodTamIt/caching-simulation-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GodTamIt/caching-simulation-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GodTamIt/caching-simulation-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 432a121802f45358eaf526f7704ea7149b85bacb [INFO] sha for GitHub repo GodTamIt/caching-simulation-rs: 432a121802f45358eaf526f7704ea7149b85bacb [INFO] validating manifest of GodTamIt/caching-simulation-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of GodTamIt/caching-simulation-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing GodTamIt/caching-simulation-rs [INFO] finished frobbing GodTamIt/caching-simulation-rs [INFO] frobbed toml for GodTamIt/caching-simulation-rs written to work/ex/clippy-test-run/sources/stable/gh/GodTamIt/caching-simulation-rs/Cargo.toml [INFO] started frobbing GodTamIt/caching-simulation-rs [INFO] finished frobbing GodTamIt/caching-simulation-rs [INFO] frobbed toml for GodTamIt/caching-simulation-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GodTamIt/caching-simulation-rs/Cargo.toml [INFO] crate GodTamIt/caching-simulation-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting GodTamIt/caching-simulation-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/GodTamIt/caching-simulation-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 227c6f0ce5b5f0e2001511ce3168213c2ec330bcf040b689b60afb94af421ab2 [INFO] running `"docker" "start" "-a" "227c6f0ce5b5f0e2001511ce3168213c2ec330bcf040b689b60afb94af421ab2"` [INFO] [stderr] Checking cachesim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/student.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / match find_l2_block(l1_tag, l1_index, &config, &l2) { [INFO] [stderr] 128 | | Some((l2_set_index, _, l2_index)) => { [INFO] [stderr] 129 | | l2.cache[l2_index as usize][l2_set_index].last_clock_access = config.cache_clock; [INFO] [stderr] 130 | | [INFO] [stderr] ... | [INFO] [stderr] 137 | | None => (), [INFO] [stderr] 138 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | if let Some((l2_set_index, _, l2_index)) = find_l2_block(l1_tag, l1_index, &config, &l2) { [INFO] [stderr] 128 | l2.cache[l2_index as usize][l2_set_index].last_clock_access = config.cache_clock; [INFO] [stderr] 129 | [INFO] [stderr] 130 | // Bring block into L1 cache as well [INFO] [stderr] 131 | allocate_l1_block(l1, l2, l1_index, &config); [INFO] [stderr] 132 | update_block(&mut l1.cache[l1_index as usize], l1_tag, true, access_type == AccessType::Write, config.cache_clock); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/student.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / match find_l2_block(l1_tag, l1_index, &config, &l2) { [INFO] [stderr] 128 | | Some((l2_set_index, _, l2_index)) => { [INFO] [stderr] 129 | | l2.cache[l2_index as usize][l2_set_index].last_clock_access = config.cache_clock; [INFO] [stderr] 130 | | [INFO] [stderr] ... | [INFO] [stderr] 137 | | None => (), [INFO] [stderr] 138 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | if let Some((l2_set_index, _, l2_index)) = find_l2_block(l1_tag, l1_index, &config, &l2) { [INFO] [stderr] 128 | l2.cache[l2_index as usize][l2_set_index].last_clock_access = config.cache_clock; [INFO] [stderr] 129 | [INFO] [stderr] 130 | // Bring block into L1 cache as well [INFO] [stderr] 131 | allocate_l1_block(l1, l2, l1_index, &config); [INFO] [stderr] 132 | update_block(&mut l1.cache[l1_index as usize], l1_tag, true, access_type == AccessType::Write, config.cache_clock); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.36s [INFO] running `"docker" "inspect" "227c6f0ce5b5f0e2001511ce3168213c2ec330bcf040b689b60afb94af421ab2"` [INFO] running `"docker" "rm" "-f" "227c6f0ce5b5f0e2001511ce3168213c2ec330bcf040b689b60afb94af421ab2"` [INFO] [stdout] 227c6f0ce5b5f0e2001511ce3168213c2ec330bcf040b689b60afb94af421ab2