[INFO] updating cached repository GlooriousWalrus/learning-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/GlooriousWalrus/learning-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/GlooriousWalrus/learning-rust" "work/ex/clippy-test-run/sources/stable/gh/GlooriousWalrus/learning-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/GlooriousWalrus/learning-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/GlooriousWalrus/learning-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GlooriousWalrus/learning-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GlooriousWalrus/learning-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c34da3250393eebafcda32bc1685e178e2ee276 [INFO] sha for GitHub repo GlooriousWalrus/learning-rust: 5c34da3250393eebafcda32bc1685e178e2ee276 [INFO] validating manifest of GlooriousWalrus/learning-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of GlooriousWalrus/learning-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing GlooriousWalrus/learning-rust [INFO] finished frobbing GlooriousWalrus/learning-rust [INFO] frobbed toml for GlooriousWalrus/learning-rust written to work/ex/clippy-test-run/sources/stable/gh/GlooriousWalrus/learning-rust/Cargo.toml [INFO] started frobbing GlooriousWalrus/learning-rust [INFO] finished frobbing GlooriousWalrus/learning-rust [INFO] frobbed toml for GlooriousWalrus/learning-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/GlooriousWalrus/learning-rust/Cargo.toml [INFO] crate GlooriousWalrus/learning-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting GlooriousWalrus/learning-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/GlooriousWalrus/learning-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddaed5782b1f8bba91fe6ba721e295e908f0b816b8c317a8abb866bf8092ef0d [INFO] running `"docker" "start" "-a" "ddaed5782b1f8bba91fe6ba721e295e908f0b816b8c317a8abb866bf8092ef0d"` [INFO] [stderr] Compiling rand_derive v0.3.1 [INFO] [stderr] Checking bunnies v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/bunny.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | pub const NAMESLIST: [&'static str; 20] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/bunny.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/bunny.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/bunny.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/bunny.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | pub const NAMESLIST: [&'static str; 20] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/bunny.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/bunny.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/bunny.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/game/bunny.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | if self.ghoul == true && self.age > 50 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.ghoul` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/game/bunny.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | else if self.ghoul == false && self.age > 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.ghoul` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/game/bunny.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | if self.ghoul == true && self.age > 50 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.ghoul` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/game/bunny.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | else if self.ghoul == false && self.age > 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.ghoul` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/game/mod.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | colony.retain(|i|i.shoulddie() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!i.shoulddie()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/game/mod.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | colony.retain(|i|i.shoulddie() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!i.shoulddie()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.84s [INFO] running `"docker" "inspect" "ddaed5782b1f8bba91fe6ba721e295e908f0b816b8c317a8abb866bf8092ef0d"` [INFO] running `"docker" "rm" "-f" "ddaed5782b1f8bba91fe6ba721e295e908f0b816b8c317a8abb866bf8092ef0d"` [INFO] [stdout] ddaed5782b1f8bba91fe6ba721e295e908f0b816b8c317a8abb866bf8092ef0d