[INFO] updating cached repository Givup/tick_tack_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Givup/tick_tack_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Givup/tick_tack_rust" "work/ex/clippy-test-run/sources/stable/gh/Givup/tick_tack_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Givup/tick_tack_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Givup/tick_tack_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Givup/tick_tack_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Givup/tick_tack_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0a3d5f766d0b8687e9e4a4409f0ed79fe230e925 [INFO] sha for GitHub repo Givup/tick_tack_rust: 0a3d5f766d0b8687e9e4a4409f0ed79fe230e925 [INFO] validating manifest of Givup/tick_tack_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Givup/tick_tack_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Givup/tick_tack_rust [INFO] finished frobbing Givup/tick_tack_rust [INFO] frobbed toml for Givup/tick_tack_rust written to work/ex/clippy-test-run/sources/stable/gh/Givup/tick_tack_rust/Cargo.toml [INFO] started frobbing Givup/tick_tack_rust [INFO] finished frobbing Givup/tick_tack_rust [INFO] frobbed toml for Givup/tick_tack_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Givup/tick_tack_rust/Cargo.toml [INFO] crate Givup/tick_tack_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Givup/tick_tack_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Givup/tick_tack_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff755cb48f6bd2bb7d6a05f1d5d43d3fd610ca6659addbea48739c1cdced33e2 [INFO] running `"docker" "start" "-a" "ff755cb48f6bd2bb7d6a05f1d5d43d3fd610ca6659addbea48739c1cdced33e2"` [INFO] [stderr] Checking tick_tack_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:133:3 [INFO] [stderr] | [INFO] [stderr] 133 | return (false, (0, 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, (0, 0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `size` [INFO] [stderr] --> src/game.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | if let Ok((size, addr)) = self.socket.recv_from(&mut buffer) { [INFO] [stderr] | ^^^^ help: consider using `_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `packet_size` [INFO] [stderr] --> src/game.rs:96:15 [INFO] [stderr] | [INFO] [stderr] 96 | if let Ok(packet_size) = self.socket.recv(&mut buffer) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_packet_size` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:57:7 [INFO] [stderr] | [INFO] [stderr] 57 | let mut socket = UdpSocket::bind("localhost:0").unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/game.rs:75:11 [INFO] [stderr] | [INFO] [stderr] 75 | if let Ok(_) = socket.recv(&mut buffer) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 76 | | break; [INFO] [stderr] 77 | | } else { [INFO] [stderr] 78 | | continue; [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________- help: try this: `if socket.recv(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/game.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | let output = input.split(",").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | let select = get_valid_input(&vec![1, 2], "Invalid input"); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:133:3 [INFO] [stderr] | [INFO] [stderr] 133 | return (false, (0, 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, (0, 0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `size` [INFO] [stderr] --> src/game.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | if let Ok((size, addr)) = self.socket.recv_from(&mut buffer) { [INFO] [stderr] | ^^^^ help: consider using `_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `packet_size` [INFO] [stderr] --> src/game.rs:96:15 [INFO] [stderr] | [INFO] [stderr] 96 | if let Ok(packet_size) = self.socket.recv(&mut buffer) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_packet_size` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:57:7 [INFO] [stderr] | [INFO] [stderr] 57 | let mut socket = UdpSocket::bind("localhost:0").unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/game.rs:75:11 [INFO] [stderr] | [INFO] [stderr] 75 | if let Ok(_) = socket.recv(&mut buffer) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 76 | | break; [INFO] [stderr] 77 | | } else { [INFO] [stderr] 78 | | continue; [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________- help: try this: `if socket.recv(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/game.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | let output = input.split(",").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | let select = get_valid_input(&vec![1, 2], "Invalid input"); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.70s [INFO] running `"docker" "inspect" "ff755cb48f6bd2bb7d6a05f1d5d43d3fd610ca6659addbea48739c1cdced33e2"` [INFO] running `"docker" "rm" "-f" "ff755cb48f6bd2bb7d6a05f1d5d43d3fd610ca6659addbea48739c1cdced33e2"` [INFO] [stdout] ff755cb48f6bd2bb7d6a05f1d5d43d3fd610ca6659addbea48739c1cdced33e2