[INFO] updating cached repository Givup/interpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Givup/interpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Givup/interpreter" "work/ex/clippy-test-run/sources/stable/gh/Givup/interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Givup/interpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Givup/interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Givup/interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Givup/interpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2300eaf95e6e37c641a55bd93e1d62dc24b57025 [INFO] sha for GitHub repo Givup/interpreter: 2300eaf95e6e37c641a55bd93e1d62dc24b57025 [INFO] validating manifest of Givup/interpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Givup/interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Givup/interpreter [INFO] finished frobbing Givup/interpreter [INFO] frobbed toml for Givup/interpreter written to work/ex/clippy-test-run/sources/stable/gh/Givup/interpreter/Cargo.toml [INFO] started frobbing Givup/interpreter [INFO] finished frobbing Givup/interpreter [INFO] frobbed toml for Givup/interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Givup/interpreter/Cargo.toml [INFO] crate Givup/interpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Givup/interpreter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Givup/interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37a21629a50bd766a28b228bb754447ea1b51863619808f1e05b0d0106ba1027 [INFO] running `"docker" "start" "-a" "37a21629a50bd766a28b228bb754447ea1b51863619808f1e05b0d0106ba1027"` [INFO] [stderr] Checking interpreted v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return (&self.source_lines[0], line, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&self.source_lines[0], line, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return (&self.source_lines[0], line, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&self.source_lines[0], line, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn from_source(&mut self, source: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lexer.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn from_source(&mut self, source: &String) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | a.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | a.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | a.clone() as f32 [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lexer.rs:457:45 [INFO] [stderr] | [INFO] [stderr] 457 | } else if *token == Decimal { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 458 | | true [INFO] [stderr] 459 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lexer.rs:455:35 [INFO] [stderr] | [INFO] [stderr] 455 | if token.is_num() { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 456 | | true [INFO] [stderr] 457 | | } else if *token == Decimal { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lexer.rs:457:24 [INFO] [stderr] | [INFO] [stderr] 457 | } else if *token == Decimal { [INFO] [stderr] | ________________________^ [INFO] [stderr] 458 | | true [INFO] [stderr] 459 | | } else { [INFO] [stderr] 460 | | false [INFO] [stderr] 461 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `*token == Decimal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/main.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if (op.0).is_undef() || true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/main.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if (op.0).is_undef() || true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / fn run(&mut self) { [INFO] [stderr] 89 | | use Token::*; [INFO] [stderr] 90 | | [INFO] [stderr] 91 | | let mut op = (Operator(Operation::NoOp), 0); [INFO] [stderr] ... | [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:233:16 [INFO] [stderr] | [INFO] [stderr] 233 | if let Ok(_) = stdio.read_line(&mut line) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 234 | | let mut line = line.trim(); [INFO] [stderr] 235 | | [INFO] [stderr] 236 | | if line.len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 257 | | break; [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________- help: try this: `if stdio.read_line(&mut line).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `interpreted`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn from_source(&mut self, source: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lexer.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn from_source(&mut self, source: &String) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | a.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | a.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | a.clone() as f32 [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lexer.rs:457:45 [INFO] [stderr] | [INFO] [stderr] 457 | } else if *token == Decimal { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 458 | | true [INFO] [stderr] 459 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lexer.rs:455:35 [INFO] [stderr] | [INFO] [stderr] 455 | if token.is_num() { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 456 | | true [INFO] [stderr] 457 | | } else if *token == Decimal { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lexer.rs:457:24 [INFO] [stderr] | [INFO] [stderr] 457 | } else if *token == Decimal { [INFO] [stderr] | ________________________^ [INFO] [stderr] 458 | | true [INFO] [stderr] 459 | | } else { [INFO] [stderr] 460 | | false [INFO] [stderr] 461 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `*token == Decimal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/main.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if (op.0).is_undef() || true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/main.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if (op.0).is_undef() || true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / fn run(&mut self) { [INFO] [stderr] 89 | | use Token::*; [INFO] [stderr] 90 | | [INFO] [stderr] 91 | | let mut op = (Operator(Operation::NoOp), 0); [INFO] [stderr] ... | [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:233:16 [INFO] [stderr] | [INFO] [stderr] 233 | if let Ok(_) = stdio.read_line(&mut line) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 234 | | let mut line = line.trim(); [INFO] [stderr] 235 | | [INFO] [stderr] 236 | | if line.len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 257 | | break; [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________- help: try this: `if stdio.read_line(&mut line).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `interpreted`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "37a21629a50bd766a28b228bb754447ea1b51863619808f1e05b0d0106ba1027"` [INFO] running `"docker" "rm" "-f" "37a21629a50bd766a28b228bb754447ea1b51863619808f1e05b0d0106ba1027"` [INFO] [stdout] 37a21629a50bd766a28b228bb754447ea1b51863619808f1e05b0d0106ba1027