[INFO] updating cached repository Gisleburt/Skitty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Gisleburt/Skitty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Gisleburt/Skitty" "work/ex/clippy-test-run/sources/stable/gh/Gisleburt/Skitty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Gisleburt/Skitty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Gisleburt/Skitty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gisleburt/Skitty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gisleburt/Skitty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a9a1b8a8fcd99473697944e74e99bf2702ccb525 [INFO] sha for GitHub repo Gisleburt/Skitty: a9a1b8a8fcd99473697944e74e99bf2702ccb525 [INFO] validating manifest of Gisleburt/Skitty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Gisleburt/Skitty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Gisleburt/Skitty [INFO] finished frobbing Gisleburt/Skitty [INFO] frobbed toml for Gisleburt/Skitty written to work/ex/clippy-test-run/sources/stable/gh/Gisleburt/Skitty/Cargo.toml [INFO] started frobbing Gisleburt/Skitty [INFO] finished frobbing Gisleburt/Skitty [INFO] frobbed toml for Gisleburt/Skitty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gisleburt/Skitty/Cargo.toml [INFO] crate Gisleburt/Skitty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Gisleburt/Skitty against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Gisleburt/Skitty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eab0970dab1699cea974df11da26213bdbcdaa71445a095a82ea4bd78185cc5f [INFO] running `"docker" "start" "-a" "eab0970dab1699cea974df11da26213bdbcdaa71445a095a82ea4bd78185cc5f"` [INFO] [stderr] Compiling proc-macro2 v0.4.16 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking notify v4.0.6 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking skitty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/project/json_tools.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | / if path.is_file() { [INFO] [stderr] 21 | | if path.extension().and_then(OsStr::to_str).eq(&Some("json")) { [INFO] [stderr] 22 | | prettify_json_file(&path)?; [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | if path.is_file() && path.extension().and_then(OsStr::to_str).eq(&Some("json")) { [INFO] [stderr] 21 | prettify_json_file(&path)?; [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/project/fs_tools.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | let file = path.file_stem().ok_or(SkittyError::UnknownDirProblem(path.to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| SkittyError::UnknownDirProblem(path.to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/project/fs_tools.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | let dir = path.parent().ok_or(SkittyError::UnknownDirProblem(path.to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| SkittyError::UnknownDirProblem(path.to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/project/json_tools.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | json_file.write(pretty_json.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/project/zip_tools.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | .ok_or(SkittyError::FileSystemUnreadable(file_path.clone()))?)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| SkittyError::FileSystemUnreadable(file_path.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/project/zip_tools.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | zip.write(&bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `skitty`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/project/json_tools.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | / if path.is_file() { [INFO] [stderr] 21 | | if path.extension().and_then(OsStr::to_str).eq(&Some("json")) { [INFO] [stderr] 22 | | prettify_json_file(&path)?; [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | if path.is_file() && path.extension().and_then(OsStr::to_str).eq(&Some("json")) { [INFO] [stderr] 21 | prettify_json_file(&path)?; [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/project/fs_tools.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | let file = path.file_stem().ok_or(SkittyError::UnknownDirProblem(path.to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| SkittyError::UnknownDirProblem(path.to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/project/fs_tools.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | let dir = path.parent().ok_or(SkittyError::UnknownDirProblem(path.to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| SkittyError::UnknownDirProblem(path.to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/project/json_tools.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | json_file.write(pretty_json.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/project/zip_tools.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | .ok_or(SkittyError::FileSystemUnreadable(file_path.clone()))?)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| SkittyError::FileSystemUnreadable(file_path.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/project/zip_tools.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | zip.write(&bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `skitty`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eab0970dab1699cea974df11da26213bdbcdaa71445a095a82ea4bd78185cc5f"` [INFO] running `"docker" "rm" "-f" "eab0970dab1699cea974df11da26213bdbcdaa71445a095a82ea4bd78185cc5f"` [INFO] [stdout] eab0970dab1699cea974df11da26213bdbcdaa71445a095a82ea4bd78185cc5f