[INFO] updating cached repository Gipphe/advent-of-code-2017
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Gipphe/advent-of-code-2017
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Gipphe/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable/gh/Gipphe/advent-of-code-2017"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Gipphe/advent-of-code-2017'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Gipphe/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gipphe/advent-of-code-2017"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gipphe/advent-of-code-2017'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 84c64926d4539c8632fe0b293c41c29fa4a5ffd3
[INFO] sha for GitHub repo Gipphe/advent-of-code-2017: 84c64926d4539c8632fe0b293c41c29fa4a5ffd3
[INFO] validating manifest of Gipphe/advent-of-code-2017 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Gipphe/advent-of-code-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Gipphe/advent-of-code-2017
[INFO] finished frobbing Gipphe/advent-of-code-2017
[INFO] frobbed toml for Gipphe/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable/gh/Gipphe/advent-of-code-2017/Cargo.toml
[INFO] started frobbing Gipphe/advent-of-code-2017
[INFO] finished frobbing Gipphe/advent-of-code-2017
[INFO] frobbed toml for Gipphe/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gipphe/advent-of-code-2017/Cargo.toml
[INFO] crate Gipphe/advent-of-code-2017 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Gipphe/advent-of-code-2017 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Gipphe/advent-of-code-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5d9dd43792fb58c06f2db13bbd2d79a179da0e8bcafe49424755ca5d79265440
[INFO] running `"docker" "start" "-a" "5d9dd43792fb58c06f2db13bbd2d79a179da0e8bcafe49424755ca5d79265440"`
[INFO] [stderr]     Checking advent-of-code-2017 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/day_3/mod.rs:167:17
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let input = 347991;
[INFO] [stderr]     |                 ^^^^^^ help: consider: `347_991`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/day_3/mod.rs:172:24
[INFO] [stderr]     |
[INFO] [stderr] 172 |     assert_eq!(second, 349975, "Day 3-2 is incorrect: {}", second);
[INFO] [stderr]     |                        ^^^^^^ help: consider: `349_975`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/day_4/input.rs:1:19
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const INPUT: &'static str = "pphsv ojtou brvhsj cer ntfhlra udeh ccgtyzc zoyzmh jum lugbnk
[INFO] [stderr]   |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/day_4/mod.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         word
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/day_4/mod.rs:30:20
[INFO] [stderr]    |
[INFO] [stderr] 30 |         let word = String::from_iter(word);
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/day_5/input.rs:1:19
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const INPUT: &'static str = "0
[INFO] [stderr]   |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day_5/mod.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 |     assert_eq!(first, 359348, "Day 5-1 is incorrect: {}", first);
[INFO] [stderr]    |                       ^^^^^^ help: consider: `359_348`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day_5/mod.rs:46:21
[INFO] [stderr]    |
[INFO] [stderr] 46 |     assert_eq!(second, 27688760, "Day 5-2 is incorrect: {}", second);
[INFO] [stderr]    |                        ^^^^^^^^ help: consider: `27_688_760`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/day_7/input.rs:1:19
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const INPUT: &'static str = "xsddbi (61)
[INFO] [stderr]   |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/day_3/mod.rs:167:17
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let input = 347991;
[INFO] [stderr]     |                 ^^^^^^ help: consider: `347_991`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/day_3/mod.rs:172:24
[INFO] [stderr]     |
[INFO] [stderr] 172 |     assert_eq!(second, 349975, "Day 3-2 is incorrect: {}", second);
[INFO] [stderr]     |                        ^^^^^^ help: consider: `349_975`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/day_4/input.rs:1:19
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const INPUT: &'static str = "pphsv ojtou brvhsj cer ntfhlra udeh ccgtyzc zoyzmh jum lugbnk
[INFO] [stderr]   |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/day_4/mod.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         word
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/day_4/mod.rs:30:20
[INFO] [stderr]    |
[INFO] [stderr] 30 |         let word = String::from_iter(word);
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/day_5/input.rs:1:19
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const INPUT: &'static str = "0
[INFO] [stderr]   |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day_5/mod.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 |     assert_eq!(first, 359348, "Day 5-1 is incorrect: {}", first);
[INFO] [stderr]    |                       ^^^^^^ help: consider: `359_348`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/day_5/mod.rs:46:21
[INFO] [stderr]    |
[INFO] [stderr] 46 |     assert_eq!(second, 27688760, "Day 5-2 is incorrect: {}", second);
[INFO] [stderr]    |                        ^^^^^^^^ help: consider: `27_688_760`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/day_7/input.rs:1:19
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const INPUT: &'static str = "xsddbi (61)
[INFO] [stderr]   |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `child`
[INFO] [stderr]    --> src/day_7/mod.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |     for child in root.children {
[INFO] [stderr]     |         ^^^^^ help: consider using `_child` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `sum_weight`
[INFO] [stderr]   --> src/day_7/mod.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn sum_weight(&self) -> u32 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `find_wrong_weight`
[INFO] [stderr]    --> src/day_7/mod.rs:134:1
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn find_wrong_weight(root: Program) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `numbers_line`.
[INFO] [stderr]   --> src/day_2/mod.rs:37:22
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for j in (i + 1)..numbers_line.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for <item> in numbers_line.iter().skip((i + 1)) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_2/mod.rs:39:40
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 if is_evenly_divisible(number as f64, other_number as f64) {
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^ help: try: `f64::from(number)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_2/mod.rs:39:55
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 if is_evenly_divisible(number as f64, other_number as f64) {
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(other_number)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_3/mod.rs:61:24
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn sum_neighbors(grid: &Vec<Vec<u32>>, x: usize, y: usize) -> u32 {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^ help: change this to: `&[Vec<u32>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `words`.
[INFO] [stderr]  --> src/day_4/mod.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 |         for j in (i+1)..words.len() {
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 9 |         for <item> in words.iter().skip((i+1)) {
[INFO] [stderr]   |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `words`.
[INFO] [stderr]   --> src/day_4/mod.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for j in (i + 1)..words.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for <item> in words.iter().skip((i + 1)) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/day_6/mod.rs:1:24
[INFO] [stderr]   |
[INFO] [stderr] 1 | fn find_largest(input: &Vec<u32>) -> usize {
[INFO] [stderr]   |                        ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]  --> src/day_6/mod.rs:4:22
[INFO] [stderr]   |
[INFO] [stderr] 4 |     for (i, x) in input.into_iter().enumerate() {
[INFO] [stderr]   |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]  --> src/day_6/mod.rs:5:6
[INFO] [stderr]   |
[INFO] [stderr] 5 |         if x > &largest {
[INFO] [stderr]   |            ^^^^--------
[INFO] [stderr]   |                |
[INFO] [stderr]   |                help: use the right value directly: `largest`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day_6/mod.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 |         i = i % coll.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `i %= coll.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/day_6/mod.rs:68:23
[INFO] [stderr]    |
[INFO] [stderr] 68 |     let i = (&snapshots).into_iter().position(|a| a == &blocks)
[INFO] [stderr]    |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day_7/mod.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 |               .map(|a| a.weight)
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 18 | |             .fold(0, |acc, c| acc + c);
[INFO] [stderr]    | |______________________________________^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/day_7/mod.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |             .into_iter()
[INFO] [stderr]    |              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/day_7/mod.rs:32:50
[INFO] [stderr]    |
[INFO] [stderr] 32 |             let res = reportedly.into_iter().map(|a| String::from(a)).collect::<Vec<String>>();
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/day_7/mod.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 | /         match get_children(line) {
[INFO] [stderr] 60 | |             Some(childs) => {
[INFO] [stderr] 61 | |                 for child in childs {
[INFO] [stderr] 62 | |                     children.push(child);
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |             None => {},
[INFO] [stderr] 66 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 59 |         if let Some(childs) = get_children(line) {
[INFO] [stderr] 60 |     for child in childs {
[INFO] [stderr] 61 |         children.push(child);
[INFO] [stderr] 62 |     }
[INFO] [stderr] 63 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/day_7/mod.rs:72:31
[INFO] [stderr]    |
[INFO] [stderr] 72 |             match (&children).into_iter().find(|b| &a == b) {
[INFO] [stderr]    |                               ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/day_7/mod.rs:99:18
[INFO] [stderr]    |
[INFO] [stderr] 99 |             .map(|a| String::from(a))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/day_7/mod.rs:114:8
[INFO] [stderr]     |
[INFO] [stderr] 114 |     if program.listed_children.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program.listed_children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec
[INFO] [stderr]    --> src/day_7/mod.rs:118:26
[INFO] [stderr]     |
[INFO] [stderr] 118 |         let i = children.into_iter().position(|a| &a.name == child_name).unwrap();
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter_mut`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/day_7/mod.rs:129:25
[INFO] [stderr]     |
[INFO] [stderr] 129 |     let i = (&programs).into_iter().position(|a| a.name == root_name).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `child`
[INFO] [stderr]    --> src/day_7/mod.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |     for child in root.children {
[INFO] [stderr]     |         ^^^^^ help: consider using `_child` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `sum_weight`
[INFO] [stderr]   --> src/day_7/mod.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn sum_weight(&self) -> u32 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `find_wrong_weight`
[INFO] [stderr]    --> src/day_7/mod.rs:134:1
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn find_wrong_weight(root: Program) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `numbers_line`.
[INFO] [stderr]   --> src/day_2/mod.rs:37:22
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for j in (i + 1)..numbers_line.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for <item> in numbers_line.iter().skip((i + 1)) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_2/mod.rs:39:40
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 if is_evenly_divisible(number as f64, other_number as f64) {
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^ help: try: `f64::from(number)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_2/mod.rs:39:55
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 if is_evenly_divisible(number as f64, other_number as f64) {
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(other_number)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_3/mod.rs:61:24
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn sum_neighbors(grid: &Vec<Vec<u32>>, x: usize, y: usize) -> u32 {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^ help: change this to: `&[Vec<u32>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `words`.
[INFO] [stderr]  --> src/day_4/mod.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 |         for j in (i+1)..words.len() {
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 9 |         for <item> in words.iter().skip((i+1)) {
[INFO] [stderr]   |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `words`.
[INFO] [stderr]   --> src/day_4/mod.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for j in (i + 1)..words.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 37 |         for <item> in words.iter().skip((i + 1)) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/day_6/mod.rs:1:24
[INFO] [stderr]   |
[INFO] [stderr] 1 | fn find_largest(input: &Vec<u32>) -> usize {
[INFO] [stderr]   |                        ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]  --> src/day_6/mod.rs:4:22
[INFO] [stderr]   |
[INFO] [stderr] 4 |     for (i, x) in input.into_iter().enumerate() {
[INFO] [stderr]   |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]  --> src/day_6/mod.rs:5:6
[INFO] [stderr]   |
[INFO] [stderr] 5 |         if x > &largest {
[INFO] [stderr]   |            ^^^^--------
[INFO] [stderr]   |                |
[INFO] [stderr]   |                help: use the right value directly: `largest`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day_6/mod.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 |         i = i % coll.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `i %= coll.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/day_6/mod.rs:68:23
[INFO] [stderr]    |
[INFO] [stderr] 68 |     let i = (&snapshots).into_iter().position(|a| a == &blocks)
[INFO] [stderr]    |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day_7/mod.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 |               .map(|a| a.weight)
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 18 | |             .fold(0, |acc, c| acc + c);
[INFO] [stderr]    | |______________________________________^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/day_7/mod.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |             .into_iter()
[INFO] [stderr]    |              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/day_7/mod.rs:32:50
[INFO] [stderr]    |
[INFO] [stderr] 32 |             let res = reportedly.into_iter().map(|a| String::from(a)).collect::<Vec<String>>();
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/day_7/mod.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 | /         match get_children(line) {
[INFO] [stderr] 60 | |             Some(childs) => {
[INFO] [stderr] 61 | |                 for child in childs {
[INFO] [stderr] 62 | |                     children.push(child);
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |             None => {},
[INFO] [stderr] 66 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 59 |         if let Some(childs) = get_children(line) {
[INFO] [stderr] 60 |     for child in childs {
[INFO] [stderr] 61 |         children.push(child);
[INFO] [stderr] 62 |     }
[INFO] [stderr] 63 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/day_7/mod.rs:72:31
[INFO] [stderr]    |
[INFO] [stderr] 72 |             match (&children).into_iter().find(|b| &a == b) {
[INFO] [stderr]    |                               ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/day_7/mod.rs:99:18
[INFO] [stderr]    |
[INFO] [stderr] 99 |             .map(|a| String::from(a))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/day_7/mod.rs:114:8
[INFO] [stderr]     |
[INFO] [stderr] 114 |     if program.listed_children.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program.listed_children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec
[INFO] [stderr]    --> src/day_7/mod.rs:118:26
[INFO] [stderr]     |
[INFO] [stderr] 118 |         let i = children.into_iter().position(|a| &a.name == child_name).unwrap();
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter_mut`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/day_7/mod.rs:129:25
[INFO] [stderr]     |
[INFO] [stderr] 129 |     let i = (&programs).into_iter().position(|a| a.name == root_name).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.83s
[INFO] running `"docker" "inspect" "5d9dd43792fb58c06f2db13bbd2d79a179da0e8bcafe49424755ca5d79265440"`
[INFO] running `"docker" "rm" "-f" "5d9dd43792fb58c06f2db13bbd2d79a179da0e8bcafe49424755ca5d79265440"`
[INFO] [stdout] 5d9dd43792fb58c06f2db13bbd2d79a179da0e8bcafe49424755ca5d79265440