[INFO] updating cached repository Geemili/mdproof [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Geemili/mdproof [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Geemili/mdproof" "work/ex/clippy-test-run/sources/stable/gh/Geemili/mdproof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Geemili/mdproof'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Geemili/mdproof" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Geemili/mdproof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Geemili/mdproof'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b08816586816fb728c063c662f04a19918b7cde [INFO] sha for GitHub repo Geemili/mdproof: 0b08816586816fb728c063c662f04a19918b7cde [INFO] validating manifest of Geemili/mdproof on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Geemili/mdproof on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Geemili/mdproof [INFO] finished frobbing Geemili/mdproof [INFO] frobbed toml for Geemili/mdproof written to work/ex/clippy-test-run/sources/stable/gh/Geemili/mdproof/Cargo.toml [INFO] started frobbing Geemili/mdproof [INFO] finished frobbing Geemili/mdproof [INFO] frobbed toml for Geemili/mdproof written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Geemili/mdproof/Cargo.toml [INFO] crate Geemili/mdproof has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Geemili/mdproof against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Geemili/mdproof:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33acd06141c4237f4f267c0e0c2a1cfb6eaa2b3256ea2d2b3188480d3d4991f0 [INFO] running `"docker" "start" "-a" "33acd06141c4237f4f267c0e0c2a1cfb6eaa2b3256ea2d2b3188480d3d4991f0"` [INFO] [stderr] Checking pom v1.1.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking clap-verbosity-flag v0.1.0 [INFO] [stderr] Checking quick-xml v0.13.1 [INFO] [stderr] Checking lopdf v0.17.0 [INFO] [stderr] Checking quicli v0.3.1 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking printpdf v0.2.10 [INFO] [stderr] Checking mdproof v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/atomizer.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pages.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pages.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | resources: resources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resources.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resources.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sectioner.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | min_x: min_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sectioner.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sectioner.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | resources: resources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sizer.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sizer.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/atomizer.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pages.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pages.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | resources: resources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resources.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resources.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sectioner.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | min_x: min_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sectioner.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sectioner.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | resources: resources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sizer.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sizer.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_config` [INFO] [stderr] --> src/resources.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn set_config(&mut self, config: Config) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BlockQuote` [INFO] [stderr] --> src/style.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | BlockQuote(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Note` [INFO] [stderr] --> src/style.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Note, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Link` [INFO] [stderr] --> src/style.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Link, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Superscript` [INFO] [stderr] --> src/style.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Superscript, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sectioner.rs:171:12 [INFO] [stderr] | [INFO] [stderr] 171 | if self.current_line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.current_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sectioner.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | if self.current_line.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.current_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:44:42 [INFO] [stderr] | [INFO] [stderr] 44 | Span::Image { width, .. } => width.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | Span::Rect { width, .. } => width.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | Span::Image { height, .. } => height.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | Span::Rect { height, .. } => height.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/style.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / impl ::std::hash::Hash for Style { [INFO] [stderr] 50 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 51 | | for class in self.0.iter() { [INFO] [stderr] 52 | | class.hash(state); [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/style.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Debug, Clone, Eq, PartialEq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | let units_per_em = font.units_per_em() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font.units_per_em())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | .map(|data| data.unit_h_metrics.advance_width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.unit_h_metrics.advance_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | Pt(glyph_space_width * scale.x as f64 / units_per_em) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(scale.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | let height = (v_metrics.ascent - v_metrics.descent + v_metrics.line_gap) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(v_metrics.ascent - v_metrics.descent + v_metrics.line_gap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/util.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn slice_cow_from_idx<'c>(text: &Cow<'c, str>, idx: usize) -> Cow<'c, str> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/util.rs:81:37 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn slice_cow_till_idx<'c>(text: &Cow<'c, str>, idx: usize) -> Cow<'c, str> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match event { [INFO] [stderr] 118 | | atomizer::Event::Atom(atomizer::Atom::Image { uri }) => { [INFO] [stderr] 119 | | loader.queue_image(uri); [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | [INFO] [stderr] 122 | | _ => {} [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 117 | if let atomizer::Event::Atom(atomizer::Atom::Image { uri }) = event { [INFO] [stderr] 118 | loader.queue_image(uri); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mdproof`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `set_config` [INFO] [stderr] --> src/resources.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn set_config(&mut self, config: Config) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BlockQuote` [INFO] [stderr] --> src/style.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | BlockQuote(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Note` [INFO] [stderr] --> src/style.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Note, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Link` [INFO] [stderr] --> src/style.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Link, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Superscript` [INFO] [stderr] --> src/style.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Superscript, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sectioner.rs:171:12 [INFO] [stderr] | [INFO] [stderr] 171 | if self.current_line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.current_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sectioner.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | if self.current_line.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.current_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:44:42 [INFO] [stderr] | [INFO] [stderr] 44 | Span::Image { width, .. } => width.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | Span::Rect { width, .. } => width.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | Span::Image { height, .. } => height.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | Span::Rect { height, .. } => height.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/style.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / impl ::std::hash::Hash for Style { [INFO] [stderr] 50 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 51 | | for class in self.0.iter() { [INFO] [stderr] 52 | | class.hash(state); [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/style.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Debug, Clone, Eq, PartialEq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | let units_per_em = font.units_per_em() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font.units_per_em())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | .map(|data| data.unit_h_metrics.advance_width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.unit_h_metrics.advance_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | Pt(glyph_space_width * scale.x as f64 / units_per_em) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(scale.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | let height = (v_metrics.ascent - v_metrics.descent + v_metrics.line_gap) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(v_metrics.ascent - v_metrics.descent + v_metrics.line_gap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/util.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn slice_cow_from_idx<'c>(text: &Cow<'c, str>, idx: usize) -> Cow<'c, str> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/util.rs:81:37 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn slice_cow_till_idx<'c>(text: &Cow<'c, str>, idx: usize) -> Cow<'c, str> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match event { [INFO] [stderr] 118 | | atomizer::Event::Atom(atomizer::Atom::Image { uri }) => { [INFO] [stderr] 119 | | loader.queue_image(uri); [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | [INFO] [stderr] 122 | | _ => {} [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 117 | if let atomizer::Event::Atom(atomizer::Atom::Image { uri }) = event { [INFO] [stderr] 118 | loader.queue_image(uri); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mdproof`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "33acd06141c4237f4f267c0e0c2a1cfb6eaa2b3256ea2d2b3188480d3d4991f0"` [INFO] running `"docker" "rm" "-f" "33acd06141c4237f4f267c0e0c2a1cfb6eaa2b3256ea2d2b3188480d3d4991f0"` [INFO] [stdout] 33acd06141c4237f4f267c0e0c2a1cfb6eaa2b3256ea2d2b3188480d3d4991f0